message = Message(subject='test', body='this is a test', bcc=['[email protected]'])
mailer.send(message)
transaction.commit()

Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "test.py", line 83, in <module>
    main(sys.argv)
  File "test.py", line 79, in main
    mailer.send(message)
  File "lib/python2.7/site-packages/pyramid_mailer/mailer.py", line 178, in send
    return self.direct_delivery.send(*self._message_args(message))
  File "lib/python2.7/site-packages/pyramid_mailer/mailer.py", line 222, in _message_args
    message.to_message())
  File "lib/python2.7/site-packages/pyramid_mailer/message.py", line 82, in to_message
    self.validate()
  File "lib/python2.7/site-packages/pyramid_mailer/message.py", line 132, in validate
    raise InvalidMessage, "No recipients have been added"
pyramid_mailer.exceptions.InvalidMessage: No recipients have been added

We are using pyramid mailer debug for manual QA of features. It would be nice to have a configuration option to include the bcc field (in any format) as part of the .msg files for ease of testing. I can provide the PR if we agree this would be useful.

Hi I am trying to attach a pdf and when I do some sort of encoding issue pops up. I can send a csv file no problem it's only when I add the pdf (or another binary file like a gpg key) that this encoding issue comes up.

I saw issue 17 which seems similar to mine but that is fixed in the versions I am using right?

This is the code I am using, I've tried setting the disposition explicitly to 'attachment' as well as using the full file location for the file name.

   csv_attachment = Attachment("%s.csv" % report.name, "text/csv", open(csv_loc, "rb"), 'attachment')
   pdf_attachment = Attachment("%s.pdf" % report.name, "application/pdf", open(pdf_loc, "rb"), 'attachment')

    body = render('mail/report.mak', {'user':user, 'report':report}, request)
    message = Message(subject='Famoso Reporting - %s' % report.name,
                sender='Famoso Admin <[email protected]>',
                recipients=[user.email],
                body=body,
                attachments=[csv_attachment,pdf_attachment])
    mailer.send(message)

Here is the traceback of the error:

Traceback (most recent call last): File "/Users/rottaway/PyEnvs/famoso_reports/lib/python2.6/site-packages/waitress-0.8.1-py2.6.egg/waitress/channel.py", line 329, in service task.service() File "/Users/rottaway/PyEnvs/famoso_reports/lib/python2.6/site-packages/waitress-0.8.1-py2.6.egg/waitress/task.py", line 173, in service self.execute() File "/Users/rottaway/PyEnvs/famoso_reports/lib/python2.6/site-packages/waitress-0.8.1-py2.6.egg/waitress/task.py", line 380, in execute app_iter = self.channel.server.application(env, start_response) File "/Users/rottaway/PyEnvs/famoso_reports/lib/python2.6/site-packages/pyramid/router.py", line 187, in call response = self.handle_request(request) File "/Users/rottaway/PyEnvs/famoso_reports/lib/python2.6/site-packages/pyramid/tweens.py", line 20, in excview_tween response = handler(request) File "/Users/rottaway/PyEnvs/famoso_reports/lib/python2.6/site-packages/pyramid_tm-0.4-py2.6.egg/pyramid_tm/init.py", line 102, in tm_tween return response File "/Users/rottaway/PyEnvs/famoso_reports/lib/python2.6/site-packages/transaction/_manager.py", line 96, in exit self.commit() File "/Users/rottaway/PyEnvs/famoso_reports/lib/python2.6/site-packages/transaction/_manager.py", line 89, in commit return self.get().commit() File "/Users/rottaway/PyEnvs/famoso_reports/lib/python2.6/site-packages/transaction/_transaction.py", line 342, in commit reraise(t, v, tb) File "/Users/rottaway/PyEnvs/famoso_reports/lib/python2.6/site-packages/transaction/_transaction.py", line 333, in commit self._commitResources() File "/Users/rottaway/PyEnvs/famoso_reports/lib/python2.6/site-packages/transaction/_transaction.py", line 473, in _commitResources reraise(t, v, tb) File "/Users/rottaway/PyEnvs/famoso_reports/lib/python2.6/site-packages/transaction/_transaction.py", line 455, in _commitResources rm.tpc_finish(self) File "/Users/rottaway/PyEnvs/famoso_reports/lib/python2.6/site-packages/repoze/sendmail/delivery.py", line 70, in tpc_finish self.callable(*self.args) File "/Users/rottaway/PyEnvs/famoso_reports/lib/python2.6/site-packages/repoze/sendmail/mailer.py", line 53, in send message = encode_message(message) File "/Users/rottaway/PyEnvs/famoso_reports/lib/python2.6/site-packages/repoze/sendmail/encoding.py", line 101, in encode_message return message.as_string().encode('ascii') UnicodeDecodeError: 'ascii' codec can't decode byte 0xb5 in position 1476: ordinal not in range(128)

This also:

• Drops Python 2.7 support
• Removes Python 2.7 compatibility switches
• Combines the coverage steps into one
• Updates the docs etc, to run in Python 3.9
• No longer permits failures in Python 3.8 in Travis

Hi, I tried send an email with pyramid_mailer using mailer.send_immediately(message_instance) I given this: *** TypeError: unorderable types: str() > int()

https://www.dropbox.com/s/rvxggi0wqdtdarl/Captura%20de%20tela%202015-05-21%2017.19.38.png?dl=0

Use-case: I construct Messages in my code without a sender, because I want to use the default_sender as the sender. Works as a charm with Mailer.

However, when I use DebugMailer with these Messages, I get a message a validation error, because the sender is not set. The Mailer class takes care of setting the sender if default sender is set, but the DebugMailer does not do that. This patch then sets a dummy sender, if no sender is set in Message, to allow using DebugMailer with sender-less Messages.

Yesterday marks 3 years since the last release of Python 2.6! 🎉

To celebrate, I'm attempting to drop support for it from 156 prominent Python packages (one for every week it's past end-of-life)--including this one!

I've tried my best to remove as much 2.6-specific cruft as I can, but at the very least, this PR will remove the 'Programming Language :: Python :: 2.6' trove classifier from this projects setup.py.

This fails:

def test_multipart_encoding(self):
    from repoze.sendmail import encoding
    from pyramid_mailer.message import Message

    msg = Message(subject="testing",
                  sender="[email protected]",
                  body=u"tästing",
                  html=u"<b>tästing</b>",
                  recipients=["[email protected]"])
    result = encoding.encode_message(msg.to_message())

It worked fine with repoze.sendmail 2.3 and the pyramid-mailer 0.6.

Either I use it wrong, or there is a problem in pyramid-mailer or repoze.sendmail.

Fix the email line ending as required by RFC2822 on Python 3 by using the Python 3.2 compatibility policy with custom line ending. This is indeed a bug in pyramid_mailer; the email.policy package contains different serialization formats - the one used by default uses \n for line endings and is thus not suitable for sending emails; for that a serializer policy that uses \r\n is needed.

Now one question is that if a message is queued in a file then the line endings can be changed again...

As per title currently including (via config.include('pyramid_mailer') pyramid_mailer breaks my application with:

File "/home/ergo/Private/workspace/pyramid_mailer/pyramid_mailer/init.py", line 11, in mailer_factory_from_settings return Mailer.from_settings(settings, prefix) File "/home/ergo/Private/workspace/pyramid_mailer/pyramid_mailer/mailer.py", line 281, in from_settings return cls(username=username, password=password, **kwargs) File "/home/ergo/Private/workspace/pyramid_mailer/pyramid_mailer/mailer.py", line 226, in init self.smtp_mailer, transaction_manager=transaction_manager) TypeError: init() got an unexpected keyword argument 'transaction_manager'

I've made a PR that resolves this, the test suite passes and I was able to successfully send email via: mailer.send(message) and mailer.send_immediatelly(message)

As stated in the title, using pyramid.includes = pyramid_mailer.testing won't add the mailer attribute to a request object, while pyramid.includes = pyramid_mailer does add the attribute.

This almost seems like an oversight, except that that testing.py was last touched almost six years ago (and I can't find a history of anyone complaining about this).

What was the reasoning behind this?

Python 3.10, if relevant,

>>> m = pyramid_mailer.message.Message(sender='ÄÖ <foo@bar>', recipients=['baz@quux'], body='foo')
>>> print(m.to_message().as_string())
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: =?utf-8?b?w4TDliA8Zm9vQGJhcj4=?=
To: baz@quux
Content-Disposition: inline

foo

The header is incorrectly quoted, the quoting must not affect the actual header. For example Amazon SES is unable to handle this. Not sure if anything else would either. I guess the fix would be to use the email.message.EmailMessage from Python 3.6+.

Sometimes, e.g. in a containerised batch emailer, it is desirable to use pyramid_mailer without pulling in pyramid.

The dependency exists only so that a few dozen lines of list manipulation functions can be used.

This commit copies this code into pyramid_mailer and slightly simplifies it.

master has seen quite a bit of activity since the last release: https://github.com/Pylons/pyramid_mailer/compare/0.15.1...master

Might it be a good idea to cut a new release? :thinking:

It's good practice on automatic generated mails to haven automatic error handling. To be able to have errors while delivering the Mail automatically handled is to have a e-mail address that processes bounces. The sender of a mail should be an address where a human reads the Mails.

So we need two different senders on one mail. One that is only used while delivering the mail and on the recipient sees a sender of this mail.

Most do this by using the automatic bounce processing address as envelop from and the human address in the From: header. So the recipient of the Mails only see the Human address but the delivery system sees the automatic address as sender.

The Errors-To: header isn't really supported and the automatic address as sender and the human address as Reply-To: do work most of the times but exposes the automatic address as sender is usualy a unreadable address.

Is there a way to get if the pyramid_mailer is correctly configured (connection with the SMTP server is possible with given credentials).

I know I could do that by sending an email to a wrong mailbox, but I would like to avoid doing that if possible. Is it possible to add a ping() method to the mailer that would answer true or false depending of is the connection was successful or not?