Hi!

Python 3.7 raises the following warning:

DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

We're running our tests with all warnings turned to errors, so they fail on that. This PR fixes that (and adds python 3.7 to tox.ini).

Is there a way to use the functionality for configuring a mock to return specific values (using side_effect as it seems from how mock works) when called with specific parameters?

When I run some tests with pytest and callee 0.3, this is printed at the end:

============================== warnings summary ===============================
c:\users\rnd10\appdata\local\programs\python\python37-32\lib\site-packages\callee\collections.py:74
  c:\users\rnd10\appdata\local\programs\python\python37-32\lib\site-packages\callee\collections.py:74: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
    CLASS = collections.Iterable

c:\users\rnd10\appdata\local\programs\python\python37-32\lib\site-packages\callee\collections.py:116
  c:\users\rnd10\appdata\local\programs\python\python37-32\lib\site-packages\callee\collections.py:116: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
    CLASS = collections.Sequence

c:\users\rnd10\appdata\local\programs\python\python37-32\lib\site-packages\callee\collections.py:128
  c:\users\rnd10\appdata\local\programs\python\python37-32\lib\site-packages\callee\collections.py:128: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
    CLASS = collections.Set

c:\users\rnd10\appdata\local\programs\python\python37-32\lib\site-packages\callee\collections.py:246
  c:\users\rnd10\appdata\local\programs\python\python37-32\lib\site-packages\callee\collections.py:246: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
    CLASS = collections.Mapping

-- Docs: https://docs.pytest.org/en/latest/warnings.html
======================= 78 passed, 4 warnings in 1.38s ========================

Pytest version info:

platform win32 -- Python 3.7.3, pytest-5.1.0, py-1.8.0, pluggy-0.12.0
plugins: cov-2.7.1, ordering-0.6, pycharm-0.6.0

Solution suggestions: https://stackoverflow.com/questions/53978542/how-to-use-collections-abc-from-both-python-3-8-and-python-2-7

I cannot use the And matcher in my tests, since the test crashes if mock decides to print out the matcher using __repr__. It looks like the __repr__ functions for And and Or incorrectly have the value argument?

I assume these haven't actually been used previously, since these two methods also reference self.matchers instead of the correct self._matchers (which would have been caught earlier if they were actually called).

Let me know if the value arg is intended behaviour. It seems that the value arg is not used though, and it's highly unusual for __repr__() to have more args than just self.

Hi @Xion or other people who maintains this project,

What is the status of this project? This is a great tool for testing, I would like to keep using but looks like it hasn't been maintained for a while.

If there are any alternatives we could use, that information would be appreciated, too.

Thanks!

Following tests emit deprecation warning regarding this as below :

tests/test_objects.py
80:        @asyncio.coroutine
103:        @asyncio.coroutine

tests/test_functions.py
176:        @asyncio.coroutine
199:        @asyncio.coroutine

tests/test_functions.py::CoroutineFunction::test_coroutine__decorator
  /root/checked_repos/callee/tests/test_functions.py:177: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
    def coro_func(loop):

tests/test_functions.py::CoroutineFunction::test_coroutine_function__decorator
  /root/checked_repos/callee/tests/test_functions.py:200: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
    def coro_func(loop):

tests/test_objects.py::Coroutine::test_coroutine__decorator
  /root/checked_repos/callee/tests/test_objects.py:81: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
    def coro_func(loop):

tests/test_objects.py::Coroutine::test_coroutine_function__decorator
  /root/checked_repos/callee/tests/test_objects.py:104: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
    def coro_func(loop):

Docs give the example:

dict with string keys (no restriction on values)

Dict(keys=String())

But this will fail because the code expects both keys and value to be defined. Also there is not test case for this example. Is this docs error or code error?

Deprecation warning due to invalid escape sequences. Using raw strings or escaping them again helps in resolving this. Check https://github.com/asottile/pyupgrade/ for automatic fix of this.

find . -iname '*.py' | grep -Ev 'rdf4|tool' | xargs -P4 -I{} python3.8 -Wall -m py_compile {}
./callee/collections.py:98: DeprecationWarning: invalid escape sequence \ 
  """Matches an iterable that's a generator.
./callee/types.py:19: DeprecationWarning: invalid escape sequence \ 
  """:param type\ _: Type to match against"""
./callee/types.py:35: DeprecationWarning: invalid escape sequence \ 
  """
./callee/types.py:61: DeprecationWarning: invalid escape sequence \ 
  """
./callee/operators.py:188: DeprecationWarning: invalid escape sequence \ 
  """Matches values that are shorter than,
./callee/operators.py:206: DeprecationWarning: invalid escape sequence \ 
  """Matches values that are longer than,
./callee/numbers.py:46: DeprecationWarning: invalid escape sequence \ 
  """Matches any complex number.
./callee/numbers.py:60: DeprecationWarning: invalid escape sequence \ 
  """Matches any real number.
./callee/numbers.py:75: DeprecationWarning: invalid escape sequence \ 
  """Matches a rational number.
./callee/base.py:150: DeprecationWarning: invalid escape sequence \ 
  """Provides a default ``repr``\ esentation for custom matchers.

Currently the following will fail

from callee.general import Captor
from mock import Mock

mock = Mock()
mock(1)

captor = Captor()
mock.assert_called_with(captor)
assert 1 == captor.value  # This is ok!

mock(2)
mock.assert_called_with(captor)  # Fails with ValueError: a value has already been captured

This is somewhat inconsistent with how Mock::assert_called_with works. For example:

mock = Mock()

mock(1)
mock(2)
mock(3)

mock.assert_called_with(3)  # This is ok!

There are multiple ways to deal with this.

• Allow Captor to be created with an allow_multiple_captures parameter and set the value to the last captured argument

captor = Captor(allow_multiple_captures=True)  # False by default?
mock = Mock()
mock(1)
mock(2)
mock.assert_called_with(captor)
assert 2 == captor.value

• Allow Captor to match multiple arguments and save them in a list

captor = Captor(matcher=lambda x: x < 2, allow_multiple_captures=True)
mock = Mock()
mock(1)
mock(2)

mock.assert_called_with(captor)
assert [1, 2] == captor.values
assert [Match(1, True), Match(2, False)] == captor.matches

• Create a MultiCaptor Captor that will collect all matches for a given argument