Hi aluzzardi

I just started a project based on your wssh implementation. But for now i stopped working on it because i noticed that i don't have a clue about the license of wssh. Would be very nice if you could take a license note on wssh.

Thanks RedDog

Hi,

I needed to execute a command directly, thought I will need to hack the implementation, but found that you already thought of it :)

I found one issue that may be a typo, and also exposed the usage so other people know it is supported.

Thanks!

thanks,aluzzardi. sorry everyboy for my english.

diff --git a/wssh/server.py b/wssh/server.py
index 17a4965..b334477 100644
--- a/wssh/server.py
+++ b/wssh/server.py
@@ -118,19 +118,26 @@ class WSSHBridge(object):
                         data['resize'].get('width', 80),
                         data['resize'].get('height', 24))
                 if 'data' in data:
-                    channel.send(data['data'])
+                    channel.send(data['data'].encode('utf-8'))
         finally:
             self.close()

     def _forward_outbound(self, channel):
         """ Forward outbound traffic (ssh -> websockets) """
         try:
+            data = ''
             while True:
                 wait_read(channel.fileno())
-                data = channel.recv(1024)
-                if not len(data):
+                recv = channel.recv(1024)
+                if not len(recv):
                     return
-                self._websocket.send(json.dumps({'data': data}))
+                
+                data += recv
+                try:
+                    self._websocket.send(json.dumps({'data':data}))
+                    data = ''
+                except UnicodeDecodeError:
+                    pass
         finally:
             self.close()

diff --git a/wssh/static/term.js b/wssh/static/term.js
index 9489334..20883bf 100644
--- a/wssh/static/term.js
+++ b/wssh/static/term.js
@@ -129,9 +129,10 @@ function Terminal(cols, rows, handler) {

   this.cols = cols || Terminal.geometry[0];
   this.rows = rows || Terminal.geometry[1];
-
-  if (handler) {
-    this.on('data', handler);
+  this.handler = handler;
+  
+  if (this.handler) {
+    this.on('data', this.handler);
   }

   this.ybase = 0;
@@ -2432,7 +2433,7 @@ Terminal.prototype.reverseIndex = function() {

 // ESC c Full Reset (RIS).
 Terminal.prototype.reset = function() {
-  Terminal.call(this, this.cols, this.rows);
+  Terminal.call(this, this.cols, this.rows, this.handler);
   this.refresh(0, this.rows - 1);
 };

fixes some bugs:

• could not change port any other except of 5000 caused by --port argument did not parsed as int.
• term.js did not loaded properly caused by github serves raw files only in text/html

When I run wsshd in the Terminal,it throw error

File "/usr/local/lib/python2.7/dist-packages/wssh-0.1.0-py2.7.egg/EGG-INFO/scripts/wsshd", line 65, in from geventwebsocket import WebSocketHandler

ImportError: cannot import name WebSocketHandler

I view the page https://pypi.python.org/pypi/gevent-websocket/ I think the script wssd line 65 should change from geventwebsocket import WebSocketHandler to from geventwebsocket.handler import WebSocketHandler

<script type="application/javascript" src="{{url_for('static', filename='jquery.min.js}}}">
    </script>
    <script type="application/javascript" src="{{url_for('static', filename='term.js')}}">
    </script

When text contains chinese charactor, wssh will shutdown with situation like blow. The wssd logs show nothing, who can help me? thanks

log： [root@paasm1 ~]# more /test/aaa.txt 关于大胜靠德卡和扩大后方可速度快发送会计法 发生发大水 发生的 房东说Connection Reset By Peer

Hi!

If the data is not being encoded to UTF-8 the bridge closes the connection because an unexpected exception. This could be easily reproduced sending {"data":"ñ"} via websocket.

Hi ,

Can anyone clarify below doubt:--

1. How browser is creating web socket and sending it?
2. How request.environ.get('wsgi.websocket') receive web socket?

If anyone can clarify it will be great help

After start wssd on linux terminal，login linux by browser, and click the connect button, below appeared:

Error: from_buffer() cannot return the address of the raw string within a str or unicode or bytearray object
Connection Reset By peer.

logs:

DEBUG in wsshd [/usr/lib/python2.7/site-packages/wssh-0.1.0-py2.7.egg/EGG-INFO/scripts/wsshd:27]: 192.168.1.115 -> root@localhost: [interactive shell]

ERROR in wsshd [/usr/lib/python2.7/site-packages/wssh-0.1.0-py2.7.egg/EGG-INFO/scripts/wsshd:47]: Error while connecting to localhost: from_buffer() cannot return the address of the raw string within a str or unicode or bytearray object

Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/wssh-0.1.0-py2.7.egg/EGG-INFO/scripts/wsshd", line 44, in connect allow_agent=app.config.get('WSSH_ALLOW_SSH_AGENT', False)) File "/usr/lib/python2.7/site-packages/wssh-0.1.0-py2.7.egg/wssh/server.py", line 98, in open look_for_keys=False) File "/usr/lib/python2.7/site-packages/paramiko/client.py", line 380, in connect look_for_keys, gss_auth, gss_kex, gss_deleg_creds, gss_host) File "/usr/lib/python2.7/site-packages/paramiko/client.py", line 608, in _auth self._transport.auth_password(username, password) File "/usr/lib/python2.7/site-packages/paramiko/transport.py", line 1266, in auth_password self.auth_handler.auth_password(username, password, my_event) File "/usr/lib/python2.7/site-packages/paramiko/auth_handler.py", line 107, in auth_password self._request_auth() File "/usr/lib/python2.7/site-packages/paramiko/auth_handler.py", line 158, in _request_auth self.transport._send_message(m) File "/usr/lib/python2.7/site-packages/paramiko/transport.py", line 1587, in _send_message self.packetizer.send_message(data) File "/usr/lib/python2.7/site-packages/paramiko/packet.py", line 360, in send_message out = self.__block_engine_out.update(packet) File "/usr/lib64/python2.7/site-packages/cryptography/hazmat/primitives/ciphers/base.py", line 149, in update return self._ctx.update(data) File "/usr/lib64/python2.7/site-packages/cryptography/hazmat/backends/openssl/ciphers.py", line 120, in update n = self.update_into(data, buf) File "/usr/lib64/python2.7/site-packages/cryptography/hazmat/backends/openssl/ciphers.py", line 131, in update_into "unsigned char *", self._backend._ffi.from_buffer(buf) TypeError: from_buffer() cannot return the address of the raw string within a str or unicode or bytearray object

DEBUG in wsshd [/usr/lib/python2.7/site-packages/wssh-0.1.0-py2.7.egg/EGG-INFO/scripts/wsshd:27]: 192.168.1.115 -> [email protected]: [interactive shell]

ERROR in wsshd [/usr/lib/python2.7/site-packages/wssh-0.1.0-py2.7.egg/EGG-INFO/scripts/wsshd:47]: Error while connecting to 127.0.0.1: from_buffer() cannot return the address of the raw string within a str or unicode or bytearray object

Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/wssh-0.1.0-py2.7.egg/EGG-INFO/scripts/wsshd", line 44, in connect allow_agent=app.config.get('WSSH_ALLOW_SSH_AGENT', False)) File "/usr/lib/python2.7/site-packages/wssh-0.1.0-py2.7.egg/wssh/server.py", line 98, in open look_for_keys=False) File "/usr/lib/python2.7/site-packages/paramiko/client.py", line 380, in connect look_for_keys, gss_auth, gss_kex, gss_deleg_creds, gss_host) File "/usr/lib/python2.7/site-packages/paramiko/client.py", line 608, in _auth self._transport.auth_password(username, password) File "/usr/lib/python2.7/site-packages/paramiko/transport.py", line 1266, in auth_password self.auth_handler.auth_password(username, password, my_event) File "/usr/lib/python2.7/site-packages/paramiko/auth_handler.py", line 107, in auth_password self._request_auth() File "/usr/lib/python2.7/site-packages/paramiko/auth_handler.py", line 158, in _request_auth self.transport._send_message(m) File "/usr/lib/python2.7/site-packages/paramiko/transport.py", line 1587, in _send_message self.packetizer.send_message(data) File "/usr/lib/python2.7/site-packages/paramiko/packet.py", line 360, in send_message out = self.__block_engine_out.update(packet) File "/usr/lib64/python2.7/site-packages/cryptography/hazmat/primitives/ciphers/base.py", line 149, in update return self._ctx.update(data) File "/usr/lib64/python2.7/site-packages/cryptography/hazmat/backends/openssl/ciphers.py", line 120, in update n = self.update_into(data, buf) File "/usr/lib64/python2.7/site-packages/cryptography/hazmat/backends/openssl/ciphers.py", line 131, in update_into "unsigned char *", self._backend._ffi.from_buffer(buf) TypeError: from_buffer() cannot return the address of the raw string within a str or unicode or bytearray object

DEBUG in wsshd [/usr/lib/python2.7/site-packages/wssh-0.1.0-py2.7.egg/EGG-INFO/scripts/wsshd:27]: 192.168.1.115 -> aaronwtl@localhost: [interactive shell]

ERROR in wsshd [/usr/lib/python2.7/site-packages/wssh-0.1.0-py2.7.egg/EGG-INFO/scripts/wsshd:47]: Error while connecting to localhost: from_buffer() cannot return the address of the raw string within a str or unicode or bytearray object

Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/wssh-0.1.0-py2.7.egg/EGG-INFO/scripts/wsshd", line 44, in connect allow_agent=app.config.get('WSSH_ALLOW_SSH_AGENT', False)) File "/usr/lib/python2.7/site-packages/wssh-0.1.0-py2.7.egg/wssh/server.py", line 98, in open look_for_keys=False) File "/usr/lib/python2.7/site-packages/paramiko/client.py", line 380, in connect look_for_keys, gss_auth, gss_kex, gss_deleg_creds, gss_host) File "/usr/lib/python2.7/site-packages/paramiko/client.py", line 608, in _auth self._transport.auth_password(username, password) File "/usr/lib/python2.7/site-packages/paramiko/transport.py", line 1266, in auth_password self.auth_handler.auth_password(username, password, my_event) File "/usr/lib/python2.7/site-packages/paramiko/auth_handler.py", line 107, in auth_password self._request_auth() File "/usr/lib/python2.7/site-packages/paramiko/auth_handler.py", line 158, in _request_auth self.transport._send_message(m) File "/usr/lib/python2.7/site-packages/paramiko/transport.py", line 1587, in _send_message self.packetizer.send_message(data) File "/usr/lib/python2.7/site-packages/paramiko/packet.py", line 360, in send_message out = self.__block_engine_out.update(packet) File "/usr/lib64/python2.7/site-packages/cryptography/hazmat/primitives/ciphers/base.py", line 149, in update return self._ctx.update(data) File "/usr/lib64/python2.7/site-packages/cryptography/hazmat/backends/openssl/ciphers.py", line 120, in update n = self.update_into(data, buf) File "/usr/lib64/python2.7/site-packages/cryptography/hazmat/backends/openssl/ciphers.py", line 131, in update_into "unsigned char *", self._backend._ffi.from_buffer(buf) TypeError: from_buffer() cannot return the address of the raw string within a str or unicode or bytearray object

DEBUG in wsshd [/usr/lib/python2.7/site-packages/wssh-0.1.0-py2.7.egg/EGG-INFO/scripts/wsshd:27]: 192.168.1.115 -> aaronwtl@localhost: [interactive shell]

ERROR in wsshd [/usr/lib/python2.7/site-packages/wssh-0.1.0-py2.7.egg/EGG-INFO/scripts/wsshd:47]: Error while connecting to localhost: from_buffer() cannot return the address of the raw string within a str or unicode or bytearray object

Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/wssh-0.1.0-py2.7.egg/EGG-INFO/scripts/wsshd", line 44, in connect allow_agent=app.config.get('WSSH_ALLOW_SSH_AGENT', False)) File "/usr/lib/python2.7/site-packages/wssh-0.1.0-py2.7.egg/wssh/server.py", line 98, in open look_for_keys=False) File "/usr/lib/python2.7/site-packages/paramiko/client.py", line 380, in connect look_for_keys, gss_auth, gss_kex, gss_deleg_creds, gss_host) File "/usr/lib/python2.7/site-packages/paramiko/client.py", line 608, in _auth self._transport.auth_password(username, password) File "/usr/lib/python2.7/site-packages/paramiko/transport.py", line 1266, in auth_password self.auth_handler.auth_password(username, password, my_event) File "/usr/lib/python2.7/site-packages/paramiko/auth_handler.py", line 107, in auth_password self._request_auth() File "/usr/lib/python2.7/site-packages/paramiko/auth_handler.py", line 158, in _request_auth self.transport._send_message(m) File "/usr/lib/python2.7/site-packages/paramiko/transport.py", line 1587, in _send_message self.packetizer.send_message(data) File "/usr/lib/python2.7/site-packages/paramiko/packet.py", line 360, in send_message out = self.__block_engine_out.update(packet) File "/usr/lib64/python2.7/site-packages/cryptography/hazmat/primitives/ciphers/base.py", line 149, in update return self._ctx.update(data) File "/usr/lib64/python2.7/site-packages/cryptography/hazmat/backends/openssl/ciphers.py", line 120, in update n = self.update_into(data, buf) File "/usr/lib64/python2.7/site-packages/cryptography/hazmat/backends/openssl/ciphers.py", line 131, in update_into "unsigned char *", self._backend._ffi.from_buffer(buf) TypeError: from_buffer() cannot return the address of the raw string within a str or unicode or bytearray object ^CKeyboardInterrupt Sun Jan 28 10:07:37 2018 [root@localhost wssh]# wsshd wsshd/0.1.0 running on 0.0.0.0:5000

DEBUG in wsshd [/usr/lib/python2.7/site-packages/wssh-0.1.0-py2.7.egg/EGG-INFO/scripts/wsshd:27]: 192.168.1.115 -> aaronwtl@localhost: [interactive shell]

ERROR in wsshd [/usr/lib/python2.7/site-packages/wssh-0.1.0-py2.7.egg/EGG-INFO/scripts/wsshd:47]: Error while connecting to localhost: from_buffer() cannot return the address of the raw string within a str or unicode or bytearray object

Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/wssh-0.1.0-py2.7.egg/EGG-INFO/scripts/wsshd", line 44, in connect allow_agent=app.config.get('WSSH_ALLOW_SSH_AGENT', False)) File "/usr/lib/python2.7/site-packages/wssh-0.1.0-py2.7.egg/wssh/server.py", line 98, in open look_for_keys=False) File "/usr/lib/python2.7/site-packages/paramiko/client.py", line 380, in connect look_for_keys, gss_auth, gss_kex, gss_deleg_creds, gss_host) File "/usr/lib/python2.7/site-packages/paramiko/client.py", line 608, in _auth self._transport.auth_password(username, password) File "/usr/lib/python2.7/site-packages/paramiko/transport.py", line 1266, in auth_password self.auth_handler.auth_password(username, password, my_event) File "/usr/lib/python2.7/site-packages/paramiko/auth_handler.py", line 107, in auth_password self._request_auth() File "/usr/lib/python2.7/site-packages/paramiko/auth_handler.py", line 158, in _request_auth self.transport._send_message(m) File "/usr/lib/python2.7/site-packages/paramiko/transport.py", line 1587, in _send_message self.packetizer.send_message(data) File "/usr/lib/python2.7/site-packages/paramiko/packet.py", line 360, in send_message out = self.__block_engine_out.update(packet) File "/usr/lib64/python2.7/site-packages/cryptography/hazmat/primitives/ciphers/base.py", line 149, in update return self._ctx.update(data) File "/usr/lib64/python2.7/site-packages/cryptography/hazmat/backends/openssl/ciphers.py", line 120, in update n = self.update_into(data, buf) File "/usr/lib64/python2.7/site-packages/cryptography/hazmat/backends/openssl/ciphers.py", line 131, in update_into "unsigned char *", self._backend._ffi.from_buffer(buf) TypeError: from_buffer() cannot return the address of the raw string within a str or unicode or bytearray object

After start wssd on linux terminal，I connect the linux terminal on browser，but when I clikc the connect button on screen，the next screen shows: “ Error: 'type' object is not iterable
Connection Reset By Peer ” And the sshd server log on linux terminal shows: “ ivanli@ubuntu:~$ wsshd wsshd/0.1.0 running on 0.0.0.0:5000

DEBUG in wsshd [/usr/local/lib/python2.7/dist-packages/wssh-0.1.0-py2.7.egg/EGG-INFO/scripts/wsshd:27]: 127.0.0.1 -> ivanli@ubuntu: [interactive shell]

No handlers could be found for logger "paramiko.transport"

ERROR in wsshd [/usr/local/lib/python2.7/dist-packages/wssh-0.1.0-py2.7.egg/EGG-INFO/scripts/wsshd:47]: Error while connecting to ubuntu: 'type' object is not iterable

Traceback (most recent call last): File "/usr/local/lib/python2.7/dist-packages/wssh-0.1.0-py2.7.egg/EGG-INFO/scripts/wsshd", line 44, in connect allow_agent=app.config.get('WSSH_ALLOW_SSH_AGENT', False)) File "/usr/local/lib/python2.7/dist-packages/wssh-0.1.0-py2.7.egg/wssh/server.py", line 98, in open look_for_keys=False) File "/usr/local/lib/python2.7/dist-packages/paramiko/client.py", line 392, in connect t.start_client(timeout=timeout) File "/usr/local/lib/python2.7/dist-packages/paramiko/transport.py", line 545, in start_client raise e TypeError: 'type' object is not iterable ” Please help me solve the problem, 3q~