Hiya there,

Currently I'm writing a python script to interpolate between the PowerDNS API and the Netbox API, while troubleshooting some API call issues, looking at the Netbox API documentation, adding zones via an API call via POST specifies the following

soa_mname 
integer
title: SOA MName

The MNAME should be a string, not an integer, as per the MNAME listed in https://www.cloudflare.com/en-gb/learning/dns/dns-records/dns-soa-record/

There would be no circumstances an SOA MNAME contained within the rrset returned would ever be an integer, so this type should be changed.

Would import export (bind) zone files be an option in the future ?

Also, now it could be cool to have an deploy button which uses netbox source to deploy DNS records to bind servers :-)

Just saying and wishing.

So far thanks for this great work

django.db.utils.ProgrammingError: column netbox_dns_zone.soa_serial_auto does not exist

<class 'django.db.utils.ProgrammingError'>

column netbox_dns_zone.soa_serial_auto does not exist
LINE 1: ...e"."soa_expire", "netbox_dns_zone"."soa_minimum", "netbox_dn...

Python version: 3.8.10
NetBox version: 3.1.1

It seems either the new Netbox version 3.1.0 or one of its prerequisites is incompatible with Netbox DNS.

When trying to run manage.py makemigrations I get a long dump:

(netbox) [root@dns netbox]# /opt/netbox/netbox/manage.py makemigrations 
Traceback (most recent call last):
  File "/opt/netbox/netbox/manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/opt/netbox/lib/python3.8/site-packages/django/core/management/__init__.py", line 419, in execute_from_command_line
    utility.execute()
  File "/opt/netbox/lib/python3.8/site-packages/django/core/management/__init__.py", line 413, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/opt/netbox/lib/python3.8/site-packages/django/core/management/base.py", line 354, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/opt/netbox/lib/python3.8/site-packages/django/core/management/base.py", line 393, in execute
    self.check()
  File "/opt/netbox/lib/python3.8/site-packages/django/core/management/base.py", line 419, in check
    all_issues = checks.run_checks(
  File "/opt/netbox/lib/python3.8/site-packages/django/core/checks/registry.py", line 76, in run_checks
    new_errors = check(app_configs=app_configs, databases=databases)
  File "/opt/netbox/lib/python3.8/site-packages/django/core/checks/urls.py", line 13, in check_url_config
    return check_resolver(resolver)
  File "/opt/netbox/lib/python3.8/site-packages/django/core/checks/urls.py", line 23, in check_resolver
    return check_method()
  File "/opt/netbox/lib/python3.8/site-packages/django/urls/resolvers.py", line 412, in check
    for pattern in self.url_patterns:
  File "/opt/netbox/lib/python3.8/site-packages/django/utils/functional.py", line 48, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/opt/netbox/lib/python3.8/site-packages/django/urls/resolvers.py", line 598, in url_patterns
    patterns = getattr(self.urlconf_module, "urlpatterns", self.urlconf_module)
  File "/opt/netbox/lib/python3.8/site-packages/django/utils/functional.py", line 48, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/opt/netbox/lib/python3.8/site-packages/django/urls/resolvers.py", line 591, in urlconf_module
    return import_module(self.urlconf_name)
  File "/opt/netbox/lib64/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 783, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/opt/netbox/netbox/netbox/urls.py", line 9, in <module>
    from extras.plugins.urls import plugin_admin_patterns, plugin_patterns, plugin_api_patterns
  File "/opt/netbox/netbox/extras/plugins/urls.py", line 28, in <module>
    urlpatterns = import_object(f"{plugin_path}.urls.urlpatterns")
  File "/opt/netbox/netbox/extras/plugins/utils.py", line 31, in import_object
    spec.loader.exec_module(module)
  File "/opt/netbox/lib/python3.8/site-packages/netbox_dns/urls.py", line 5, in <module>
    from .views import (
  File "/opt/netbox/lib/python3.8/site-packages/netbox_dns/views.py", line 3, in <module>
    from netbox_dns.forms import (
  File "/opt/netbox/lib/python3.8/site-packages/netbox_dns/forms.py", line 37, in <module>
    class ZoneForm(BootstrapMixin, CustomFieldModelForm):
  File "/opt/netbox/lib/python3.8/site-packages/django/forms/models.py", line 226, in __new__
    new_class = super().__new__(mcs, name, bases, attrs)
  File "/opt/netbox/lib/python3.8/site-packages/django/forms/forms.py", line 31, in __new__
    new_class = super().__new__(mcs, name, bases, attrs)
  File "/opt/netbox/lib/python3.8/site-packages/django/forms/widgets.py", line 191, in __new__
    new_class = super().__new__(mcs, name, bases, attrs)
TypeError: Cannot create a consistent method resolution
order (MRO) for bases BootstrapMixin, CustomFieldModelForm

fixes #15 fixes #171 fixes #173

This PR adds the long awaited feature of "Views" to NetBox DNS.

A view essentially is only an optional name that can be added to any zone. There are two consequences if a zone is associated with a view:

• As long as the views of two zones differ or one of them has a view associated with it and the other hasn't, the zone name no longer needs to be unique. There can be two zones with the name "zone1.example.com", provided they are scoped differently by the view feature.
• When PTR records are manipulated for A and AAAA records, the reverse zone the PTR record is created, deleted or updated in needs to be in the same view as the zone of the A/AAAA record.

There is some rather involved logic in place that kicks in when zones are moved from one view to the other or when zones are added or removed from views. Generally the code tries to do "the right thing", i.e. doesn't create duplicate zones in the same or without a view and move the PTR records between reverse zones when the zone containing the address records is moved.

Trying to use the "Quick search" box in the Records list, but nothing happens. Actually, I don't see any REST request sent, nor Javascript errors in the browser console (Chrome).

Hi folks! As we approach the first beta release for NetBox v3.2, which introduces a greatly extended plugins API, I took a stab at updating this plugin to use the newly available resources. This PR is submitted as a proof of concept only and should not be treated as an actual proposed change at this time. (I based this PR off of the main branch as it appears that develop is no longer in use. Is that correct?)

While this work has uncovered a few minor tweaks/extensions needed in the new plugins framework, I'm pretty happy with how smooth the implementation went overall. I've included a summary of the changes made thus far below. I would very much appreciate feedback: Did I miss anything? Is there something we could handle better? Do you foresee any issues with this approach? Let me know and we'll get it sorted. Thanks!

Summary

• Add a migration for NetBox v3.2 model changes
  • created is now a DateTimeField on all change-logged models
  • Remove the blank=True attribute from tag managers (cosmetic change)
  • Remove tags and objects attributes (now inherited from NetBoxModel), except where custom
• Models
  • Replace PrimaryModel with NetBoxModel
  • Remove calls to extras_features() (features are not provided by NetBoxModel)
• Views
  • Update path to ObjectChangeLogView
• Form classes
  • Replace the local BulkEditForm with NetBoxModelBulkEditForm
  • Remove the pk fields (inherited from NetBoxModelBulkEditForm)
  • Remove Meta classes and set model on bulk edit forms
• FilterSet classes
  • Replace PrimaryModelFilterSet with NetBoxModelFilterSet
  • Remove the tags filter declarations (inherited from NetBoxModelFilterSet)
• Tables
  • Replace BaseTable with NetBoxTable
  • Remove pk column (inherited from NetBoxTable)
  • Replace calls to old configure_table() utility with table.configure()
• Templates
  • Replace local object.html with generic/object.html
  • Replace local object_list.html with generic/object_list.html
  • Replace record_list.html and managed_record_list.html with generic/object_list.html
    • Removed the add & import buttons by setting action_buttons on the views
    • We don't yet have a way to toggle the display of the bulk edit/delete buttons beneath the table
  • Replace paginate_table() with configure_table() (not yet officially supported)
• Miscellaneous
  • Removed obsolete template tags (replicated from NetBox)

I am facing an error while calling netbox-dns API (leveraging the Ansible uri module) in order to create a new zone.

Actually, Ansible sends a POST request to /api/plugins/netbox-dns/zones/ with the following body:

{
	"default_ttl": 3600,
	"name": "REDACTED.net",
	"soa_expire": 86400,
	"soa_minimum": 3600,
	"soa_mname": 3,
	"soa_refresh": 900,
	"soa_retry": 600,
	"soa_rname": "[email protected]",
	"soa_serial_auto": false,
	"soa_ttl": 3600,
	"tags": [{"slug": "auto-sync"},{"slug": "private"}],
	"view": "1"
}

I get a 500 Internal error response code, with the following body:

{
    "error": "{'value': ['Record value (REDACTED.local. [email protected]. None 900 600 86400 3600) is malformed: expecting an integer.']}",
    "exception": "ValidationError",
    "netbox_version": "3.2.4",
    "python_version": "3.9.5"
}

Similar API calls previously worked ok on former versions of Netbox and netbox-dns (I don't remember exactly which versions, but it was more than 90 days ago): the only difference is now I am using the "view", but I also tested without that parameter, and I get the same error.

Problem was: When I search /api/plugins/netbox-dns/records/?zone_id=1&type=PTR&name=11 I don't want to match the reverse record for 111. The same applies forward: When I search /api/plugins/netbox-dns/records/?zone_id=1&type=A&name=foo I don't want to match the A record for foobar.domain.tld. By removing the icontains filter, the default Netbox filters are applied, which means an exact match by default. When you want back the old behaviour (after this change is merged) you can query like this: /api/plugins/netbox-dns/records/?zone_id=1&type=A&name__ic=foo

We use external and internal views in BIND for the same zones, as many other people do.

For example, when we are inside the LAN, a host record like 'host1.example.com` points to a some local IP like 192.168.1.1. The same record 'host1.example.com' when it get queried from external network, points to some real external IP like 195.XXX.XXX.XXX

https://www.cyberciti.biz/faq/linux-unix-bind9-named-configure-views/

Please allow the same zones but with different "view" types or something like that.

Hi,

Can we have quick search in the zone records and managed records tabs?

There is quick search in the records page, but then I need to filter by zone first. Going via the zone page is more logical way for me.

fixes #268

This PR provides validation of Zone and Record names (and Name Server names as well, as they are connected with RRs for the name servers).

In addition to running all names through dnspython in order to determine if they are legal DNS names, they are also checked for Unicode interpretations. If the Unicode interpretation derives from the textual representation, the name is converted to the latter in order to make it usable for DNS servers. Editing can be done both in Unicode format and in text (punycode) format, and if there is a Unicode representation the detail views for NameServer, Zone and Record objects will show it.

This will certainly need more work, but it's a start.

Discussed in https://github.com/auroraresearchlab/netbox-dns/discussions/267

Source versions:

• netbox 3.3.10
• netbox_dns 0.15.0

when doing a combined upgrade of netbox to 3.4.1 and netbox_dns to 0.16.0 migrations will fail, as netbox core is trying to index fields in their migration, which will be added later by netbox_dns migration. LEading to a failed migration.

Apply all migrations: admin, auth, circuits, contenttypes, dcim, django_rq, extras, ipam, netbox_dns, nk_netbox_requests, sessions, social_django, taggit, tenancy, users, virtualization, wireless
Running migrations:
  Applying extras.0083_search...Reindexing 67 models.
Clearing cached values... 0 entries deleted.
Indexing models
  netbox_dns.nameserver... 4 entries cached.
  netbox_dns.zone... 170 entries cached.
  netbox_dns.record... Traceback (most recent call last):
  File "/opt/netbox-test/venv/lib64/python3.9/site-packages/django/db/backends/utils.py", line 89, in _execute
    return self.cursor.execute(sql, params)
psycopg2.errors.UndefinedColumn: column netbox_dns_record.ip_address does not exist
LINE 1: ..."disable_ptr", "netbox_dns_record"."description", "netbox_dn...
                                                             ^


The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/opt/netbox-test/netbox/./manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/opt/netbox-test/venv/lib64/python3.9/site-packages/django/core/management/__init__.py", line 446, in execute_from_command_line
    utility.execute()
  File "/opt/netbox-test/venv/lib64/python3.9/site-packages/django/core/management/__init__.py", line 440, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/opt/netbox-test/venv/lib64/python3.9/site-packages/django/core/management/base.py", line 402, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/opt/netbox-test/venv/lib64/python3.9/site-packages/django/core/management/base.py", line 448, in execute
    output = self.handle(*args, **options)
  File "/opt/netbox-test/venv/lib64/python3.9/site-packages/django/core/management/base.py", line 96, in wrapped
    res = handle_func(*args, **kwargs)
  File "/opt/netbox-test/venv/lib64/python3.9/site-packages/django/core/management/commands/migrate.py", line 349, in handle
    post_migrate_state = executor.migrate(
  File "/opt/netbox-test/venv/lib64/python3.9/site-packages/django/db/migrations/executor.py", line 135, in migrate
    state = self._migrate_all_forwards(
  File "/opt/netbox-test/venv/lib64/python3.9/site-packages/django/db/migrations/executor.py", line 167, in _migrate_all_forwards
    state = self.apply_migration(
  File "/opt/netbox-test/venv/lib64/python3.9/site-packages/django/db/migrations/executor.py", line 252, in apply_migration
    state = migration.apply(state, schema_editor)
  File "/opt/netbox-test/venv/lib64/python3.9/site-packages/django/db/migrations/migration.py", line 130, in apply
    operation.database_forwards(
  File "/opt/netbox-test/venv/lib64/python3.9/site-packages/django/db/migrations/operations/special.py", line 193, in database_forwards
    self.code(from_state.apps, schema_editor)
  File "/opt/netbox-test/netbox/extras/migrations/0083_search.py", line 13, in reindex
    management.call_command('reindex')
  File "/opt/netbox-test/venv/lib64/python3.9/site-packages/django/core/management/__init__.py", line 198, in call_command
    return command.execute(*args, **defaults)
  File "/opt/netbox-test/venv/lib64/python3.9/site-packages/django/core/management/base.py", line 448, in execute
    output = self.handle(*args, **options)
  File "/opt/netbox-test/netbox/extras/management/commands/reindex.py", line 68, in handle
    i = search_backend.cache(model.objects.iterator(), remove_existing=False)
  File "/opt/netbox-test/netbox/netbox/search/backends.py", line 148, in cache
    for instance in instances:
  File "/opt/netbox-test/venv/lib64/python3.9/site-packages/django/db/models/query.py", line 512, in _iterator
    yield from iterable
  File "/opt/netbox-test/venv/lib64/python3.9/site-packages/django/db/models/query.py", line 87, in __iter__
    results = compiler.execute_sql(
  File "/opt/netbox-test/venv/lib64/python3.9/site-packages/django/db/models/sql/compiler.py", line 1398, in execute_sql
    cursor.execute(sql, params)
  File "/opt/netbox-test/venv/lib64/python3.9/site-packages/django/db/backends/utils.py", line 67, in execute
    return self._execute_with_wrappers(
  File "/opt/netbox-test/venv/lib64/python3.9/site-packages/django/db/backends/utils.py", line 80, in _execute_with_wrappers
    return executor(sql, params, many, context)
  File "/opt/netbox-test/venv/lib64/python3.9/site-packages/django/db/backends/utils.py", line 89, in _execute
    return self.cursor.execute(sql, params)
  File "/opt/netbox-test/venv/lib64/python3.9/site-packages/django/db/utils.py", line 91, in __exit__
    raise dj_exc_value.with_traceback(traceback) from exc_value
  File "/opt/netbox-test/venv/lib64/python3.9/site-packages/django/db/backends/utils.py", line 89, in _execute
    return self.cursor.execute(sql, params)
django.db.utils.ProgrammingError: column netbox_dns_record.ip_address does not exist
LINE 1: ..."disable_ptr", "netbox_dns_record"."description", "netbox_dn...
                                                             ^

Are there plans for adding the ability to store more information with certain records like, MX and SVR? These types need additional information in their records to be useful. Things like TXT records on the other hand, don't necessarily need a name value for the record and should be optional.