Considering the Python maintainers say that Python 3 is the "current and future version," and Python 2 is "legacy," it seems to make sense to port disqus-python to Python 3. As stands, it's unusable in a Python 3 environment, and a tool like auto2to3 fails with an ImportError (no module named 'disqus_static').

For starters, in Python 3, httplib was changed to http.client (see also: http://stackoverflow.com/questions/13778252/import-httplib-importerror-no-module-named-httplib).

Hi I've refactored most of the incompatibility issues, and package runs on Python 2.6, 2.7, 3.3, and 3.4. Here are some changes i've made.

Changelog

• Added Travis-CI Integration
• General Bug/Compatibility Fixes
  • +# -*- coding: utf-8 -*- and from __future__ import idioms
• Supports wheel binary specification
• Removed depreciated modules e.g. pkg_resources
• Cleanup of __init__.py
• Added requirements.txt & test_requirements.txt
• Added Makefile for automation
• Created __version__.py as single authoritative reference of version #

Some additional refactoring that would be useful

TODO:

• Documentation, maybe just pulling the docstrings with Sphinx Autofunc
• Moving rest of code out of __init__.py
• Complete refactor of setup.py
• Authentication without secret key, or some cryptography.
• A CONTRIBUTE.in file
• Remove simplejson dependency

I tried to install & run the first lines of code. Got the ImportError: No module named 'httplib' for lines in __init__.py of disqusapi. When searched online, found that there is no httplib anymore. There is a newer package called httplib2 and httplib has been renamed to http.client in Python 3 Source@StackOverFlow. Should the code be updated to reflect the changes?

A couple of hours ago, my calls to the Disqus API started to fail due to Invalid API key. Interestingly, I couldn't reproduce this with cURL or the requests library. So I had a closer look at the requests and noticed that the client does not specify the Content-Type header. Setting it to application/x-www-form-urlencoded resolves the issue. I guess something in the backend has changed lately (e.g., the default content type).

I'm not sure whether or not this project is still maintained. The fix is trivial but if a pull request is preferred, I will gladly submit one.

Using pip install disqus-python I got version 0.4.2 installed.

The following code raises error (in fact it is just like in your example):

from disqusapi import DisqusAPI
public_key = 'XXXXXXXXXXXXXXXXXXXX'
secret_key = 'XXXXXXXXXXXXXXXXXXXX'
disqus = DisqusAPI(secret_key, public_key)
disqus.get('threads.listPopular', forum='myforum')

If I pass values as in the following code I get error JSONDecodeError: Expecting value: line 1 column 1 (char 0):

kwargs = {
    'method': 'threads.listPopular',
    'forum': 'myforum',
}
disqus.get(**kwargs)

I installed disqus-python and followed https://github.com/disqus/disqus-python to do the following but it throws an exception:

from disqusapi import DisqusAPI disqus = DisqusAPI(secret_key, public_key) for result in disqus.get('trends.listThreads'): print result

disqus.get('trends.listThreads') Traceback (most recent call last): File "", line 1, in TypeError: call() takes exactly 1 argument (2 given)

• Refactor needed in order to have tests
• 100% Coverage with unit tests
• Syntax highlight in README.rst
• Update CHANGES
• Added tox and nose configuration
• Ignore .coverage, .tox and *.swp

Can this be a good base for version 0.5?

Why do you use setters like setVersion when as far as I know in python attributes are already setters and getters? Object attributes can be changed just like disqus.version = '3.0'. I haven't look too carefully to the whole code but just wonder why.

Another idea: if usage of separate setters makes sense it would be better to use underscores like set_version.

If you want such attributes like version to be just properties outside you can use @property. I can make pull request if you agree with this idea.

P.S. When 0.5.0 from CHANGES will be on PyPI?

Thank you for Disqus API library and for developing Disqus. It is awesome!

Fixed recursion error when

disqus.interface.update(dict)

is used. Now throws InterfaceNotDefined expection.

disqus.update_interface(dict)

must be used now.

Updated pull request for minimum compatibility with Python 3.

All unit tests passing for Python versions 2.6, 2.7, 3.3 and 3.4 confirmed on TravisCI. I can remove the .travis.yml file if CI testing isn't necessary.

I also have a Pelican blog using the API, and tested that it runs correctly.

Changelog

• Uses six module for main compatibility layer with Python 2 and Python 3. Added it to the requirement specification.
• All iterators and moved standard library modules changed to use six module versions.
• Added requirements.txt and test_requirements.txt files.

I had tested the code sample in README, and it returns Invalid API key Error.

What does it mean? Did I inject incorrect secret key or disqus.trends.listThread() is not recognizable?

So I'm trying to navigate around the functionality of this library and find the things I need but nothing seems to work at first try unfortunately.

I got the first example from README.rst to work in Python 3 with a few modifications but the third piece of code (with brackets for the print for python 3) is throwing the error in the title

from disqusapi import Paginator
paginator = Paginator(api.get, 'trends.listThreads', forum='disqus')
for result in paginator:
    print (result)

So I tried to change api.get to disqus as defined above disqus = DisqusAPI(secret_key, public_key) but now it is throwing a different error InterfaceNotDefined: Interface is not defined, you must pass ``method`` (HTTP Method). I tried the solution that worked for the other code snippet: paginator = Paginator(disqus, 'trends.listThreads', forum='disqus', method='GET') ..now it's running without error but not returning anything.

Does anyone know how this code is meant to work?

After I started ipython3, and typed in the shell import disqusapi, it showed ImportError: No module named 'httplib'. Seems look like the disqusapi isn't supporting python3?

I'm using Python 3.5.2 :: Anaconda custom (x86_64)

Here's the error log:

In [1]: import disqusapi
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-2-1dede7c1a4ae> in <module>()
----> 1 import disqusapi

/Users/kspun/anaconda3/lib/python3.5/site-packages/disqusapi/__init__.py in <module>()
     13     __version__ = 'unknown'
     14 
---> 15 import httplib
     16 import os.path
     17 import simplejson

ImportError: No module named 'httplib'

This example code

paginator = Paginator(api.get, 'trends.listThreads', forum='disqus')
for result in paginator:
    print result

throws the error mentioned in the title.

Probably a little bit of update in the README file would help, I am sure it is outdated, as I have seen in another issue thread.

uses httplib ..

https://github.com/disqus/disqus-python/blob/master/CHANGES

Edit:

Oh, "support for python 3"

Can you guys updates pypi then please, its still running older (non python3) version.

https://pypi.python.org/pypi/disqus-python/0.4.2