Describe the bug

The .gitignore file is not working properly i.e can't exclude the db.sqlite3 file

To Reproduce

Steps to reproduce the behavior:

1. Pull Recent changes from the repo
2. You will see that the SQLite database is not excluded

What was expected ?

The SQLite database is supposed to be ignored

Screenshots

Model for Skill and Topic Tags needed. At this point I feel both tags can be added in the "Users" app.

We also need to render these tags in the user serializer. At this point we just have hard coded values.

Describe your changes :

I worked on Issue #89 because it is necessary to maintain style consistency in the project as it grows.

Type of change :

• [ ] Bug fix
• [x] New feature
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• [x] I have read the Code Of Conduct document.
• [x] I have read the CONTRIBUTING document.
• [x] I have performed a self-review of my own.
• [x] I have tagged my reviewers below.
• [x] I have commented my code, particularly in hard-to-understand areas.
• [x] My changes generate no new warnings.
• [x] All new and existing tests passed.

Reviewers

Backend: @PraveenMalethia , @abhivemp,

I worked on the User app

Context of the change :

Added Django Debug Toolbar

Added endpoint to update profile pic

Improved Queries Performance in User App

Before

After

Modified Profile model to save new uploaded profile photo to dynamic location : /Mumble Profile Pictures/username/date/filename

Modified UserProfileUpdate view to also update email

…sages

Describe your changes :

I worked on the Response of Register view because there are no attribute messages for the Response method so I have changed the messages=messages to {"messages":messages}.

Type of change :

• [x] Bug fix

Preview (Screenshots) :

If it is possible, please link screenshots of your changes preview !

Checklist:

• [x] I have read the Code Of Conduct document.
• [x] I have read the CONTRIBUTING document.
• [x] I have performed a self-review of my own.
• [x] I have tagged my reviewers below.
• [ ] I have commented my code, particularly in hard-to-understand areas.
• [x] My changes generate no new warnings.
• [ ] I have added tests that prove my fix is effective or that my feature works.
• [x] All new and existing tests passed.

Reviewers

Backend: @abhivemp, @divanov11

Is your feature request related to a problem? Please describe.

Articles are created using CK-Editor which can allow people to upload malicious HTML. We need to sanitize that HTML before the UI can try to display it.

Describe the solution you'd like

We want to install Bleach https://github.com/mozilla/bleach so that we can sanitize the HTML uploaded when users created and edit articles.

Describe alternatives you've considered

Bleach is supposed to be a good library.

Additional context

Add any other context such as screenshots, schematics, about the feature request here.

Is your feature request related to a problem? Please describe.

Currently, any email address can be taken up for registration, we need to avoid that

Describe the solution you'd like

While user enters his/her email address, we can send an ajax request to a check VIEW to verify whether the entered email address is from a valid email service provider like gmail, hotmail, etc, depending on which it will or will not allow new user to register

Alternate solution

Without AJAX it can be done too

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Variables and functions that are currently using camelCase should be changed to snake_case. This would improve the code quality.

The following files should be refactored:

article

• [ ] article/views.py

discussion

• [ ] discussion/views.py

feed

• [ ] feed/serializers.py (this might require a frontend update)
• [ ] feed/signals.py
• [ ] feed/utils.py
• [ ] feed/views.py

notification

• [ ] notification/signals.py
• [ ] notification/views.py

users

• [ ] users/signals.py
• [ ] users/views.py

This could be changed in one PR or do it by apps.

Preflight Checklist

[I have searched the issue tracker for this issue and couldnt find any, hence created a new one]

Describe the bug

When an article is searched for, it displays article if present, but redirecting to that searched article isn't working when clicked

To Reproduce

Steps to reproduce the behavior:

1. Go to 'Homepage'
2. Click on Enter after search query is typed
3. Scroll down to 'the required query result if present in db'
4. See error (Here unable to go to that searched article)

What was expected ?

To be redirected to the searched article when clicked on it

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here (include commit numbers and branches if relevant)

Describe the bug:

Redirect the URL to HTTPS

Screenshots:

Solution:

Add the following to the settings.py file, adding the middleware to your existing MIDDLEWARE list if one exists.

MIDDLEWARE = [
    # SecurityMiddleware must be listed before other middleware
    'django.middleware.security.SecurityMiddleware',
    # ...
]

if not DEBUG:      # When we are in production ( DEBUG = False ), the URL will redirect to HTTPS
    SECURE_PROXY_SSL_HEADER = ('HTTP_X_FORWARDED_PROTO', 'https')
    SECURE_SSL_REDIRECT = True    

Source:

• https://django-secure.readthedocs.io/en/latest/settings.html#secure-ssl-redirect
• https://help.heroku.com/J2R1S4T8/can-heroku-force-an-application-to-use-ssl-tls

Email Backend is set to Console Backend need to be changed so that forget password can work perfectly. When I tried forget password the email is not being sent. Please work on it Sir. Since I have not gone through the complete structure of the project I am leaving this issue to someone else to resolve Thank You

Describe your changes :

Type of change :

• [x] Bug fix

Preview (Screenshots) :

change data { 'username': 'TEST' }

to data{ 'email' : '[email protected]' }

Describe the bug

There is a problem with profile update test in the profile update view we just let user to update their email but in the test function we are updating the username when we run the test for update profile it not gonna pass the test

Screenshots

Describe your changes :

I worked on the ..... because ... of the issue #181 Refactoring models to follow DRY principle this will enhance the readability of our Model code.

Type of change :

• [ ] Bug fix
• [ ] New feature
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Preview (Screenshots) :

If it is possible, please link screenshots of your changes preview !

Checklist:

• [ x] I have read the Code Of Conduct document.
• [ x] I have read the CONTRIBUTING document.
• [ x] I have performed a self-review of my own.
• [ ] I have tagged my reviewers below.
• [ ] I have commented my code, particularly in hard-to-understand areas.
• [ x] My changes generate no new warnings.
• [ ] I have added tests that prove my fix is effective or that my feature works.
• [ x] All new and existing tests passed.

Reviewers

@PraveenMalethia @abhivemp

Is your feature request related to a problem? Please describe.

No, i just saw different model class having the same attribute

created = models.DateTimeFied(...)

Describe the solution you'd like

Can't we move the similar attribute in this case

created = models.DateTimeField(...)

to a separate class and make other class that needs created to inherit from the class?

Describe alternatives you've considered

class DateTimeModel(models.Model):
    created = models.DateTimeField(...)
    
    class Meta:
        abstract = True

class AnotherModel(DateTimeModel):
    ...

HI, I am getting this below error while loading the test JSON data using the command python manage.py loaddata articledata.json

ERROR:- raise dj_exc_value.with_traceback(traceback) from exc_value File "D:\Programming\Django\mumbleapi\env\lib\site-packages\django\db\backends\base\base.py", line 242, in _commit return self.connection.commit() django.db.utils.IntegrityError: FOREIGN KEY constraint failed

Please look into the issue. Also explain the problem due to which it occurs.