As mentioned by @pcottle , I have made the necessary additions to makeDist.py and created all necessary files in debian directory which would facilitate the creation of the debian package. Please review.

I have already accepted Facebook's Contributor License Agreement (CLA).

It would be good to have Linux packages available, at least .deb and .rpm versions. I don't know anyone that uses Linuxbrew, it doesn't seem ideal on Linux when better solutions exist.

The HHVM team distribute Linux packages, you could probably see how they do it.

Darwin wkoszek-macbook.local 14.5.0 Darwin Kernel Version 14.5.0: Wed Jul 29 02:26:53 PDT 2015; root:xnu-2782.40.9~1/RELEASE_X86_64 x86_64

My login shell is CSH. To rule out CSH, I've run Bash in iTerm2 window and tested too. Same problem. I tested in Vagrant with ubuntu/trusty64. Stuff works OK there, so what I describe below seems to be MacOSX specific.

I did:

brew update brew install fpp.

cd /tmp mkdir sample cd sample cal 2010 > 2010 cal 2011 > 2011 cal 2012 > 2012

/bin/ls -1 ./* | fpp

I select 2010, press f, select 2011, press f, press c, type 'cat', . Nothing happens. I'm dropped to fpp subshell. I'd expect to see output from cat'ed files.

---------------- cat ~/.fpp/.fpp.sh ---------------------- if type shopt > /dev/null; then shopt -s expand_aliases fi

echo "executing command:" echo "cat './2010' './2011'"

cat './2010' './2011'

So selection part works OK. Execution is doing something wrong.

I started to add some debugging code: https://github.com/wkoszek/PathPicker/

~~This is a shitty first pass at colors that I hacked together because I couldn't sleep.~~ Now better!

Turns out ncurses doesn't really support (AFAIK, someone please correct me...) setting foreground/background color combinations directly, so I cache and create color_pair as I go along. Most terms have at least 32 and mine on OSX seems to have 256.

I'm also totally not a python developer, so the code here is probably quite not idomatic.

Screencap because I don't know how to do that cool video thing: the command was git diff --color | fpp

Things to improve on

• Make the chrome use colors instead of hardcoding color_pair(0).

Would this be possible? Something like:

git status | fpp -c 'git add'

So that the default action is overridden and I can just hit 'enter' after selecting files to run git add on them.

For use cases where PP is used frequently with the same command, it's quite annoying to have to always type the same command (eg. rspec for Ruby testing).

This PR allows the user to associate custom commands that can be executed through specified keys (eg. r for rspec), speeding up the PP workflow for repetitive command executions.

Custom bindings/commands are stored in the <FPP_DIR>/.fpp.keys (in the [bindings] group) as standard text configuration file. The existing clean FPP internal interface allows such configuration functionality to be trivially extended, for example, in case FPP will implement a static configuration.

This implementation is the simplest possible; notably, it doesn't support keys already bound (which would significantly complicate the feature).

Due to the test framework, it's not easy to write an end-to-end test - in fact, the existing functionality for executing command hasn't this type of tests; therefore, the test have been updated to inspect the visualization of the custom keys/commands.

PathPicker creates multiple files in the user home directory:

$ ls .fb*
.fbPager.log  .fbPager.pickle  .fbPager.selection.pickle  .fbPager.sh

Normally such files are stored under $HOME/.local/share or $HOME/.config directory on Linux. Please see XDG Base Directory Specification for details.

I just installed fpp using brew install fpp. When I try to run it, this is the output:

Traceback (most recent call last):
  File "/usr/local/Cellar/fpp/0.8.2/libexec/src/processInput.py", line 12, in <module>
    import format
  File "/usr/local/Cellar/fpp/0.8.2/libexec/src/format.py", line 13, in <module>
    from formattedText import FormattedText
  File "/usr/local/Cellar/fpp/0.8.2/libexec/src/formattedText.py", line 9, in <module>
    from colorPrinter import ColorPrinter
  File "/usr/local/Cellar/fpp/0.8.2/libexec/src/colorPrinter.py", line 7, in <module>
    import output
  File "/usr/local/Cellar/fpp/0.8.2/libexec/src/output.py", line 8, in <module>
    from builtins import str
ImportError: No module named builtins

Am I missing anything?

is there a better way to add a change to a PR that was already merged and closed?

anyways, here's a passing test case, let me know if that's not what you were looking for 😄

It would be helpful if the executed command would be [optionally] added to the shell history.

If one needs to repeat the command executed by PP, the workflow is very slow compared to just typing Up arrow and Enter, especially when a custom command is used.

git status | fpp, selecting files, and applying them to git add works fine when I'm at the top level of a Git repo, but not if I enter a subdirectory. It appears to append the selected file to the git repo path, not pwd.

Right now I achieve this using something like

ls | fpp -c "vim -p"

Could you give a environment variable other than FPP_DISABLE_SPLIT that uses vim -p instead of vim -O? Thank you so much!

FYI, it looks like a version bump was forgotten for the 0.9.5 release, e.g.

$ fpp --version
fpp version 0.9.2

This is because:

https://github.com/facebook/PathPicker/blob/3670d02dbcb9ff232b1c8cbeb5468657dd582cf5/src/version.py#L6

Entries which end close to window border PathPicker cause infinite loop after trying to select them with either f or F.

Following for loop is affected: https://github.com/facebook/PathPicker/blob/cc032b2b2fa2fa8ab2fedc93766b2bf2303781d2/src/pathpicker/screen_control.py#L668-L673

Seemingly due to reaching this code path: https://github.com/facebook/PathPicker/blob/cc032b2b2fa2fa8ab2fedc93766b2bf2303781d2/src/pathpicker/line_format.py#L300-L306

Which apparently keeps adding dirty indexes forever: https://github.com/facebook/PathPicker/blob/cc032b2b2fa2fa8ab2fedc93766b2bf2303781d2/src/pathpicker/line_format.py#L237-L238

Please support bundling PathPicker into a single bundled executable file, so that distribution of the command/program does not need to include raw source directories.

In git diffs, there are sometimes lines that look like this:

index f80b65d..c8f438a 100644
--- a/tests/test_signature_parsing.py
+++ b/tests/test_signature_parsing.py
@@ -317,7 +317,7 @@ def expects_int(x: int) -> int:

fpp picks up on the path a/tests/test_signature_parsing.py, but that path has a prefix a/ that is not desired (i.e. tests/test_signature_parsing.py would be prefered).

I wonder: what is the best way for me (as a user) to handle this use-case? I.e. I would like to perform some processing of the selected path(s), e.g. using sed, before passing the paths to a command or opening with an editor.