I'm experiencing an issue where some rows are rendered multiple times in place of other rows. The table in question used to render perfectly well on an earlier versions of django and django-tables2. I upgraded both of them at the same time to the latest version of each (django 1.10, django-tables2 1.2.4) then this issue started happening.

See this image here for a demonstration: http://imgur.com/a/pPRT8

When I load a table without choosing a sort order by the column, I don't see this issue. Once I click on a column header to change the sort order then rows are duplicated.

So far I've identified that the data passed into the BoundRows object is correct, with no duplicated items. However iterating through the bound rows returns duplicated entries. So it looks like something may be changing the data object while the iteration is taking place.

This issue is happening on tables of length ~150, and I haven't (yet) been able to reproduce this issue with a smaller test dataset.

This snippet shows the test code I have used to narrow down the cause of the issue.

--- a/django_tables2/rows.py
+++ b/django_tables2/rows.py
@@ -8,6 +8,7 @@ from django.utils import six
 from .columns.linkcolumn import BaseLinkColumn
 from .utils import A, AttributeDict, call_with_appropriate, computed_values

+import sys

 class BoundRow(object):
     """
@@ -187,9 +188,17 @@ class BoundRows(object):
     def __init__(self, data, table):
         self.data = data
         self.table = table
+        for d in data:
+            print >>sys.stderr, d
+
+        print >>sys.stderr, "end data"
+

     def __iter__(self):
         for record in self.data:
+            print >>sys.stderr, "__iter__", record
             yield BoundRow(record, table=self.table)

I tracked down the cause to utils.Accessor https://github.com/bradleyayers/django-tables2/blob/master/django_tables2/utils.py#L376-L380

            if callable(current):
                ...
                current = current()

The problem is, that managers are callable in Django 1.7 and will raise an error when called without arguments. https://github.com/django/django/blob/master/django/db/models/fields/related.py#L654 https://docs.djangoproject.com/en/dev/releases/1.7/#s-using-a-custom-manager-when-traversing-reverse-relations

I kinda fixed it for me with:

                if not isinstance(current, BaseManager):
                    current = current()

But I don't know if this is a good solution, since I don't have a very good understanding of the inner workings of tables2 nor django:)

If I have a table

class MyTable(tables.Table):
    class Meta:
        model=MyModel
        fields=('field1',  'field2')
        sequence=('field1', '...')

a column:

class Field3Column(tables.Column):
    def __init__(*args, **kwargs):
       someinit
   def render(self,record, table, value, bound_column, **kwargs):
       return somerender()

and a view: table = MyTable(extra_columns=('myfield3',Field3Column))

the table from the view will not contain Field3Column. However, by omitting the sequence on the Meta it does show the Field3.

I found this plugin within days of learning Django and ran into the following problem:

I did the official Django tutorial the other day and then later installed this plugin via easy_setup. I am not sure if the tutorial's having users edit the template path is what caused this, but when I got to the point where the DT2 guide has you enter "{{ table.as_html }}" in your HTML file, the page returned a "template not found" error until I copied the relevant dirs/files from the DT2 egg into my project's template path.

I was only able to figure this out b/c Django's official docs list that templates whose path aren't specified are searched for in the Django contrib folder which in my case was extracted from the egg to a folder with the same name:

"...\Python27\Lib\site-packages\django-1.3.1-py2.7.egg"

I can see why this happens now, but perhaps a note should be made of this in the docs, as new users may not understand the method behind finding files.

Hi,

I have the following tables:-

    class BaseTable(tables.Table):
        select_column = tables.CheckBoxColumn(verbose_name='', empty_values=('NA',))

        class Meta:
            attrs = {'class' : 'cool_table'}

    class EditableTable(BaseTable):
        edit_column = EditIconColumn(verbose_name=_('Edit'))

        def set_editable(self, flag):
            if flag:
                self.base_columns['edit_column'].visible = True
            else:
                self.base_columns['edit_column'].visible = False   

    class RoomTable(EditableTable):
        number = tables.Column()
        speciality = tables.Column()
        photo = ImageViewColumn(accessor='room_type.photo')

When I render RoomTable the generated <table> does not have the class attribute. I am able to get that attribute only when I move (or copy) the Meta class from BaseTable to RoomTable.

Is this a bug or I am using it incorrectly?

hello, I'm using jquery-ui to sort tables, to make this work with django_tables2 i need to add an id attribute to the "tbody" tag. I noticed the "tbody" tag is not parameterizable, is it possible to build this feature in?

I'm looking forward to your answer

Kind regards, Roel

Hi Bradley,

This is just a small patch to make sure that BoundColumn objects only get instantiated once. This may help performance when iterating over a large number of rows.

Bug #237 was marked as fixed, but there isn't actually any sign of a fix (maybe you forgot to do a git push?). I can't seem to reopen that bug report, so I am reopening a new bug report so that this issue doesn't go unforgotten.

I'm in the process of moving over to class-based views, in particular the part of our app that used django-tables. Django-tables2 seems a whole lot better, so I picked up v(0.2.0). I'm running django 1.4.0rc1. Once I applied koledennix's handy pull request it looked like the example you give in the docs for class-based view was working, but for the lack of data in the table. The example says this should happen automatically.

Noticing a comment from a previous pull request:

The difference between SingleTableView and ListView is that the table view adds a table to the list view. It doesn't force you to populate the table with the same data that the list displays.

I tried using SingleTableView instead of a SingleTableMixin with Listview in case was understanding the above comment incorrectly. When I checked my context, object_list was full of data, and table_data empty, just as before. Perhaps this is my unfamiliarity with class-based views, but since object_list is only accessible from the template after .as_view creates it, there's no way to pass it in to the MyTableView.as_view() function through table_data = object_list.

Even if django-tables2 doesn't "force you to populate the table with the same data the list displays", shouldn't you be able to ask it to populate?

It's also possible this feature isn't missing, but I'm implementing it wrong. Perhaps the example is incorrect? Or is there another bug in 0.2.0 and django1.4 with class-based views I'm not finding? Either way, there's not much in the community about this kind of error, and your class-based documentation is pretty sparse. In which case, I'd re-title this issue to 'Provide Class-Based Documentation', something I'd be happy to contribute to if I could get it working myself.

I think this comes from this change https://github.com/jieter/django-tables2/issues/547 with the new version 1.21, my forms inside the table template does retreive the csrf token from {% csrf_token %}

UserWarning: A {% csrf_token %} was used in a template, but the context did not provide the value. This is usually caused by not using RequestContext.

{% block table %}
...
<form>
      {% csrf_token %}
</form>
...
{% endblock table%}

This will be used to get a rawer version of the rendered value which doesn't have any html.

I realise this will need some tests before being merged but I thought I'd create the PR to get any feedback on the addition before spending more time on it.

The need for this arose when I was trying to create a way to get the table data to create an excel download. I had a LinkColumn which had some ' in the content. If using django.utils.html.strip_tags on the get_cell value I was getting the single quotes html escaped to ', now adding this and subclassing the below I can get the raw table data with data formatted/rendered as it was displayed but without any html. Perfect for adding to a csv download!

class TableWithRawData(tables.Table):
    def raw_data(self):
        heading = [unicode(c.header) for c in self.columns]
        rows = [[r.get_cell_value(column.name) for column in r.table.columns] for r in self.rows]
        return heading, rows

This adds a get_tables_classes() method to MultiTableMixin that is called from get_tables() in place of always referring to the tables attribute - this makes it easier to define multiple dynamics custom table table classes in the view - like one can for SingleTableMixin.

Also added a test to test the new method.

fixes: #875

I recently switched a view from a single table view to a multi-table view - but I need to generate my table classes dynamically per view. With SingleTableMixin this is easy as one just overrides the get_table_class method, but there isn't an equivalent in MultiTableMixin and I wondered if there was a good reason for this?

I've hacked out a possible way and will put a pull request in if it's of any interest....

Hi guys, I don't know if it's a problem, but I noticed an overload of template renders for each row. The title is always None as you can see and the row counter goes from 0 to 24 (page size is 25) and the same context is repeated each 4 rows (25 * 4 + 3 = 103). Any clues what's going on?

Add pagination classes to nav section When using bootstrap-responsive.html (extends bootstrap.html) the pagination nav section is missing the correct bootstrap classes.

Hello!

I'm trying to order a table by a bookmarked boolean. However, the bookmark data is user-dependent. I can easily show the bookmark in render_bookmark method and use self.request.user in it. However, for the ordering, the request is not yet available.

The configure method of RequestConfig set the table.request = self.request after the table.order_by = order. Is there a reason for that? Could we safely put the table.request = self.request at the beginning of the method? I think we can but before trying a PR, I would like to check with you.

Thank you for tables2!

Ref:

• PR related to request in table : #705
• code: https://github.com/jieter/django-tables2/blob/1d0dfa7d9ad209332fb1f6936d213c4363455075/django_tables2/config.py#L33-L69

When sorting the table by clicking on a header, if there are rows that have the same value, the order can not be consistent from one query to another. Is there a way to specify a "secondary" sorting criteria?

For example, when user clicks on the price header to sort rows by price, behind the scene I'd like to have ordering = (price, pk) sothat the result is guarantee to be the same, given the same queryset.

For now, I succeeded with :

price = tables.Column(order_by=["price", "id"])

However, doing this for every column is tedious, there must be a better way.

Thanks.