I have a set of classes like this:

class DistributeHandler(SocketConnection): @event def join(self, _args, *_kargs): # Join a channel based on kargs print "Joining %s" % (kargs['group'], )

on_message(self, msg):
    pass

class MainRouter(SocketConnection): endpoints : { '/realtime': DistributeHandler, '/other': OtherHandler} on_open(self, *args): print "Connected"

On the client side, I have this: var socket = io.connect("ws://mysite.com/realtime"); socket.emit('join', {group: 5}, function() { console.log('joined'); });

However, the server informs me that 'join' is an invalid event. Is this because the @event decorator is on the endpoint SocketConnection class and not on the MainRouter object? Is @event supposed to be that limited or this a bug? I'd love to be able to put the @event decorator on the endpoint classes, as that would make my system far more flexible. I just wanted to make sure I understood what is going on.

seems to serve the main page OK, as well as socket.io.js. when I click "connect" though, it logs "connecting" but doesn't get any further. same in firefox & chromium.

in the server logs, I see:

2011-11-07 16:35:44,642 INFO:Starting up tornadio server on port '8001'                                       
2011-11-07 16:35:44,643 INFO:Starting Flash policy server on port '843'                                       
2011-11-07 16:35:44,643 INFO:Entering IOLoop...                                                               
2011-11-07 16:36:29,634 INFO:200 GET / (192.168.0.181) 4.91ms                                                 
2011-11-07 16:36:29,729 INFO:200 GET /socket.io.js (192.168.0.181) 21.00ms

On the client-side, if I open up the firebug console, I see it tries to make a bunch of ajax GET requests to, eg:

http://localhost:8001/socket.io/1/?t=1320683800628

but it doesn't receive a response.

enabling & disabling the various different transport types doesn't seem to make a difference

python 2.6 on debian, FF 7.0.1, Chromium 14.0.835.202 (Developer Build 103287 Linux)

I realise it's early days! any ideas what might be going wrong?

Прежде всего спасибо за вашу работу.

Я не уверен, что это баг, но мне такое поведение кажется странным.

Если определены SockectConenction вида:

class ChatConnection(SocketConnection):
    def on_open(self, info):
        self.send('Chat open connection')
        self.send(info.arguments)


class RouterConnection(SocketConnection):
    def on_open(self, info):
        self.send('Router open connection')
        self.send(info.arguments)

    __endpoints__ = {'/chat': ChatConnection,
                    '/ping': PingConnection}

и осуществляется подключение с аргументами

    var chat = new io.connect('http://localhost:8001/chat?test=chat');

То при подключении к chat каналу , сначала создается объект типа RouterConnection и вызывается его метод on_open (здесь query аргументы от сервера приходят), потом создается объект ChatConnection и вызывается его метод on_open, но здесь уже не приходят аргументы от сервера.

Вопрос: Так и должно быть? Я ожидал что при подключении на localhost/chat будет создан только подключение ChatConnection и до него должны дойти аргументы запроса (request.arguments).

For example whe have:

• example.com <- simple site with socket.io
• example.com:8080 <- tornadio2 with ssl mode

In Safari when js connect to the server on host wss://example.com:8080/socket.io/1/websocket/121a6ae3852addac4c159379a585a27a that return error "WebSocket network error: OSStatus Error -9807: Invalid certificate chain"

but in Chrom, Firefox working correctly.

My server config: Nginx

nginx version: nginx/1.3.6
TLS SNI support enabled
configure arguments: --prefix=/usr/share/nginx --conf-path=/etc/nginx/nginx.conf --error-log-path=/var/log/nginx/error.log --http-client-body-temp-path=/var/lib/nginx/body --http-fastcgi-temp-path=/var/lib/nginx/fastcgi --http-log-path=/var/log/nginx/access.log --http-proxy-temp-path=/var/lib/nginx/proxy --http-scgi-temp-path=/var/lib/nginx/scgi --http-uwsgi-temp-path=/var/lib/nginx/uwsgi --lock-path=/var/lock/nginx.lock --pid-path=/var/run/nginx.pid --with-pcre-jit --with-debug --with-http_addition_module --with-http_dav_module --with-http_geoip_module --with-http_gzip_static_module --with-http_image_filter_module --with-http_realip_module --with-http_stub_status_module --with-http_ssl_module --with-http_sub_module --with-http_xslt_module --with-ipv6 --with-sha1=/usr/include/openssl --with-md5=/usr/include/openssl --with-mail --with-mail_ssl_module --add-module=/build/buildd/nginx-1.3.6/debian/modules/nginx-auth-pam --add-module=/build/buildd/nginx-1.3.6/debian/modules/nginx-echo --add-module=/build/buildd/nginx-1.3.6/debian/modules/nginx-upstream-fair --add-module=/build/buildd/nginx-1.3.6/debian/modules/nginx-dav-ext-module

example.com

server {
    listen 80;
    server_name example.com www.example.com;

    rewrite ^(.*)$ https://example.com$1 permanent;
}

server {
    listen 443 ssl;

    server_name example.com www.example.com;

    ssl on;
    ssl_certificate /etc/nginx/ssl/server.crt;
    ssl_certificate_key /etc/nginx/ssl/server.key;

    access_log /var/log/nginx/example.access.log;
    error_log /var/log/nginx/example.error.log;

    root  /var/www/example/htdocs/;
    expires +1M;

    location / {
            include uwsgi_params;
            uwsgi_pass unix:///run/uwsgi/app/example/socket;
    }

    location /websocket_status {
        check_status;
    }

}

example.com:8080

upstream cluster {
    server 127.0.0.1:8001;

    check interval=3000 rise=2 fall=5 timeout=1000;
}

server {
    listen 8080;

    ssl on;
    ssl_certificate /etc/nginx/ssl/server.crt;
    ssl_certificate_key /etc/nginx/ssl/server.key;

    proxy_pass cluster;
}

Thanks.

From what I can tell, the current documentation is a little scant on how to properly implement session handling from within a router. The structure of the code makes it a little difficult to understand how sessions are instantiated.

The chat included with the codebase gives a detailed explanation of how to persist multiple users on a singleton connection object, but does go into detail about persisting sessions or creating channels. A practical howto would be great.

Please upgrade PyPi repositories for package "tornadio2"

When i install "pip install tornadio2" that installed old version package without some fixed bugs :( its very discomfortable, also when i install from github repositories from master "-e git+git://github.com/mrjoes/tornadio2/#egg=TornadIO2" its not working correctly, because TornadIO2-0.0.3-py2.7.egg-info has incorrect link to source for examle that included "../tornadio2/" but source installed in venv/src/tornadio2/tornadio2/...

Do you know why pip do that? It is correctly behavior for pip ?

In the course of writing my own socket.io client, I discovered that a "misbehaving" client that connects to the same endpoint more than once causes any existing connection to that endpoint to never be disconnected in the server (this may be specific to the multiplexed example as it keeps an internal reference to connection and may be interacting poorly with expected garbage collection behavior).

My fix was this:

diff --git a/tornadio2/session.py b/tornadio2/session.py
index c55b5c7..48aadc9 100644
--- a/tornadio2/session.py
+++ b/tornadio2/session.py
@@ -296,6 +296,9 @@ class Session(sessioncontainer.SessionBase):
             return

         conn = conn_class(self, endpoint)
+        old_conn = self.endpoints.get(endpoint, None)
+        if old_conn is not None:
+            self.disconnect_endpoint(endpoint)
         self.endpoints[endpoint] = conn

         self.send_message(proto.connect(endpoint))

Any thoughts on what the proper fix should be?

Hey,

we've noticed several Uncaught exception in /socket.io/1/websocket/ types of errors in our logs. We think it tends to happen when there's a lot of small bits data being transmitted between the client and server in quick succession.

We find that, with every error, an incoming message is received at the same time as a heartbeat... so it looks like that's probably what's causing the issue?

Here's a minimal repro, which should crash within a minute or so... :

from os import path as op
import logging
from tornado import web
from tornadio2 import SocketConnection, TornadioRouter, SocketServer
ROOT = op.normpath(op.dirname(__file__))

class IndexHandler(web.RequestHandler):
    """Regular HTTP handler to serve the ping page"""
    def get(self):
        self.render('index.html')

class SocketIOHandler(web.RequestHandler):
    def get(self):
        self.render('../socket.io.js')

class PongConnection(SocketConnection):
    def on_message(self, message):
        print message
        self.send('pong')

PingRouter = TornadioRouter(PongConnection,
                            dict(enabled_protocols=['websocket', 'xhr-polling',
                                                    'jsonp-polling', 'htmlfile']))
application = web.Application(
    PingRouter.apply_routes([
        (r"/", IndexHandler),
        (r"/socket.io.js", SocketIOHandler)
    ]),
    flash_policy_port = 843,
    flash_policy_file = op.join(ROOT, 'flashpolicy.xml'),
    socket_io_port = 8001
)

if __name__ == "__main__":
    # watch logs for error
    logging.basicConfig(filename='repro.log', level=logging.DEBUG, format='%(asctime)s %(levelname)s:%(message)s')
    SocketServer(application)

<!DOCTYPE html>
<html>
<head>
  <script src="http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script>
  <script src="socket.io.js"></script>
  <script>
    $(function() {
        var socketio = new io.connect('http://' + window.location.host);

        socketio.on('disconnect', function() {
            console.log('disconnected');
        });
        socketio.on('error', function() {
            console.log('error');
        });

        socketio.on('connect', function() {
          console.log('connected');
          for (var i=0; i< 100000; i++){
            socketio.send('ping' + i);
          }
        });
    });
</script>
</head>
<body><h3>Minimal repro</h3></body>
</html>

and here is what we find in the logs -- the <<<3 is a normal socketio message, and if we understand it correctly, the <<<2 is a heartbeat.

2012-03-07 15:49:22,313 DEBUG:>>> 3:::ping10717
2012-03-07 15:49:22,314 DEBUG:<<< 3:::pong
2012-03-07 15:49:22,317 DEBUG:>>> 3:::ping10718
2012-03-07 15:49:22,317 DEBUG:<<< 3:::pong
2012-03-07 15:49:22,323 DEBUG:>>> 3:::ping10719
2012-03-07 15:49:22,324 DEBUG:<<< 3:::pong
2012-03-07 15:49:22,326 DEBUG:<<< 2::
2012-03-07 15:49:22,326 DEBUG:<<< 0::
2012-03-07 15:49:22,327 ERROR:Uncaught exception in /socket.io/1/websocket/9292bc6ecf30cab96d548ae0b87e4e18
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/tornado/websocket.py", line 254, in wrapper
    return callback(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/tornadio2/persistent.py", line 136, in on_message
    self.session.close()
AttributeError: 'NoneType' object has no attribute 'close'

Hi I am trying to set up a cluster of tornado servers behind a load balancer and noticed that SessionContainer is just a dict. This means I MUST send clients to the same server every request. Maybe you already thought about this? What I want to do is implement a memcached session backend so it doesn't matter on which server you end up for each request.

Or maybe you've got some other ideas?

hey, this is more a feature request than an issue, but is it possible to include a python client to interact with the server? there are use cases where we need to to push some data to tornadio server programmatically and a python client woud come handy. other use cases been testing, load testing, etc.

i tried the code hosted here: http://pypi.python.org/pypi/websocket-client/0.5.0a, but i don't think it handles the handshaking protocol implemented in tornadio2.

thx.

I have some problems running tornadio2 in production. I get "Error in periodic callback".

Any ideas what the problem could be?

Many thanks for any hint!

Traceback (most recent call last): File "build/bdist.freebsd-9.1-RELEASE-amd64/egg/tornadio2/periodic.py", line 82, in _run next_call = self.callback() File "build/bdist.freebsd-9.1-RELEASE-amd64/egg/tornadio2/session.py", line 274, in _heartbeat self.send_message(proto.heartbeat()) File "build/bdist.freebsd-9.1-RELEASE-amd64/egg/tornadio2/session.py", line 192, in send_message self.flush() File "build/bdist.freebsd-9.1-RELEASE-amd64/egg/tornadio2/session.py", line 202, in flush self.handler.send_messages(self.send_queue) File "build/bdist.freebsd-9.1-RELEASE-amd64/egg/tornadio2/persistent.py", line 160, in send_messages self.write_message(m) File "lib/python2.7/site-packages/tornado-3.0.1-py2.7.egg/tornado/websocket.py", line 164, in write_message self.ws_connection.write_message(message, binary=binary) AttributeError: 'NoneType' object has no attribute 'write_message'

Issue Type

[x] Bug (Typo)

Steps to Replicate and Expected Behaviour

• Examine tornadio2/persistent.py, tornadio2/session.py and observe hearbeat, however expect to see heartbeat.
• Examine doc/deployment.rst and observe writting, however expect to see writing.
• Examine examples/socket.io.js and observe trigged, however expect to see triggered.
• Examine examples/socket.io.js and observe publci, however expect to see public.
• Examine doc/bugs.rst and observe parametes, however expect to see parameters.
• Examine tornadio2/polling.py and observe hearbeats, however expect to see heartbeats.
• Examine examples/socket.io.js and observe corss, however expect to see cross.
• Examine examples/socket.io.js and observe costructor, however expect to see constructor.

Notes

Semi-automated issue generated by https://github.com/timgates42/meticulous/blob/master/docs/NOTE.md

To avoid wasting CI processing resources a branch with the fix has been prepared but a pull request has not yet been created. A pull request fixing the issue can be prepared from the link below, feel free to create it or request @timgates42 create the PR. Alternatively if the fix is undesired please close the issue with a small comment about the reasoning.

https://github.com/timgates42/tornadio2/pull/new/bugfix_typos

Thanks.

Traceback (most recent call last): File "/usr/local/lib/python3.4/dist-packages/tornado/websocket.py", line 494, in _run_callback result = callback(*args, **kwargs) File "/usr/local/lib/python3.4/dist-packages/TornadIO2-0.0.3-py3.4.egg/tornadio2/persistent.py", line 91, in open raise HTTPError(401, "Invalid Session") tornado.web.HTTPError: HTTP 401: Unauthorized (Invalid Session)

SyntaxError: invalid syntax Traceback (most recent call last): File "", line 1, in File "/usr/local/lib/python3.5/site-packages/circusweb/circushttpd.py", line 25, in import tornadio2 File "/usr/local/lib/python3.5/site-packages/tornadio2/init.py", line 25, in from tornadio2.router import TornadioRouter File "/usr/local/lib/python3.5/site-packages/tornadio2/router.py", line 27, in from tornadio2 import persistent, polling, sessioncontainer, session, proto, preflight, stats File "/usr/local/lib/python3.5/site-packages/tornadio2/persistent.py", line 143 except Exception, ex:

Is tornadio2 compatible with tornado > 3? Over here I just got these failures:

======================================================================
ERROR: tests.gen_test.test
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "./tornadio2/tests/gen_test.py", line 103, in test
    dummy.test('test')
  File "./tornadio2/tornadio2/gen.py", line 113, in wrapper
    run(args, kwargs)
  File "./tornadio2/tornadio2/gen.py", line 84, in run
    data.runner = SyncRunner(gen, finished)
  File "./tornadio2/tornadio2/gen.py", line 45, in __init__
    super(SyncRunner, self).__init__(gen)
TypeError: __init__() takes exactly 3 arguments (2 given)

======================================================================
ERROR: tests.gen_test.test_async
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "./tornadio2/tests/gen_test.py", line 112, in test_async
    dummy.test('test')
  File "./tornadio2/tornadio2/gen.py", line 113, in wrapper
    run(args, kwargs)
  File "./tornadio2/tornadio2/gen.py", line 84, in run
    data.runner = SyncRunner(gen, finished)
  File "./tornadio2/tornadio2/gen.py", line 45, in __init__
    super(SyncRunner, self).__init__(gen)
TypeError: __init__() takes exactly 3 arguments (2 given)

======================================================================
ERROR: tests.gen_test.test_sync_queue
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "./tornadio2/tests/gen_test.py", line 123, in test_sync_queue
    dummy.test('1')
  File "./tornadio2/tornadio2/gen.py", line 113, in wrapper
    run(args, kwargs)
  File "./tornadio2/tornadio2/gen.py", line 84, in run
    data.runner = SyncRunner(gen, finished)
  File "./tornadio2/tornadio2/gen.py", line 45, in __init__
    super(SyncRunner, self).__init__(gen)
TypeError: __init__() takes exactly 3 arguments (2 given)

======================================================================
ERROR: tests.gen_test.test_sync_queue_oor
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "./tornadio2/tests/gen_test.py", line 136, in test_sync_queue_oor
    dummy.test('1')
  File "./tornadio2/tornadio2/gen.py", line 113, in wrapper
    run(args, kwargs)
  File "./tornadio2/tornadio2/gen.py", line 84, in run
    data.runner = SyncRunner(gen, finished)
  File "./tornadio2/tornadio2/gen.py", line 45, in __init__
    super(SyncRunner, self).__init__(gen)
TypeError: __init__() takes exactly 3 arguments (2 given)

======================================================================
FAIL: tests.session_test.test_endpoint
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "./tornadio2/tests/session_test.py", line 247, in test_endpoint
    eq_(conn_test.request.arguments, dict(a=['123'], b=['456']))
AssertionError: {} != {'a': ['123'], 'b': ['456']}
-------------------- >> begin captured logging << --------------------
tornadio2.session: DEBUG: <<< 1::
tornadio2.session: DEBUG: >>> 1::/test?a=123&b=456
tornadio2.session: DEBUG: <<< 1::/test
--------------------- >> end captured logging << ---------------------

----------------------------------------------------------------------
Ran 17 tests in 0.063s

FAILED (errors=4, failures=1)

This fixes issue #48. It was surprisingly straightforward.

A few things of note: 0. The aim was to have a single codebase that's compatible with both major versions.

1. It takes advantage of the py3 syntax backports into 2.6 and 2.7 as well as the reintroduced u'string' literals in 3.3. As such, the code is not compatible with 2.5, 3.1 and 3.2. If that's alright with the community, I'd like to keep it that way because it makes it much easier to maintain. If it is a problem, we should come up with a consensus on the supported versions and I shall attempt to update this.
2. I didn't get to port the tests yet. That's to come next week if there's an interest the port. I have updated and tested the examples, though, and they work.
3. Related to that, the "gen" and "ssl_transports" examples didn't work for me out of the box on master so I don't test them on the python3 branch either. I'll look into it next week to see if there are genuine bugs or it's just an issue with my setup.

I tried to follow Armin Ronacher's suggestions: http://lucumr.pocoo.org/2013/5/21/porting-to-python-3-redux/

Please do try it out and let me know if you have any issues or concerns over the code.