Instead of copying six functions into retrying codebase why not just require the six module itself? This was if six updates then you automatically get this update as well...

Often times retrying is done in a stepping manner whereupon the first N attempts wait X ms, the next M attempts wait for Y ms, etc. This patch implements support for such waiting by introducing the notion of 'wait markers'. Wait markers are simply tuples that define a set of attempts and their corresponding waits to go into effect.

A handful of unit tests are also included.

Hi,

I'm a happy user of retrying, and i would like to use its features to retry coroutines. I wrote a PoC at https://github.com/novafloss/jenkins-epo/blob/master/jenkins_epo/utils.py#L34 , but i would like to contribute a more sane and integrated support.

So here is my contribution :) It comes with one unit test which i hope is enough for code coverage.

What do you think of this ? I would like to make it as consistent as possible with existing code and minimal.

Regards, Étienne

Would be very helpful to support retrying as a context manager:

Something along the lines of:

def do_something_unreliable():
    if random.randint(0, 10) > 1:
        raise IOError("Broken sauce, everything is hosed!!!111one")
    else:
        return "Awesome sauce!"

with retry(wait_fixed=2000):
    do_something_unreliable()

Adds an on_exception argument to specify the class of exception to catch. This provides a cleaner API to catching only specific exception classes.

Opening this in part as a POC and to start discussion. I think it is a much nicer API for this use case and also solves the issue of catching BaseException by default.

See #17

As described in https://www.awsarchitectureblog.com/2015/03/backoff.html, this allows better distribution of competing clients across time during the retries.

Adds two additional parameters to the Retrying() constructor:

_before_attempts
_after_attempts

Each of these should be a reference to a function that takes a single argument, attempt_number.

_before_attempts will be called before each attempt is run; _after_attempts is run after any unsuccessful attempt.

Handy for logging status messages, etc in between attempts.

Hi, I just found your library and it looks to do exactly what I was looking for. However when launching the code below, I am getting a RetryError. Is is the intended behavior?

from retrying import retry, RetryError

@retry(wait_fixed=100,
       stop_max_attempt_number=10,
       wrap_exception=False)
def foo():
    raise ValueError()

try:
    foo()
except ValueError:
    print "ValueError"
except RetryError as e:
    print "RetryError"

Intuitively, I was expecting a ValueError. That would let me use the retry decorator without modifying the rest of the code.

retrying uses six.wraps, which requires at least version 1.7: https://bitbucket.org/gutworth/six/src/35f6d89f826f63486214e4746af028ccaa088901/six.py?at=1.7.0#cl-689

hi, does someone have a clue on this error ? thanks

$ python -V Python 2.6.6 $$ >>> six.version '1.6.1'

$ python setup.py test running test running egg_info writing requirements to retrying.egg-info/requires.txt writing retrying.egg-info/PKG-INFO writing top-level names to retrying.egg-info/top_level.txt writing dependency_links to retrying.egg-info/dependency_links.txt reading manifest file 'retrying.egg-info/SOURCES.txt' reading manifest template 'MANIFEST.in' writing manifest file 'retrying.egg-info/SOURCES.txt' running build_ext Traceback (most recent call last): File "setup.py", line 57, in setup(**settings) File "/usr/lib/python2.6/distutils/core.py", line 152, in setup dist.run_commands() File "/usr/lib/python2.6/distutils/dist.py", line 975, in run_commands self.run_command(cmd) File "/usr/lib/python2.6/distutils/dist.py", line 995, in run_command cmd_obj.run() File "/usr/lib/python2.6/dist-packages/setuptools/command/test.py", line 137, in run self.with_project_on_sys_path(self.run_tests) File "/usr/lib/python2.6/dist-packages/setuptools/command/test.py", line 117, in with_project_on_sys_path func() File "/usr/lib/python2.6/dist-packages/setuptools/command/test.py", line 146, in run_tests testLoader = loader_class() File "/usr/lib/python2.6/unittest.py", line 816, in init self.parseArgs(argv) File "/usr/lib/python2.6/unittest.py", line 843, in parseArgs self.createTests() File "/usr/lib/python2.6/unittest.py", line 849, in createTests self.module) File "/usr/lib/python2.6/unittest.py", line 613, in loadTestsFromNames suites = [self.loadTestsFromName(name, module) for name in names] File "/usr/lib/python2.6/unittest.py", line 576, in loadTestsFromName module = import('.'.join(parts_copy)) File "/root/retrying-master/test_retrying.py", line 245, in @retry(wait_fixed=50, retry_on_result=retry_if_result_none) File "/root/retrying-master/retrying.py", line 47, in wrap @six.wraps(f) AttributeError: 'module' object has no attribute 'wraps'

Instead of having a decorator which loses the parents docstrings and name and other the decorator should be using functools.wraps (or six.wraps). Or even better it seems like you could just use https://pypi.python.org/pypi/wrapt which is likely better than the wraps() methods.

Thanks for this useful package and work over the years.

Given that your priorities now lie elsewhere, would you be open to transferring ownership of the PyPI package name to tenacity?

https://github.com/jd/tenacity/issues/356

No work on your part and a compatibility shim will be added.

I use mypy and want to have type hints for retrying to fix this error:

error: Skipping analyzing "retrying": module is installed, but missing library stubs or py.typed marker  [import]
note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports

Current non-optimal solution is to ignore by adding the following lines to the mypy.ini config.

[mypy-retrying.*]
ignore_missing_imports = True

Add print_exception attribute for exception printing for every attempt. For example

####Define functions (before_attempts, after_attempts)#### def print_attemt(attempt): print(f"Start Attempt # {attempt}") return attempt

def print_attemt_after(attempt): print(f"Attempt # {attempt} was failed") return attempt

Then call a func function with retry (we also can use retry as a decorator with func definition)

retry(stop_max_attempt_number=3, print_exception=True, before_attempts=print_attemt, after_attempts=print_attemt_after)(func)(par)

After func call we get the below

Start Attempt # 1 [Errno 2] No such file or directory: 'F:\TEST\test.txt' Attempt # 1 was failed Start Attempt # 2 [Errno 2] No such file or directory: 'F:\TEST\test.txt' Attempt # 2 was failed Start Attempt # 3 [Errno 2] No such file or directory: 'F:\TEST\test.txt' Attempt # 3 was failed

Hey guys, could you please create a new release (1.3.4?) from master? I really need the latests commits that are found in master.

Thanks in advance :)