Hi all,

Unless actions = None in my ModelAdmin class definitions, grappelli raises and javascript exception and the filter functionality (with fields defined in list_filter) breaks. The dropdown button shows up but nothing drops down when you click on it.

The error is "Uncaught TypeError: Object [object Object] has no method 'actions' " on the line $("tr input.action-select").actions(); (line 66 in the grappelli template).

The relevant code snippet from the grappelli code

Also, I think this might be similar to Issue #206.

I'm using Django 1.4.1 and Grappelli 2.4.2

VERSIONS: Grappelli 2.15.1, Django 3.2 STATICFILES: WARNINGS, Details: I see a lot of errors with text like this

Found another file with the destination path 'admin/js/autocomplete.js'. It will be ignored since only the first encountered file is collected. If this is not what you want, make sure every static file has a unique path.

JAVASCRIPTS: ERROR Failed to load resource: the server responded with a status of 403 (Forbidden) CUSTOMIZATIONS: NONE

I upgraded django from 2.2 to 3.2 and it broke the autocomplete on related fields it just always says 403 and gives the following error:

Forbidden (Permission denied): /admin/autocomplete/
Traceback (most recent call last):
  File "/home/alex/Project/env/lib/python3.8/site-packages/django/utils/datastructures.py", line 76, in __getitem__
    list_ = super().__getitem__(key)
KeyError: 'app_label'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/alex/Project/env/lib/python3.8/site-packages/django/contrib/admin/views/autocomplete.py", line 61, in process_request
    app_label = request.GET['app_label']
  File "/home/alex/Project/env/lib/python3.8/site-packages/django/utils/datastructures.py", line 78, in __getitem__
    raise MultiValueDictKeyError(key)
django.utils.datastructures.MultiValueDictKeyError: 'app_label'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/alex/Project/env/lib/python3.8/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/home/alex/Project/env/lib/python3.8/site-packages/django/core/handlers/base.py", line 181, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/alex/Project/env/lib/python3.8/site-packages/django/contrib/admin/sites.py", line 250, in wrapper
    return self.admin_view(view, cacheable)(*args, **kwargs)
  File "/home/alex/Project/env/lib/python3.8/site-packages/django/utils/decorators.py", line 130, in _wrapped_view
    response = view_func(request, *args, **kwargs)
  File "/home/alex/Project/env/lib/python3.8/site-packages/django/views/decorators/cache.py", line 44, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)
  File "/home/alex/Project/env/lib/python3.8/site-packages/django/contrib/admin/sites.py", line 232, in inner
    return view(request, *args, **kwargs)
  File "/home/alex/Project/env/lib/python3.8/site-packages/django/contrib/admin/sites.py", line 417, in autocomplete_view
    return AutocompleteJsonView.as_view(admin_site=self)(request)
  File "/home/alex/Project/env/lib/python3.8/site-packages/django/views/generic/base.py", line 70, in view
    return self.dispatch(request, *args, **kwargs)
  File "/home/alex/Project/env/lib/python3.8/site-packages/django/views/generic/base.py", line 98, in dispatch
    return handler(request, *args, **kwargs)
  File "/home/alex/Project/env/lib/python3.8/site-packages/django/contrib/admin/views/autocomplete.py", line 20, in get
    self.term, self.model_admin, self.source_field, to_field_name = self.process_request(request)
  File "/home/alex/Project/env/lib/python3.8/site-packages/django/contrib/admin/views/autocomplete.py", line 65, in process_request
    raise PermissionDenied from e
django.core.exceptions.PermissionDenied
[02/May/2021 20:11:33] "GET /admin/autocomplete/ HTTP/1.1" 403 135

This ticket seems to be related to the issue https://code.djangoproject.com/ticket/32659?cversion=2&cnum_hist=2

Downgrade to 3.1 fixes the issue.

Similar to this user: http://stackoverflow.com/questions/17852308/how-to-filter-autocompletion-results-in-django-grapelli/17981530#17981530

I need to restrict all FK/M2M lookups. In my case, I restrict them to the company division that entered the data. Similar to SAS.

The existing "ForeignKey.limit_choices_to" (https://docs.djangoproject.com/en/1.5/ref/models/fields/#django.db.models.ForeignKey.limit_choices_to) does not seem able to access anything in the "request" object or session storage.

The ModelAdmin.queryset feature: https://docs.djangoproject.com/en/1.5/ref/contrib/admin/#django.contrib.admin.ModelAdmin.queryset

Is passed the request object, which lets me easily restrict records using: qs.filter(site__id=request.session['site'].id)

What I need is a non-hack way to either instruct Grappelli to use the admin specific model manager (or any custom manger the user cares to define), or a way to include request/session values in the filter.

I have a pull request pending for "django_extensions" to fix this with their autocomplete function.

Thanks in advance!

I just installed django-grappelli 2.3.4 in combination with Django 1.4.0 alpha. All's fine, except for the filter drop-down box on the change list page. Chrome and Firefox report a Javascript error:

Uncaught TypeError: Object #<Object> has no method 'actions'
(anonymous function):8000/admin/msdb/incident/:59
c.extend.readyjquery-1.4.2.min.js:26
L

The relevant bit of code is in templates/admin/change_list.html. A fix seems to be moving the block

{% if action_form %}
  ...
{% endif %}

from line 19 down to line 65, right after {{ media.js }}. I believe this is because the actions.js script is loaded in the block contained by media.js, which comes after relevant Javascript code.

Not sure if this is a result of Django code still being in alpha, but figured I'd report it.

Another error occurrs at the same time by grp_collapsible in templates/admin/includes_grappelli/header.html:

Uncaught TypeError: Object #<Object> has no method 'grp_collapsible'

Don't know how to fix this one, though.

For the grids and styles, would be great to use twitter bootstrap instead of blueprint as it will come out with more themes in near future and is more actively updated.

VERSIONS: Grappelli 2.7.1(stable from pip), Django 1.8.3, Python 2.7.9 STATICFILES: OK JAVASCRIPTS: OK? I'm not sure due to this failure (Tested in Firefox 40) CUSTOMIZATIONS: NONE *

• ...unless adding tinymce.js through myapp/admin.py counts as a customization...

The failure itself looks simple: if I try to select a model's record in admin panel clicking the checkboxes, it keeps saying "selected 0 of n" and doesn't let me perform DELETE operation through the admin's GUI. This issue happens with any kind of model; even the basic ones, like the users for example.

Maybe I can try to figure out why this happens - (I mean, I feel comfortable with Python, HTML, CSS -not so comfortable with CSS, but I understand it xD-, JavaScript, jQuery -technically, it is a JavaScript's library :P- and SQL languages; and I have been dealing with Django framework for six months or more)... The problem is that I have no idea where are the functions that control the checkbox's state to start debugging (I mean, I know where to find the package and the source in my machine, but not which order should I follow to analyze the implied functions/classes, because I just don't know them yet)... however, I would try it out.

PD: How do things work in case I want to self-assign this issue? I guess I would probably need permission or something...

Hi,

thank you for sharing & maintaining this great, hiqh-quality, useful Django package.

I found some support for localized (i18n) datepickers in Grappelli, but they did not seem to work for me. So, I created this small patch. I'd be more than happy if you merged it.

I used {% if LANGUAGE_CODE %} to test for i18n support, but I don't know if this is the best way.

VERSIONS: Grappelli 2.5.6, Django 1.6.10
STATICFILES: ERROR
CUSTOMIZATIONS: NONE

Running ./manage.py collectstatic && ./manage.py.compress throws this:

ValueError: The file 'grappelli/jquery/i18n/ui.datepicker-en-us.js' could not be found with <django.contrib.staticfiles.storage.CachedStaticFilesStorage object at 0x2d61550>.

I just upgraded to 2.7.3 from 2.7.1 and my filter stopped working. I get a javascript error: (index):63 Uncaught TypeError: $(...).actions is not a function

First time to use Grappelli, so please bear with my very native question. I am intrigued by the autocomplete feature and added GRAPPELLI_AUTOCOMPLETE_SEARCH_FIELDS = { "dry_powder": { "PositionLevelData": ("Position__icontains",) } } into my settings. My understanding is now when I enter partial names of Position in the search field of the changelist page, my typein will be autocompleted. Yet I see nothing like that. Am I misunderstanding something or missing something? Thanks for the great work.

autocomplete-field which needs to work with

• foreign keys
• many-to-many relationships
• generic relationships

on both the change-form and the change-list. moreover, the search-icon is necessary as well (since with an autocomplete, one might not receive all possible items in rare cases).

Thanks for maintaining that great project! I'm running into some weird behavior when trying to run/integrate a multiple layer nested admin with grappelli.

here's the dummy models I have. Nothing too fancy, pretty straightforward nested models. Note that the Article has two foreign key referencing it. One from the image and one from the paragraph models.

class TableOfContents(models.Model):
    title_tableofcontents = models.TextField()


class TocSection(models.Model):
    title_tocsection = models.TextField()
    table_of_content = models.ForeignKey(TableOfContents, on_delete=models.CASCADE)


class TocArticle(models.Model):
    title_tocarticle = models.TextField()
    section = models.ForeignKey(TocSection, on_delete=models.CASCADE)


class TocParagraph(models.Model):
    title_tocparagraph = models.TextField()
    article = models.ForeignKey(TocArticle, on_delete=models.CASCADE)


class TocImage(models.Model):
    title_tocimage = models.TextField()
    article = models.ForeignKey(TocArticle, on_delete=models.CASCADE)

Here's how my admin looks without trying to rearrange the nested inlines. Also nothing too fancy here pretty straightforward, just note that article is already an inline of sections (which is an inline of table of content)

class TocParagraphInline(NestedStackedInline):
    model = models.TocParagraph


class TocImageInline(NestedStackedInline):
    model = models.TocImage


class TocArticleInline(NestedStackedInline):
    model = models.TocArticle
    inlines = [TocParagraphInline, TocImageInline]
    fieldsets = [
        (
            "Image Data",
            {
                "fields": [],
                # "classes": [
                #     "placeholder tocsection_set-1-tocarticle_set-0-tocimage_set-group"
                # ],
            },
        ),
        (
            "Paragraph Data",
            {
                "fields": [],
                # "classes": [
                #     "placeholder tocsection_set-1-tocarticle_set-0-tocparagraph_set-group"
                # ],
            },
        ),
        (
            "Article Data",
            {"fields": ["title_tocarticle"]},
        ),
    ]


class TocSectionInline(NestedStackedInline):
    model = models.TocSection
    inlines = [TocArticleInline]


class TableOfContentsAdmin(NestedModelAdmin):
    inlines = [TocSectionInline]


admin.site.register(models.TableOfContents, TableOfContentsAdmin)

Here's how things look on the admin UI

Now as you might have guessed, my goal is to rearrange the inlines image and paragraph under the designated fieldsets for each category. When uncommentting the classes to try to rearrange them some weird behavior happen. here's a screenshot

As you can see the sections have been rearranged correctly but as a consequence:

1. The title of the fieldset, here Image Data and Paragraph Data have disappeared.
2. The blue tabs to un-collapse the inlines does not work on preloaded inlines 2.1 If I add a new article the un-collapsing works but the title of the fieldset mentioned in 1) is not present either.
3. The add Image and Paragraph buttons also stop working when the inlines are moved.

Would appreciate any help or directions, happy to contribute if I can help!

GitHub pinned it as a high-severity and moderate threat, full description:

• Race Condition in Grunt: file.copy operations in GruntJS are vulnerable to a TOCTOU race condition leading to arbitrary file write in GitHub repository gruntjs/grunt prior to 1.5.3. This vulnerability is capable of arbitrary file writes which can lead to local privilege escalation to the GruntJS user if a lower-privileged user has to write access to both source and destination directories as the lower-privileged user can create a symlink to the GruntJS user's .bashrc file or replace /etc/shadow file if the GruntJS user is root.

Solution: Update "grunt": ">=1.5.3"

• Path Traversal in Grunt: Grunt prior to version 1.5.2 is vulnerable to path traversal.

class TariffAdmin(admin.ModelAdmin):
    change_list_template = "admin/change_list_filter_confirm.html"
    list_filter = (
        'merchant',
        'contract__legal'
    )

Selecting merchant and contract__legal in this example multiple times (and after that pressing Apply) produces an url like: http://127.0.0.1:8000/admin/backend/tariff/?contract__legal__legal_id__exact=1&contract__legal__legal_id__exact=1&merchant__merchant_id__exact=2&contract__legal__legal_id__exact=1&merchant__merchant_id__exact=3

While select inputs allow only single choise.

It seems that you keep overwriting the ChangeLog file/deleting the old content and only keep the latest changes so the only way to actually look at the change log is to dig its commit history. However the very purpose of a change log file would be to show the history of changes.

E.g. the current Changelog file only shows what's new for 3.0.x, but that only works with Django 4.0 so whoever still using Grappelli 2.x won't see anything informative there. And this includes those who plan to upgrade to 3.x (not even 3.0 is included in the Changelog file), which I guess is a larger changeset.

The idea behind a change log file is to be able to find the version I use and then be able to look at all the improvements over time. Please consider merging the individual versions from the git history and keeping a continuous log from this point on.

It is currently only possible to define exactly one date_hierarchy with Django. But it is sometimes useful to define more than one of these filters. Check if we can easily implement this.