Signed-off-by: Sunil Mohan Adapa [email protected]

Debian is moving to Django 2.0 soon and django-bootstrap-form needs to work with Django 2.0. Many applications such as FreedomBox using will have problem otherwise.

Please merge this patch and make a new release so that we can package for Debian immediately. Thank you in advance.

Hi,

I changed the code to make it work with bootstrap 3.0.

Due to a time issue, I only tested simple forms with textarea and text input. I didn't tried formsets and single field rendering, neither the radio and checkbox fields. So you definitively need to check if the code is fully ready for merging.

I'l try to make more tests next weekend if I find time for it.

Catching this deprecation warning when rendering using the template tag.

/bootstrapform/templatetags/bootstrap.py:80: RemovedInDjango110Warning: render() must be called with a dict, not a Context.
  return template.render(context)

ahoy there! first of all thanks :+1:

second: in https://github.com/tzangms/django-bootstrap-form/blob/master/bootstrapform/init.py you could do

from meta import VERSION

instead of

from bootstrapform.meta import VERSION

It works just as well, but that way people can put that module wherever

gracias

Great idea to keep bootstrap to tags in Django. Might be better than making real BootstrapForm, BootstrapModelForm, etc.

But why limit it to forms only? You could have tags to include Bootstrap CSS, additional JavaScript (required to make topbar etc work).

Getting this error in Django 1.11.2. It looks like the previous fix missed a use case. See https://github.com/tzangms/django-bootstrap-form/pull/82/files#r118964036 for more details.

I'm getting error: 'unicode' object has no attribute 'visible_fields'

Exception Type: AttributeError Exception Value:
'unicode' object has no attribute 'visible_fields' Exception Location: /Users/nano/code/turpial/kooshi/kenv/lib/python2.7/site-packages/bootstrapform/templatetags/bootstrap.py in render, line 74

Do you know how could it be fixed?

Hi,

I propose to change the tag library name and the template tags itself from "bootstrap" to "bootstrapform", as, in my opinion, bootstrap is a little too generic in this case (other bootstrap apps for django already exist)

cheers Mauro

First, thanks for the package, saved me a bunch of time.

It might be nice to support a list of radio fields, which currently come out wrong if you use Django's RadioSelect widget

I did it using code something like this: https://gist.github.com/2007671

You might want a different approach, though, looking at your forms.html

Hi,

I accidentally updated this library and now my system using bootstrap 1.4 does not display forms the way it used to. Checkboxes with labels that were listed down the page are now jumbled together. Are you going to offer either a versioned pypi package that I can install a specific version of or a setting to support one vs. the other? I can help with either of these if you'd prefer.

Looks like the fix for #77 got thwarted by an indentation error.

If you take a look at this compatibility code: https://github.com/tzangms/django-bootstrap-form/blob/master/bootstrapform/templatetags/bootstrap.py#L80

It is actually under the else when it should be covering both cases. This causes the project to be Django 1.10 incompatible under certain circumstances.

• In Django 4.0, widget CheckboxSelectMultiple is a sub-class of RadioSelect causing the former to be rendered as the latter. Fix this by improving the check.

• Versions of Django < 3.2 are no longer supported[1]. Drop support for them. Continue to support Django 2.2 has this is the version in current Debian stable (and requires no special handling).

• Versions of Python < 3.7 are no longer supported[2]. Drop support for them.

• Remove comments and code referring to older versions for simpler code.

Links:

1. Django Supported Version: https://www.djangoproject.com/download/

2. Python Supported Versions: https://devguide.python.org/#status-of-python-branches

Hi Here is my contribution to your code, its working good on powersystems.

Thanks for the code, its working good.

What do these changes do?

Added Architecture "ppc64le"

Are there changes in behavior for the user?

No

This simple patch allows to set grid layout to form fields with the following usage:

{% bootstrap form %} field1 field2 field3 field4 field5 {% endbootstrap %}

each line will be renderd as a .row div, and each field will take automatic .col-size

add_input_classes should return field to use it as a filter.

--- a/bootstrapform/templatetags/bootstrap.py
+++ b/bootstrapform/templatetags/bootstrap.py
@@ -45,20 +45,21 @@ def bootstrap_horizontal(element, label_cols='col-sm-2 col-lg-2'):

     return render(element, markup_classes)

 @register.filter
 def add_input_classes(field):
     if not is_checkbox(field) and not is_multiple_checkbox(field) \
        and not is_radio(field) and not is_file(field):
         field_classes = field.field.widget.attrs.get('class', '')
         field_classes += ' form-control'
         field.field.widget.attrs['class'] = field_classes
+    return field

I would open one-line PR if you want. Thanks.