Hi there - I see that you've recently added support for the get runPattern
method. Thanks for that! I tested it out this evening and ran into a couple of issues.
First, when running getRunPattern(zones=None)
it picks one of my zones to send the request for (instead of defaulting to all zones as is the behavior for other functions).
Also, I got this error:
Traceback (most recent call last):
File "/usr/local/python/lib/python3.10/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/local/python/lib/python3.10/site-packages/jellyfishlightspy/jellyfishmain.py", line 85, in getRunPattern
runPatternsClass = RunPatternClassFromDict(runPatterns)
File "/usr/local/python/lib/python3.10/site-packages/jellyfishlightspy/runPattern.py", line 95, in RunPatternClassFromDict
return RunPatternClass.from_dict(s)
File "/usr/local/python/lib/python3.10/site-packages/jellyfishlightspy/runPattern.py", line 57, in from_dict
data = RunPatternDatafromdict(json.loads(obj.get("data")))
File "/usr/local/python/lib/python3.10/json/__init__.py", line 346, in loads
return _default_decoder.decode(s)
File "/usr/local/python/lib/python3.10/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/local/python/lib/python3.10/json/decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
Here is the JSON sent and received:
Sending: {"cmd": "toCtlrGet", "get": [["runPattern", "Back lower"]]}
Recieved: {"cmd":"fromCtlr","runPattern":{"data":"","file":"Special Effects/Pink Waves","id":"Back lower","state":1,"zoneName":["Back lower"]}}
Hope you are already aware of this and working on a fix. I may work on a fix myself when I have time and will submit a PR if I do.
Last, are you planning to publish these changes to PyPI? I'm working on a third party integration and will need these changes published to take advantage of them.