This is something that was implemented before #2 (re-architecture), so looking back at this commit will help re-implement this feature: 7373b50eddf0b19030c19646b6b1c6020e231664

Color selection should be available by both stocks_config and by cli arguments.

Currently this project uses Pythons default round() function, but I found that my stock broker (I use Schwab) always rounds down, which means that the numbers this program outputs can be incorrect.

Two rounding modes we should support:

• "Math" rounding: 1.4 -> 1, 1.5 -> 2
• "Down" rounding: 1.4 ->1, 1.5 -> 1

I suppose we could support "Up" rounding as well, but lets be honest - nobody would use that, which is why I didn't bother listing it.

Any arguments given as part of the command line arguments should override any settings given in the config files.

Due to the nature of how many arguments will be available. I will not be accepting any pull requests that do not have detailed documentation included.

Currently tracking a stock allows for a single "total owned" value and a single "bought at" value, meaning if multiple shares of the same stock are purchased at different prices - the user has to manually take an average of the purchase prices to get decent portfolio data.

I'm not yet best sure how to best implement this. The multiple config files are already messy enough as is, and adding a line or two for every purchase would become unmanageable quite quickly.

Adding the "help wanted" label to this ticket as I am currently taking suggestions for implementation of this feature.

• building off of #30
• refactor portfolio and stock classes for more efficient processing
• refactor renderer
• add gains/loss tracking to table output
• argument parsing refactor

@ConradSelig This builds off of my previous PR and I am just seeing your comments there.

This PR is mainly for performance improvements - the biggest change is fetching all ticker data in one request rather than a request per ticker.

If you're not opposed, I'll work the feedback from the previous PR into this one and just close that.

I'm aware of the merge conflicts and will address those - in the meantime, wanted to get your eyes on this.

Feature includes: Manual color selection to the portfolio.ini file (added instructions in the readme). This is either from the approved list, or using Hex code (which gives the used complete freedom with the color, as you mentioned). Color selection when actually drawing the graph (one of the three cases for no manual color, worded manual color, and hex manual color). Input test in the Portfolio.populate function, where I check that the color entered is valid.

PORTFOLIIO.IN

Aya-Anu:~/code/oss/cliStocksTracker$ cat portfolio.ini ;[AAPL] ;graph=True ;buy=10@100 ;buy=5@120 ;sell=3@122 ;sell=8@125 ;color=#FFFF00

; Ford Motor Company [F] graph=True color=#FFFF00

CONFIG.INI

Aya-Anu:~/code/oss/cliStocksTracker$ cat config.ini [Frame] width=80 height=20

[General] independent_graphs=False timezone=America/Phoenix rounding_mode=math

OUTPUT

Aya-Anu:~/code/oss/cliStocksTracker$ python3 cliStocksTracker.py

1 Failed download:

• FOO: No data found for this date range, symbol may be delisted /Users/clu/code/oss/cliStocksTracker/portfolio.py:44: RuntimeWarning: invalid value encountered in double_scalars self.gains_per_share = self.gains / self.count

<...Graph Deleted for Brevity...>

Current Time: Friday Mar 19, 2021 - 12:22:30 PM Total Cost: $0
Total Value: $0
/Users/clu/code/oss/cliStocksTracker/renderer.py:135: RuntimeWarning: invalid value encountered in double_scalars gain / self.portfolio.cost_value * 100, self.mode, 2 Value Gained Today: +$0 +0%
Value Gained Overall: +$0 +0%

• load the portfolio file independently of syncing market data
• create ui directory/package and move renderer there
• rename project file to main.py
• remove the need for config.ini (will be more apparent why in next PR) -- all args get assigned a default and can be controlled directly through the CLI
• add initial buy/sell transaction support

• introduce a way to programmatically print table data. Each column get's a formatter and as we iterate the portfolio entries we use just call the formatter for the given column.
• individual cell color
• row highlighting

Currently the portfolio summary is rather... primitive. While I still want to maintain the original spirit of the project and keep the portfolio summary an "at a glance" table, I would love to increase the amount of information shown akin to mop.

My name is Luis, I'm a big-data machine-learning developer, I'm a fan of your work, and I usually check your updates.

I was afraid that my savings would be eaten by inflation. I have created a powerful tool that based on past technical patterns (volatility, moving averages, statistics, trends, candlesticks, support and resistance, stock index indicators). All the ones you know (RSI, MACD, STOCH, Bolinger Bands, SMA, DEMARK, Japanese candlesticks, ichimoku, fibonacci, williansR, balance of power, murrey math, etc) and more than 200 others.

The tool creates prediction models of correct trading points (buy signal and sell signal, every stock is good traded in time and direction). For this I have used big data tools like pandas python, stock market libraries like: tablib, TAcharts ,pandas_ta... For data collection and calculation. And powerful machine-learning libraries such as: Sklearn.RandomForest , Sklearn.GradientBoosting, XGBoost, Google TensorFlow and Google TensorFlow LSTM.

With the models trained with the selection of the best technical indicators, the tool is able to predict trading points (where to buy, where to sell) and send real-time alerts to Telegram or Mail. The points are calculated based on the learning of the correct trading points of the last 2 years (including the change to bear market after the rate hike).

I think it could be useful to you, to improve, I would like to share it with you, and if you are interested in improving and collaborating I am also willing, and if not file it in the box.

If tou want, Please read the readme , and in case of any problem you can contact me , If you are convinced try to install it with the documentation. https://github.com/Leci37/stocks-Machine-learning-RealTime-telegram/tree/develop I appreciate the feedback

Would be great if we could check a graph (and other info) for a ticker provided not via portfolio.ini but simply from command line, something like this:

cliStocksTracker.py --stock=AAPL

By that, it would be possible to use cliStocksTracker.py as a quick reference. What do you think? Or am I missing something, and this is already possible?

This is a string formatting problem more than a techincal one. All values in the table should be buffered out to include n decimal places.

If n=2 "14.0" -> "14.00" "235.6" -> "235.60" "5" -> "5.00"

There are some places in the table that use more than two decimal places, so decimals should be buffered out to match the rounding wherever needed.

I've set up the pipline for proper testing - but there are still no tests to run! This ticket will serve as a place for everyone who wants to write some test cases to collaborate.

New testing files should go in ./tests/

The testing framework we are using is pytest, find their documentation here.

The testing suite will now be run everytime a commit is pushed into the repo, tests will not automatically run for pull requests (until they are pulled). Code coverage is also automatically uploaded everytime a commit is pushed, you can find exact details for coverage here at codecov.

I'm going to be flushing out the testing suite to the best of my ability for the next week or so - but any help would be appreciated!

Currently even after market close cliStocksTracker will re-download the data for each ticker, despite the fact it hasn't changed. A tmp file should be created at market close to store the last (market) day's data so we don't have to redownload that everytime.