In c#, OptionsHandler forces options to be at the root of the element:

var match = Regexes.OptionsEntityRegex.Match(data);
if(match.Success)
{
    var id = match.Groups[1].Value;
    state.Options = new Options {Id = int.Parse(id), OptionList = new List<Option>(), TimeStamp = timestamp};
    state.UpdateCurrentNode(typeof(Game));
    if(state.Node.Type == typeof(Game))
        ((Game)state.Node.Object).Data.Add(state.Options);
    else
        throw new Exception("Invalid node " + state.Node.Type + " -- " + data);
    return;
}

The effect of this is that if you are within an Action, the Options node will cause the parser to set the current node as the Game, and all subsequent calls will be added to the Game, instead of the previous Action node.

I don't know enough Python to point out where in the code that happens, but looking at the attached files you can clearly see at line 793 that the output XML diverges

python.out.xml.txt csharp.out.xml.txt

The initial log is also attached, and from reading it (line 878 is where the option is declared), there seems to be no reason not to attach the Options to the root Action instead of the Game node.

Power_2.log.txt

So my question is: what is the correct output?

Thanks!

In the second game (after the reconnect).

powerlog: http://files.hsdecktracker.net/powerlog.txt hsreplay: http://hsreplay.net/joust/replay/d43a810d-3b40-419f-ad8b-0aa57a47cc31

Hey,

I've tried to generate an hsreplay from the output_log.txt file, but got a 'PowerLogParser' object has no attribute 'game', and indeed it looks like the generated log files miss the game declaration at the beginning (I've attached an example of output_log.txt I get using HDT).

Is there something to configure that I've missed?

Thanks,
Seb

• [x] Add command line argument to use PowerTaskList
• [x] Add frozen script download to releases (cx_freeze)

Also: Do we want to keep the csharp implementation on this repo (will most likely not be maintained)?

I add a new features and a bash system

main.py -all [folder](will convert all files in .hdtreplay in hsreplays files %28 without spaces in the name %29) main.py -help ( display help )

Traceback (most recent call last):
  File "python/convert.py", line 13, in <module>
    main()
  File "python/convert.py", line 9, in main
    print(log_to_xml(f))
  File "/home/benedict/Dokumente/HSReplay/python/hsreplay/__init__.py", line 314, in log_to_xml
    root.append(game_element.xml())
  File "/home/benedict/Dokumente/HSReplay/python/hsreplay/__init__.py", line 50, in xml
    element.append(node.xml())
  File "/home/benedict/Dokumente/HSReplay/python/hsreplay/__init__.py", line 50, in xml
    element.append(node.xml())
  File "/home/benedict/Dokumente/HSReplay/python/hsreplay/__init__.py", line 59, in xml
    element.attrib["ts"] = self.ts.isoformat()
AttributeError: 'str' object has no attribute 'isoformat'

Power.log.

In Power_2.log.txt, starting from line 558, you can see (in order):

• ACTION_START
• Choices
• TAG_CHANGE
• Choices
• TAG_CHANGE
• ACTION_START
• ACTION_END
• etc.

The XML present in the test data however doesn't nest these elements, and produces:

<Action entity="1" index="-1" type="5">
    <TagChange entity="3" tag="305" value="1"/>
    <Choices entity="1" max="3" min="0" playerID="1" source="1" type="MULLIGAN">
        <Choice entity="8" index="0"/>
        <Choice entity="16" index="1"/>
        <Choice entity="33" index="2"/>
    </Choices>
</Action>
<TagChange entity="2" tag="305" value="1"/>
<Choices entity="2" max="5" min="0" playerID="2" source="1" type="MULLIGAN">
    <Choice entity="54" index="0"/>
    <Choice entity="49" index="1"/>
    <Choice entity="55" index="2"/>
    <Choice entity="43" index="3"/>
    <Choice entity="68" index="4"/>
</Choices>

while I would expect something like

<Action entity="1" index="-1" target="0" ts="01:41:27.9112918" type="5">
    <TagChange entity="2" tag="305" value="1"/>
    <Choices entity="1" max="3" min="0" playerID="1" source="1" taskList="0" ts="01:41:27.9312929" type="1">
        <Choice entity="8" index="0"/>
        <Choice entity="16" index="1"/>
        <Choice entity="33" index="2"/>
    </Choices>
    <TagChange entity="3" tag="305" value="1"/>
    <Choices entity="2" max="5" min="0" playerID="2" source="1" taskList="0" ts="01:41:28.0212980" type="1">
        <Choice entity="54" index="0"/>
        <Choice entity="49" index="1"/>
        <Choice entity="55" index="2"/>
        <Choice entity="43" index="3"/>
        <Choice entity="68" index="4"/>
    </Choices>
    <TagChange entity="2" tag="305" value="2"/>
    <Action entity="2" index="-1" target="0" ts="01:41:47.1423917" type="5">
        <TagChange entity="25" tag="49" value="3"/>
        <TagChange entity="25" tag="263" value="1"/>
        <TagChange entity="8" tag="49" value="2"/>
        <TagChange entity="8" tag="263" value="0"/>
        <TagChange entity="28" tag="49" value="3"/>
        <TagChange entity="28" tag="263" value="2"/>
        <TagChange entity="16" tag="49" value="2"/>
        <TagChange entity="16" tag="263" value="0"/>
        <TagChange entity="2" tag="305" value="3"/>
    </Action>
        ...

Is this the intended behaviour?

Thanks!

Seb

Twould make it even more intuitive when watching a game if arrows appeared between a minion or character making an attack and the intended target of their attack.

Optional but useful: A arrow that displays redirected attacks caused by secrets, certain minions on the board, etc. (Ie; minion A attacks minion B, but then the paladin secret causes the minion to redirect to the summoned 2/1.)

When watching replays, please it possible to mouse over the "?" logo for secrets on the character portrait to see what secrets are in play.

Or better yet, come up with a way to display which secrets are currently in effect so mousing over isn't necessary.

Otherwise it's a small nightmare trying to remember which secrets are currently in play when reviewing games with secret-heavy players.

This fixes DTD validation errors caused by empty options lists, which occur when ending the turn is the only option. The END_TURN option is added with entity = 0 as demanded by the DTD. Exemplary log line: GameState.DebugPrintOptions() - option 0 type=END_TURN mainEntity=

Hey,

In DataHandler.cs, there is:

match = Regexes.ActionHideEntityRegex.Match(data);
if(match.Success)
{
    var rawEntity = match.Groups[1].Value;
    var tagName = match.Groups[2].Value;
    var value = match.Groups[3].Value;
    var entity = Helper.ParseEntity(rawEntity, state);
    var zone = Helper.ParseTag(tagName, value);
    var hideEntity = new HideEntity {Entity = entity, Zone = zone.Value, TimeStamp = timestamp};
    if(state.Node.Type == typeof(Game))
        ((Game)state.Node.Object).Data.Add(hideEntity);
    else if(state.Node.Type == typeof(Action))
        ((Action)state.Node.Object).Data.Add(hideEntity);
    else
        throw new Exception("Invalid node: " + state.Node.Type);
    return;
}

Contrary to all the other processes, there is no call to state.UpdateCurrentNode(typeof(Game), typeof(Action)); before checking the type of the current node. Is this intentional?

The SendChoiceselement we get from GameState.SendChoices is very symmetrical to ChosenEntities (GameState.DebugPrintEntitiesChosen), which we only get from other players. The problem is that we don't get the exactly the same data in each case, so we have to keep them separate for now.

Ideally we should use ChosenEntities for both. But then we lack the choice type.. this would require some changes on Blizzard's side.