Hi!

First of all thank you so much for making this project! It's so far saved me quite a bit of time on my own Godot project.

However, my project requires that the nodes that I'm generating have groups (this is normally done in Godot by manually assigning a node to a group in the inspector). It looks like groups was on your todo-list based on the code comments, so I tried my best to implement them. Implementing these changes locally has allowed me to export nodes with groups.

I'm relatively new to Python development and I wasn't sure how to test my changes, so please let me know if this is an acceptable change, and if it's not I would appreciate some direction to make it so.

As is described in https://peps.python.org/pep-0561/#packaging-type-information

It is possible some other change is needed to make sure it gets bundled properly

I have a pseudo-language that I use in some props of my scene objects, and godot-parser doesn't like escaped strings.

Example from test_parse_files.py on my project: condition = "has_ability(\"djump\")" <x> condition = "has_ability("djump")"

Note that I didn't add the escaping. I just typed has_ability("djump") in the editor, and apparently on save it escapes it.

This one is pretty obvious, but perhaps something to wrap in a friendly "I can't do that Dave" style exception.

I have a .tscn file (text-based) which inherits from a .scn file (binary).

When I open the .tscn file in tree mode, I get an exception.

I suggest that until you start supporting .scn files you catch and re-raise this exception as something akin to "Binary files are not supported yet"

Thanks

c:\users\tom\appdata\local\programs\python\python39\lib\site-packages\godot_parser\tree.py in _load_parent_scene(root, file)
    327 
    328 def _load_parent_scene(root: Node, file: GDFile):
--> 329     parent_file: GDFile = file.load_parent_scene()
    330     parent_tree = Tree.build(parent_file)
    331     # Transfer parent scene's children to this scene

c:\users\tom\appdata\local\programs\python\python39\lib\site-packages\godot_parser\files.py in load_parent_scene(self)
    256                 "Could not find parent scene resource id(%d)" % root.instance
    257             )
--> 258         return GDScene.load(gdpath_to_filepath(self.project_root, parent_res.path))
    259 
    260     @contextmanager

c:\users\tom\appdata\local\programs\python\python39\lib\site-packages\godot_parser\files.py in load(cls, filepath)
    306     def load(cls: Type[GDFileType], filepath: str) -> GDFileType:
    307         with open(filepath, "r") as ifile:
--> 308             file = cls.parse(ifile.read())
    309         file.project_root = find_project_root(filepath)
    310         return file

c:\users\tom\appdata\local\programs\python\python39\lib\encodings\cp1252.py in decode(self, input, final)
     21 class IncrementalDecoder(codecs.IncrementalDecoder):
     22     def decode(self, input, final=False):
---> 23         return codecs.charmap_decode(input,self.errors,decoding_table)[0]
     24 
     25 class StreamWriter(Codec,codecs.StreamWriter):

UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 1848: character maps to <undefined>

Apparently, lists can include a trailing comma (at least lists in the section header).

This is an example, in the section header:

[node name="Pit Water Trigger" type="Area2D" parent="Scene/Trial1/Acid Pit" groups=[
"WaterBody",
]]
visible = false
position = Vector2( -8.50171, -130.333 )
collision_layer = 256
collision_mask = 2147483649
script = ExtResource( 20 )
__meta__ = {
"_edit_group_": true
}

Note how the groups attribute is a list which contains newlines and a trailing separator (a comma). Newlines are not a problem for the parser but the comma was not supported.

This pull request modifies the parser definition to add support for trailing commas in list values.

Some properties can have spaces in their names. In this case Godot quotes them.

This is an example of such situation:

[node name="AnimationPlayer" type="AnimationPlayer" parent="Scene/TestDevel/Zone1/TestAnim"]
autoplay = "Test"
playback_process_mode = 0
anims/Test = SubResource( 66 )
"anims/Test 2" = SubResource( 67 )

This pull request modifies the parser definition to add support quoted keys.

Parsing small scenes works really well.

And, I have this 50k lines, 67mb scene file converted from an .escn file imported from blender. I wanted to shrink its size from the source. I wrote some regex-based scripts and it was neither elegant nor convinent, then I found this parser.

However, It took 11 minutes to parse this 67mb scene. RAM usage increased very slowly and the parsing was using only 6% CPU usage of a Ryzen 2700X.

67mb lines is definitely large, but I think 11 minutes is a bit much. Is it a normal speed with pyparsing or does the script need deeper optimization idk.

City.zip