Added two lines to Message class to support attachments and an Attachment class to represent attachment objects. Attachments to an email are stored in an array (message.attachments). Attachment objects have name and size (kilobytes) properties, and their associated files can be saved to disk using the save() function, which optionally takes a path to save the file to. I updated the README to show capabilities, though you very well might want to represent the information differently.

I decided to write a little email filter to run on my vps and I ran into an interesting problem:

Traceback (most recent call last): File "mailfilter.py", line 19, in mail.read() File "/usr/local/lib/python2.7/dist-packages/gmail-0.0.5-py2.7.egg/gmail/message.py", line 41, in read self.gmail.imap.uid('STORE', self.uid, '+FLAGS', flag) File "/usr/lib/python2.7/imaplib.py", line 760, in uid typ, dat = self._simple_command(name, command, *args) File "/usr/lib/python2.7/imaplib.py", line 1070, in _simple_command return self._command_complete(name, self._command(name, *args)) File "/usr/lib/python2.7/imaplib.py", line 905, in _command_complete raise self.error('%s command error: %s %s' % (name, typ, data)) imaplib.error: UID command error: BAD ['Could not parse command']

https://gist.github.com/anonymous/bd96cbcd768ce9c2647d This is my code.

The problem seems to be that after running the filter once, it works as expected. The unwanted behaviour pops up if you run it multiple times if there are no items left matching the criteria, instead of holding 0 or None emails contains 1 message object, which I checked many times against my actual gmail account is not there. This falls automatically through the len() check and causes problems if you start calling methods on this "fake" message object. With message_id = None and no uid.

Here is what is some of the output

['body', 'delivered_to', 'fr', 'uid', 'thread', 'thread_id', 'cc', 'labels', 'mailbox', 'to', 'flags', 'sent_at', 'message', 'subject', 'message_id', 'gmail'] [None, None, None, '161464', [], None, None, [], <gmail.mailbox.Mailbox instance at 0x1049179e0>, None, [], None, None, None, None, <gmail.gmail.Gmail instance at 0x1049173b0>] <gmail.message.Message instance at 0x10492ee60>

Here is the code I am using... I dont think I am doing anything wrong. logged_in is returning true so it appears I am authenticated.

!/usr/bin/python

from gmail import Gmail import datetime

g = Gmail()

g.login("noybusername","noybpassword") emails = g.inbox().mail(fr="[email protected]") print(g.logged_in) print(emails[0].uid) print(emails[0].fr) for email in emails: print(email.dict.keys()) print(email.dict.values()) print(email)

g.logout()

Hi Charlie,

Cool project!

I quickly went through the code to familiarise myself with it and decided to make some minor changes to improve the overall readability so that it is easier for people to navigate around it. Let me know what you think!

This pull request includes a new exception type to raise when attachment parsing does not work and a hook to ignore attachment parsing entirely as a work-around. There's a little bit of PEP8 cleanup as well. Not sure anyone else will actually need this but I figured I'd make it available as a result of running into an exception like the following:

  File "/path/venv/lib/python2.7/site-packages/gmail/mailbox.py", line 74, in mail
    self.messages.update(self.gmail.fetch_multiple_messages(messages_dict))
  File "/path/venv/lib/python2.7/site-packages/gmail/gmail.py", line 156, in fetch_multiple_messages
    messages[uid].parse(raw_message)
  File "/path/venv/lib/python2.7/site-packages/gmail/message.py", line 173, in parse
    if not isinstance(attachment, basestring) and attachment.get('Content-Disposition') is not None
  File "/path/venv/lib/python2.7/site-packages/gmail/message.py", line 223, in __init__
    self.size = int(round(len(self.payload)/1000.0))
TypeError: object of type 'NoneType' has no len()

I am trying to retrieve read/unread status of mail using emails[0].is_read. It returns ">" for all emails whether its read or unread.

Also tried with emails[0].read. But it also returns ">".

Please help

fix a bug when content of attachment is None (strange bug with email forward)

I should fix the problem by allowing attachments like this one but I ddon't have time right now

--004_AED2489C945A0F43BAB44072BC97FA211A64EFECTOREXCHANGE01co Content-Type: message/rfc822 Content-Disposition: attachment; creation-date="Thu, 20 Mar 2014 19:26:43 GMT"; modification-date="Thu, 20 Mar 2014 19:26:43 GMT" ....

I wanted the ability to fetch a full thread as it appears in the gmail interface (both sent and received), so I added fetch_thread() for a message. It caches the messages in the appropriate Mailbox.messages as well. It only works if called on a message that was sent to the user, not on a sent message. If there's interest I can make it more flexible. Perhaps a Thread object that wraps all emails? Maybe that's too much.

On another note, the idea of there being a current_mailbox for a Gmail object caused problems for me - that state can change in unpredictable ways. It seems to me that any function that involves a mailbox should somehow take an arg for it rather than change something that's hard to follow. I can make an issue and work on that too if you want.

These are some minor changes to the README so that links use proper markup.

For example, this used to be: Charlie Guo [https://github.com/charlierguo]

Now looks like: Charlie Guo

I put your information into the setup.py file, but obviously didn't have your e-mail address. This way you can just do 'python setup.py install', even if you're not going to push to pypi. Could be handy for people trying it out.

This should allow us to login to gmail on machines that use IPv6, by forcing the use of IPv4

See https://blog.zensoftware.co.uk/2016/05/13/gmail-blocking-mdaemon-email-arriving-via-ipv6/

AuthenticationError                       Traceback (most recent call last)
<ipython-input-3-69ade5292074> in <module>()
----> 1 g.login ('**********', '**********')

/home/debdut/Code/workspace/gmail/gmail/gmail.pyc in login(self, username, password)
    104                 self.fetch_mailboxes()
    105         except imaplib.IMAP4.error:
--> 106             raise AuthenticationError
    107 
    108 

AuthenticationError: 

I also got an email that Google is blocking the login. How to fix it? Note: I have replaced my username password with *'s.

unread = g.inbox().mail(unread=True)
print unread[0].body

This works once, but after that the email moves all the emails to All Mails from Inbox and the list becomes empty.