Hi @cobusc ,

This PR fixs how we are adding into URLconf. Instead of django.conf.urls.url() lets show example with django.urls.path() - the new modern way. Also, url() will be deprecated in Django 4.0.

Also, let's show adding AppConfig as dotted path as it is recommended at Django docs. Otherwise we should add default_app_config variable inside __init__.py file.

Hi, first of all I'd like to thank you for creating this package.

I noticed a fix for Django 4 got merged in and version in setup.py was bumped to 1.0.1: https://github.com/cobusc/django-protected-media/blob/acb05009d65763ce5b6246729f1cc2368f44ae7e/setup.py#L12

However, latest version on PyPI is still 1.0.0: https://pypi.org/project/django-protected-media/#history Is this intended?

I wanted to get this into awesome Django but they feel this project is not kept up to date. Could you update it?

Or say here that you welcome others updating the project? This way maybe someone submits a PR.

BASE_DIR is not a mandatory entry in Django's settings.py. Thus, even though one defined PROTECTED_MEDIA_ROOT, an AttributeError exception will be thrown because of protected_media's own settings.py trying to define a default PROTECTED_MEDIA_ROOT using BASE_DIR.

Protected-media's documentation doesn't make it clear BASE_DIR is required as it probably shouldn't be.

If you navigate to: https://travis-ci.org/github/cobusc/django-protected-media

Since June 15th, 2021, the building on travis-ci.org is ceased. Please use travis-ci.com from now on.

travis-ci.com page 404's: https://www.travis-ci.com/cobusc/django-protected-media

It would seem the CI for this project is not running.

As of Nov 2, 2020 Travis CI will no longer be free for FOSS projects.

I would recommend moving to GitHub actions for CI.

I'm getting Nginx 404 Not Found instead of protected media which is image in my case. Kindly asking for a help because I don't understand what I am doing wrong.

In settings.py I have this:

PROTECTED_MEDIA_ROOT = os.path.join(BASE_DIR, 'protected')
PROTECTED_MEDIA_URL = "/protected"
PROTECTED_MEDIA_SERVER = "nginx"  # Defaults to "django"
PROTECTED_MEDIA_LOCATION_PREFIX = "/internal" # Prefix used in nginx config
PROTECTED_MEDIA_AS_DOWNLOADS = False  # Controls inclusion of a Content-Disposition header

In django I have this:

@login_required
def my_media_access(request, media_object, file_relpath):
    # some code to check if access is granted
    if access_granted:
        return protected_view(request, file_relpath, server = PROTECTED_MEDIA_SERVER, as_download = PROTECTED_MEDIA_AS_DOWNLOADS)
    return HttpResponseForbidden('Not authorized to access this media.')

In Nginx configuration I have:

    location /internal {
        internal;
        root /home/myuser/myproject/protected;
    }

So the files are in folder /home/myuser/myproject/protected. Idea is that when you access URL https://example.com/protected/abc/image/4813-image1.png then Django recognizes this path and calls protected_view in django-protected-media.

This are the test results for logged in user which is allowed to see asset:

• opening https://example.com/protected/abc/image/4813-image1.png - 404 Not Found (nginx) which is NOT OK, image should be shown
• opening https://example.com/internal/abc/image/4813-image1.png - 404 Not Found (nginx) which is OK
• opening https://example.com/protected/abc/image/4813-image1_WRONG_PATH.png - Django message that there is no route which is OK

Hi,

I found that '/' is missing for default PROTECTED_MEDIA_URL "/protected/". Otherwise, the URL displayed is not the correct one.

The URL prefix used by protected media

PROTECTED_MEDIA_URL = getattr( settings, "PROTECTED_MEDIA_URL", "protected/" )

Alternatively, user has to define the settings by themselves. PROTECTED_MEDIA_URL = '/protected/'

What was done

• Sorted out the Travis CI pipeline. Added newer versions of Python and Django.
• Explicitly error when PROTECTED_MEDIA_ROOT is not explicitly defined and BASE_DIR (used to compute the default value) is also not defined.
• Added missing trailing "/" in the default value for PROTECTED_MEDIA_URL