When trying to run the examples, all off them fail with:

Traceback (most recent call last): File "demo.py", line 5, in from txredis.protocol import Redis ImportError: cannot import name Redis

Accept nested multi-bulk responses. These can be returned from execute() commands where the transaction includes commands that normally return multi-bulk responses.

Hello gentlemen!

I've been playing around with txRedis, very nice work.

I tried modifying the pubsub example to actually print out the message that was published and found that it didn't work. It seems the message is published before the subscription goes into effect, since the subscribe() api doesn't actually return a deferred that fires when the server responds with the subscription confirmation.

What do you think about this patch?

thanks, dave

* __init__ takes a db parameter that is never
  acted on. 
* Adds functionality so that DB selection takes
  place after authentication if a DB is selected.

The version in the cheeseshop is one year old, and does not handle zsets for instance .. (and doesn't use multi bulk protocol). so not at all making use of all cool redis 2.0 features ..

could you please update it ?? (this is just in order to comfortably use pip install txredis .. but using the git is also doable with pip so this is totally not critical )

When I load my server with ~100 req/sec I see wrong callbacks called in 'self._request_queue.popleft().callback(reply)'. It's a multithreading script. I've spent one week trying to fix it with no success. Any suggestions?

Update: Ooops, win32com threads was not working as I expected, sorry for wrong issue.

Hi! I see exception 'object of type 'int' has no len()' when I use zrangebyscore with withscores set to True. Redis returns emptymultibulk which is "*0\r\n" when there is no results and post_process fail. Thank you.

A tiny patch, but it seems like the original intent was to remove "ERR" from the ResponseError string since this is redundant. Removing ERR in the message is also done in redis-py. The current code is at least peculiar enough to suggest this:

ResponseError(data if data[:4] == 'ERR ' or data) # ??? of course, always data no matter what

Currently in txRedis we use a mix of the old and new protocols. Redis 2.2 has moved to using the new protocol exclusively, so we should move to that accordingly.

The hget function did not work for single key query.

Example: redis.hget('table', 'field')

Expected result: {'field': 'value'}

Actual result: {'d': 'e', 'e': 'l', 'f': 'v', 'i': 'a', 'l': 'u'}

There are small typos in:

• txredis/client.py
• txredis/protocol.py

Fixes:

• Should read synchronization rather than synchrnonization.
• Should read replication rather than replicaiton.
• Should read remove rather than remvoe.
• Should read references rather than refereces.
• Should read pattern rather than patern.
• Should read passed rather than passsed.
• Should read already rather than arleady.
• Should read ordered rather than orderd.

Semi-automated pull request generated by https://github.com/timgates42/meticulous/blob/master/docs/NOTE.md

This branch is compatible with both Python 2.7 and Python 3.5.

I adopt the convention that the Protocol class must accept and emit Unicode strings and is responsible for converting objects to bytes.

The changes to the tests are mostly small compatibility fixes with a few exceptions:

• my redis is truncating floats in the sorting test differently than the test suite expects, so I'm skipping the test; I don't know if it's important to test the precision but this feels like something that Redis has changed
• test_rename_same_src_dest succeeds on my redis install; it looks like renaming to the same name is allowed, now

I propose deleting the rename_same_src_dest test and adopting less stringent tests for the floating point sort test.

Thanks!

txredis 2.4 installed on python3.4 over easy_install3 after starting crossbar router, this error came up.

Traceback (most recent call last): File "/usr/local/lib/python3.4/dist-packages/autobahn/wamp/protocol.py", line 842, in onMessage on_reply = txaio.as_future(endpoint.fn, _invoke_args, *_invoke_kwargs) File "/usr/local/lib/python3.4/dist-packages/txaio/tx.py", line 408, in as_future return maybeDeferred(fun, _args, *_kwargs) File "/usr/local/lib/python3.4/dist-packages/twisted/internet/defer.py", line 150, in maybeDeferred result = f(_args, *_kw) File "/usr/local/lib/python3.4/dist-packages/crossbar/worker/router.py", line 643, in start_router_component create_component = _appsession_loader(config) --- --- File "/usr/local/lib/python3.4/dist-packages/crossbar/worker/init.py", line 58, in _appsession_loader module = importlib.import_module(module_name) File "/usr/lib/python3.4/importlib/init.py", line 109, in import_module return _bootstrap._gcd_import(name[level:], package, level) File "", line 2254, in _gcd_import

File "", line 2237, in _find_and_load

File "", line 2226, in _find_and_load_unlocked

File "", line 1200, in _load_unlocked

File "", line 1129, in _exec

File "", line 1471, in exec_module

File "", line 321, in _call_with_frames_removed

File "/home/www/work/dc/example/crossbar/components/main.py", line 7, in from helpers.util import success File "/home/www/work/dc/example/backend/crossbar/helpers/util.py", line 6, in from txredis.client import RedisClient File "/usr/local/lib/python3.4/dist-packages/txredis-2.4-py3.4.egg/txredis/init.py", line 39, in

builtins.ImportError: No module named 'exceptions'

There is a problem where, after a txredis.client.RedisClient has successfully sent a QUIT command to the Redis server, the server properly tears down the connection, and Twisted properly calls txredis.client.RedisClient.connectionLost, which calls txredis.RedisClient.failRequests, the later of which propagates the twisted.internet.error.ConnectionLost to all requests in its internal queue (txredis.RedisClient._request_queue), without seemingly bothering to check if these requests have already succeeded. This causes the deferred transactions in the internal queue to assume that their overarching RedisClient has a half-terminated TCP connection, causing thousands of errbacks to get propagated for no good reason.

Technically, the ConnectionLost is not really an error, it's just a signal sent from Twisted that the other end tore down the connection. This is precisely what is supposed to happen when you send QUIT, so this is somewhat a design flaw in txredis.

For a piece of software I develop at work, I have fixed this issue by subclassing RedisClient and overriding the connectionLost method as follows:

class MyRedisClient(txredis.client.RedisClient):
    def connectionLost(self, reason):
        trapped = reason.trap(ConnectionLost)
        if trapped:
            log.msg(
                ("Trap prevented ConnectionLost from propagating to "
                 "`RedisClient.failRequests()`. All's well."))
        else:
            super(MyRedisClient, self).connectionLost(reason)

If desired, I can gladly either fork or provide git patches, if you think that this issue merits fixing.

Thanks for creating txredis!

for knowing the original subscribing pattern in the message receive none-Pattern subscription the channel is the pattern permit multiple subcription and retreive original subscription