When flake8 runs check_for_ix, check_for_at, or check_for_iat, it raises AttributeError: 'Name' object has no attribute 'attr'

This seems to indicate that node.value returns a 'Name' object and that node.value.attr should be changed. Not sure if we can follow the pattern for check_for_isnull, etc. because it .ix[], .at[].

Installing pandas-vet with pip or conda on Windows or WSL results in flake8 --version returning

3.7.9 () CPython 3.7.3 on Windows
3.7.9 () CPython 3.8.2 on Linux

Expected behavior

1. Make a new env
2. pip install flake8 pandas-vet==0.2.2

flake8 --version
3.7.9 (flake8-pandas-vet: 0.2.1, mccabe: 0.6.1, pycodestyle: 2.5.0, pyflakes: 2.1.1) CPython 3.7.3 on Windows

To Reproduce Steps to reproduce the behavior:

1. Make a new env
2. pip install flake8 pandas-vet or pip install flake8 pandas-vet==0.2.2
3. flake8 --version
4. See error

Desktop Environment:

• OS: Microsoft Windows [Version 10.0.18363.720]
• Python versions tested: 3.7.3, 3.8.2
• pandas-vet version: 0.2.2

Additional Context Running flake8 -v --version results in:

flake8.plugins.manager    MainProcess     65 INFO     Loading entry-points for "flake8.extension".
flake8.plugins.manager    MainProcess     73 INFO     Loading entry-points for "flake8.report".
flake8.plugins.manager    MainProcess     80 INFO     Loading plugin "F" from entry-point.
flake8.plugins.manager    MainProcess    118 INFO     Loading plugin "pycodestyle.ambiguous_identifier" from entry-point
.
flake8.plugins.manager    MainProcess    123 INFO     Loading plugin "pycodestyle.bare_except" from entry-point.
flake8.plugins.manager    MainProcess    123 INFO     Loading plugin "pycodestyle.blank_lines" from entry-point.
flake8.plugins.manager    MainProcess    123 INFO     Loading plugin "pycodestyle.break_after_binary_operator" from entr
y-point.
flake8.plugins.manager    MainProcess    123 INFO     Loading plugin "pycodestyle.break_before_binary_operator" from ent
ry-point.
flake8.plugins.manager    MainProcess    123 INFO     Loading plugin "pycodestyle.comparison_negative" from entry-point.
flake8.plugins.manager    MainProcess    124 INFO     Loading plugin "pycodestyle.comparison_to_singleton" from entry-po
int.
flake8.plugins.manager    MainProcess    124 INFO     Loading plugin "pycodestyle.comparison_type" from entry-point.
flake8.plugins.manager    MainProcess    124 INFO     Loading plugin "pycodestyle.compound_statements" from entry-point.
flake8.plugins.manager    MainProcess    124 INFO     Loading plugin "pycodestyle.continued_indentation" from entry-poin
t.
flake8.plugins.manager    MainProcess    124 INFO     Loading plugin "pycodestyle.explicit_line_join" from entry-point.
flake8.plugins.manager    MainProcess    124 INFO     Loading plugin "pycodestyle.extraneous_whitespace" from entry-poin
t.
flake8.plugins.manager    MainProcess    125 INFO     Loading plugin "pycodestyle.imports_on_separate_lines" from entry-
point.
flake8.plugins.manager    MainProcess    125 INFO     Loading plugin "pycodestyle.indentation" from entry-point.
flake8.plugins.manager    MainProcess    125 INFO     Loading plugin "pycodestyle.maximum_doc_length" from entry-point.
flake8.plugins.manager    MainProcess    125 INFO     Loading plugin "pycodestyle.maximum_line_length" from entry-point.
flake8.plugins.manager    MainProcess    125 INFO     Loading plugin "pycodestyle.missing_whitespace" from entry-point.
flake8.plugins.manager    MainProcess    126 INFO     Loading plugin "pycodestyle.missing_whitespace_after_import_keywor
d" from entry-point.
flake8.plugins.manager    MainProcess    126 INFO     Loading plugin "pycodestyle.missing_whitespace_around_operator" fr
om entry-point.
flake8.plugins.manager    MainProcess    126 INFO     Loading plugin "pycodestyle.module_imports_on_top_of_file" from en
try-point.
flake8.plugins.manager    MainProcess    126 INFO     Loading plugin "pycodestyle.python_3000_async_await_keywords" from
 entry-point.
flake8.plugins.manager    MainProcess    126 INFO     Loading plugin "pycodestyle.python_3000_backticks" from entry-poin
t.
flake8.plugins.manager    MainProcess    127 INFO     Loading plugin "pycodestyle.python_3000_has_key" from entry-point.
flake8.plugins.manager    MainProcess    127 INFO     Loading plugin "pycodestyle.python_3000_invalid_escape_sequence" f
rom entry-point.
flake8.plugins.manager    MainProcess    127 INFO     Loading plugin "pycodestyle.python_3000_not_equal" from entry-poin
t.
flake8.plugins.manager    MainProcess    127 INFO     Loading plugin "pycodestyle.python_3000_raise_comma" from entry-po
int.
flake8.plugins.manager    MainProcess    127 INFO     Loading plugin "pycodestyle.tabs_obsolete" from entry-point.
flake8.plugins.manager    MainProcess    128 INFO     Loading plugin "pycodestyle.tabs_or_spaces" from entry-point.
flake8.plugins.manager    MainProcess    128 INFO     Loading plugin "pycodestyle.trailing_blank_lines" from entry-point
.
flake8.plugins.manager    MainProcess    128 INFO     Loading plugin "pycodestyle.trailing_whitespace" from entry-point.
flake8.plugins.manager    MainProcess    128 INFO     Loading plugin "pycodestyle.whitespace_around_comma" from entry-po
int.
flake8.plugins.manager    MainProcess    129 INFO     Loading plugin "pycodestyle.whitespace_around_keywords" from entry
-point.
flake8.plugins.manager    MainProcess    129 INFO     Loading plugin "pycodestyle.whitespace_around_named_parameter_equa
ls" from entry-point.
flake8.plugins.manager    MainProcess    129 INFO     Loading plugin "pycodestyle.whitespace_around_operator" from entry
-point.
flake8.plugins.manager    MainProcess    129 INFO     Loading plugin "pycodestyle.whitespace_before_comment" from entry-
point.
flake8.plugins.manager    MainProcess    129 INFO     Loading plugin "pycodestyle.whitespace_before_parameters" from ent
ry-point.
flake8.plugins.manager    MainProcess    130 INFO     Loading plugin "C90" from entry-point.
flake8.plugins.manager    MainProcess    131 INFO     Loading plugin "PD" from entry-point.
flake8.plugins.manager    MainProcess    147 INFO     Loading plugin "default" from entry-point.
flake8.plugins.manager    MainProcess    151 INFO     Loading plugin "pylint" from entry-point.
flake8.plugins.manager    MainProcess    151 INFO     Loading plugin "quiet-filename" from entry-point.
flake8.plugins.manager    MainProcess    151 INFO     Loading plugin "quiet-nothing" from entry-point.

In order to facilitate the maintenance of the change log, it will be good if we ask PRs to be structured like updates to the change log. This is part of my ongoing effort to make project management and community contributions as straightforward as possible.

Developing the check functions for each linter errors requires exploration of the AST nodes to determine the corresponding attributes to be compared against the valid code patterns. This presents a barrier to quickly implementing new linter checks that could be reduced if there were a tool that returns the appropriate AST node attributes for a specified pattern.

The envisioned solution might utilize the following form:

attributes = ast_explore(code_signature)

where code_signature is a string representing the code pattern of interest, and attributes is a string (or list of strings) representing the composed attributes for the corresponding AST node. This string could then be appended to the AST node in the check functions:

if node.<attribute_string> == <test_condition>:

or

for attribute in node.<attribute_string>:

Check for use of pd.merge function. Preferred is .merge method. Even pandas docs use .merge for the documentation of pd.merge! See flashcard.

Give error message:

Use '.merge' method instead of 'pd.merge' function. They have equivalent functionality.

fixes https://github.com/deppen8/pandas-vet/issues/106

The implementation consists of two steps:

1. We have to keep a reference of the Call node before visiting children
2. When visiting an Attribute, add some checks to make sure we raise only if we did not come from a .values() (Call)

Is there a good reason to prefer .loc over .at when you need to get a single value?

We use .at over .loc in our codebase when we want to signal to other developers that we intend to get a single value, as opposed to a Series or DataFrame.

The warning seems to assume the developer picked .at for speed, while their intention is more likely to have picked it for correctness and clarity.

There doesn't seem to be any way to contribute to the wiki, but I thought it would be useful to include my comments from Issue #33 for exploring the AST during development.

I don't know how the page references and linking work within the markdown documents. I created a separate markdown file, and tried to link to this from the wiki home page.

These functions now check the type of node.value. node.value can be either a Name or Attribute, which do not have matching attributes. Before you can check whether it matches the desired pattern (i.e., ix, at, iat), you need to figure out if you are working with a Name or Attribute.

If node.value is ast.Name, use node.value.id.

If node.value is ast.Attribute, use node.value.attr.

Closes #44

Preferred use of binary operators is recommended.

I used loops in both the check and test functions to minimize repetition of the code, so there are not individual test results for each operator or method.

I expect some trivial merge conflicts compared to the 'array' pull request, since code in this PR does not include the added docstrings from that previous PR.

Closes #6

Check for .pivot and .unstack methods. See flashcard. Give error message:

'.pivot' and '.unstack' functionality can be achieved with just '.pivot_table'

Is your feature request related to a problem? Please describe. I really like this project, and I want to contribute, but there are some roadblocks in the way. Getting the project setup on my local machine had some issues:

• Python 3.10 not supported. That is my default python, so it would be helpful if it was supported
• Outdated dependencies. pytest and black are both pinned to old version that have issues. I suggest moving to poetry for dependecy handling instead
• manual style checks. I'd much rather have a predefined pre-commit check to run black, flake8, pytest etc, instead of finding the exact commands in the readme before committing.

This is not meant to be one big complaint. This project is really useful to me, so thanks for building it.

Please complete this template for all pull requests to pandas-vet. It will help us to review the PR faster. Also, this format is based on Keep a Changelog and will help keep the change log accurate and up-to-date.

Related issues

• #113

This PR does the following:

Added

• None

Changed

• Change PD011 recommendation from .array and .to_array() to .to_numpy()

Deprecated

• None

Removed

• None

Fixed

• None

Security

• None

Closes #113

Describe the bug for PD011 should the suggestion instead be to_numpy() instead of to_array() (given suggestion in warnings of https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.values.html)? Perhaps I am wrong on this but just wanted to bring up or least get clarification on potential difference

Describe the bug raised exception

To Reproduce Steps to reproduce the behavior:

Have the following code in a file

def some_function(dataFrame, in_place=False):
    return dataFrame.drop([], inplace=in_place)

Expected behavior Allow flake8 to report violations and not throw exceptions.

Screenshots

Additional context

bash-5.1# cat /usr/lib/python3.9/site-packages/pandas_vet/version.py 
__version__ = "0.2.2"

This is running on a docker container based on alpine:3.14.1. Same results obtained on a mac.

Things work if we do not provide a variable:

def some_function(dataFrame, in_place=False):
    return dataFrame.drop([], inplace=False)

I have recently started adopting JupyterBook for documenting projects and I love it. It is great for adding the things that I would like to add to pandas-vet like tutorials and mixing Markdown and reST Sphinx docs.

It also has nice pre-defined GitHub Actions for building the docs and putting them in a branch for GitHub Pages.

This would replace issue #70 and #87