The feature makes it possible to purchase multiple wares in one go. E.g.:

sts -u username øl+monster+panta:2

(Results in purchase of one monster and beer + 2x pant a)

Notes:

• If the count is not specified for a ware it will default to the value given by the -c flag or 1 (in that order)
  e.g.: sts -u username -c 2 monster+panta will purchase 2x monster and panta
• If a unknown shorthand is used the entire purchase will be canceled (not just that of the unknown item)

Currently I'm trying to create a rofi script for STS. In this regard, I would like to use the get-wares-functionality. However this function is tightly bound to the main python file. I suggest splitting the functionality into the following files:

• stslib.py - A general library containing interaction with stregsystemet. So: test_user, get_wares, get_history, sale and possibly get_qr
• sts.py - The current implemention, but calling the library instead
• sts-strandvejen.py - The special case of the strandvejen

And here is where I would be able to create sts-rofi.py which interacts with rofi.

This split does however come with a drawback: The update script needs to support updating multiple files.

Currently it is only a suggestion. I don't know if there is even any support a change like this.

This pull request adds a plugin system to STS, such that the user can customise their sts to their liking

Customisation includes:

• Adding new shorthands
• Adding new commands
• Add new functionality

Commits in pr:

• Added template plugins
• Added plugin system
• Updated gitignore

• Fixed issue where shorthands would not be parsed in strandvejen
• Add dateutils as a nix dependency
• Stop config crashing when no config file is present
• Fixed accidental dependency
• Removed import statement

STS writes the following when 'plugin_dir' is not set: STS now supports plugins. Add "plugin_dir=~/.sts_plugins/" to your .sts file

However, (on my system at least) the expansion of home (~) does not work and I have to give it a FQN (/home/$user/.config/sts/plugins/etc).

Having some way to supress the "heyo, we got plugins" message without having to setup plugins would be nice, since you can know of the support but choose not to use it.

Running the setup -s process creates a .sts file containing two [sts], resulting in an error the next time you run "sts".

Terminal:

sts -s
Hvad er dit bruger navn? <Username>

~/.sts

[sts]
[sts]
<username>

To fix the problem i removed one instance of [sts] in the .sts file.

~/.sts

- [sts]
  [sts]
  <username>

Running the Stregsystem CLI on Windows results in the following error: NameError: name 'is_windows_terminal' is not defined

This can be fixed if the reference to is_windows_terminal is replaced with is_windows. I imagine that short-circuiting prevents the error from being found from a Linux system.

ctrl+d in most shells issue an EOF character, which is a relatively universal way of ending a shell or other text input (like the buy menu in sts). We should just gracefully handle this character and exit.

Id> Traceback (most recent call last):
File "/bin/sts", line 416, in <module>
    main()
File "/bin/sts", line 400, in main
    user_buy(args.user)
File "/bin/sts", line 294, in user_buy
    item, count = get_item([x[0] for x in wares])
File "/bin/sts", line 260, in get_item
    item_id = input('Id> ')
    
EOFError

Adding the default.nix file makes it super easy to add sts to any system running the nix package manager. It also means development of sts only requires running nix-shell to have the dependencies installed.

It would be nice if the HTML tags used to highlight products would removed from the CLI as it just looks bad (Such as <h1>). Alternatively the products with html tags could also be used to change the formatting of products with these tags.

Currently, not many people know about the .sts files. It would be beneficial for the user to be able to generate it automatically, with correct formatting.

As a user I want to have a setup flag that generates a .sts file So it is placed in the right directory

When creating a new installation of STS, running the -s flag produces the following stacktrace:

Traceback (most recent call last):
  File "/opt/homebrew/bin/sts", line 1032, in <module>
    sts.load()
  File "/opt/homebrew/bin/sts", line 643, in load
    self._argument_handler.handle_stopping(self, self._user_manager, self._request_handler)
  File "/opt/homebrew/bin/sts", line 296, in handle_stopping
    self.setup_sts(user_manager, request_handler, Configuration())
  File "/opt/homebrew/bin/sts", line 395, in setup_sts
    configuration.write()
  File "/opt/homebrew/bin/sts", line 162, in write
    with open(paths[0], 'w') as configfile:
IndexError: list index out of range

This has been tested on MacOS

For new users who are unfamiliar with the code, they might want to explore what the tool can do.

I would suggest adding a --dry-run option for the script. Example usage:

$ sts classic --dry-run
Username 'abba' would purchase 1x 14 Øl(Grøn/Classic/Rød/Rå) (excl. pant) for 6.67 kr

Another example:

$ sts -u johannes 1837 --dry-run
Username 'johannes' would purchase 1x 1837 Monster / cola energy (excl. pant) for 12.10 kr

More reading on general usage of --dry-run here