Tests are failing (reproduced on 1.0.0 and master) with :

========================================== FAILURES ===========================================
______________________________ test_delete_job_reserved_by_other ______________________________

    def wrapper() -> None:
        cmd = ('beanstalkd', '-l', '127.0.0.1', '-p', str(PORT))
        with subprocess.Popen(cmd) as beanstalkd:
            time.sleep(0.1)
            try:
                with Client(port=PORT, **kwargs) as c:
>                   test(c)

tests.py:27: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
tests.py:360: in test_delete_job_reserved_by_other
    c.delete(job)
greenstalk.py:253: in delete
    self._send_cmd(b'delete %d' % _to_id(job), b'DELETED')
greenstalk.py:172: in _send_cmd
    return _parse_response(line, expected)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

line = b'NOT_FOUND', expected = b'DELETED'

    def _parse_response(line: bytes, expected: bytes) -> List[bytes]:
        if not line:
            raise ConnectionError("Unexpected EOF")
    
        assert line[-2:] == b'\r\n'
        line = line[:-2]
    
        status, *values = line.split()
    
        if status == expected:
            return values
    
        if status in ERROR_RESPONSES:
>           raise ERROR_RESPONSES[status](values)
E           greenstalk.NotFoundError: []

greenstalk.py:396: NotFoundError
============================ 1 failed, 35 passed in 11.09 seconds =============================

I guess the other job must be deleted by its owner, so here is a patch for it.

I can't help but think I'm missing something obvious, but I can't for the life of me get reserve_job working. Using the basic code below to reserve a job ID I know exists and is available in the watched tube:

import greenstalk
client = greenstalk.Client(('192.168.1.2', 11300), watch='testtube')
client.reserve_job(1)

I get a BadFormatError which the documentation suggests shouldn't be hit unless something is amiss in the library.

Traceback (most recent call last):
  File "/Users/ropetin/greenstalk/./testgreen.py", line 3, in <module>
    client.reserve_job(1)
  File "/Users/ropetin/.local/share/virtualenvs/greenstalk-evfV_dNi/lib/python3.9/site-packages/greenstalk.py", line 261, in reserve_job
    return self._job_cmd(b'reserve-job %d' % id, b'RESERVED')
  File "/Users/ropetin/.local/share/virtualenvs/greenstalk-evfV_dNi/lib/python3.9/site-packages/greenstalk.py", line 187, in _job_cmd
    id, size = (int(n) for n in self._send_cmd(cmd, expected))
  File "/Users/ropetin/.local/share/virtualenvs/greenstalk-evfV_dNi/lib/python3.9/site-packages/greenstalk.py", line 176, in _send_cmd
    return _parse_response(line, expected)
  File "/Users/ropetin/.local/share/virtualenvs/greenstalk-evfV_dNi/lib/python3.9/site-packages/greenstalk.py", line 411, in _parse_response
    raise ERROR_RESPONSES[status](values)
greenstalk.BadFormatError: []

This adds the destructor to the client to clean up connections.

Without it, unittest may return errors:

/usr/lib/python3.6/socket.py:657: ResourceWarning: unclosed <socket.socket fd=15, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('127.0.0.1', 42328), raddr=('127.0.0.1', 11300)>
  self._sock = None

After installing this module (version 0.5.0) from PyPI on Debian Stretch, I got the following error:

>>> import greenstalk
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/user/programming/queue-test/venv/lib/python3.4/site-packages/greenstalk.py", line 2, in <module>
    from typing import Any, BinaryIO, Dict, Iterable, List, Optional, Tuple, Union
ImportError: No module named 'typing'

After installing the typing module (at version 3.6.1) it worked fine.

Most of the usage could be inferred via beanstalkd. But the encoding control needs more documents.

sample

It is controled by the encoding of Client.__init__().

When encoding is not None, the input of Client.put() should be str, and the output of Client.reserve() would be str too. Consistent encoding for both producer and consumer is neccessary.

When encoding is None, the input of Client.put() should be bytes, and the output of Client.reserve() would be bytes too. Consistent encoding (None) for both producer and consumer is neccessary.

Behaviours under other settings are undefined.

I've been looking for a beanstalkd python engine, and yours seems to be the only one with Python 3.5+ support. However I don't really know how to use it due to the lack of documentation. If you could spin up some documentation on how to set up a basic implementation of it I'd greatly appreciate it. Especially because then I could use it, and possibly, contribute

Edit: I've been reading through the source code, and I understand how it works now. However having some documentation would still be very useful

Hey, I've been working on a PR to run test suites of beanstalkd clients on pushes to the beanstalkd source code. (The PR is not yet merged: https://github.com/beanstalkd/beanstalkd/pull/614)

I'm posting this here since greenstalk tests will fail as soon as a new beanstalkd version is released:

https://github.com/SamMousa/beanstalkd/runs/4712188954?check_suite_focus=true