Resolves issue #25

TODO

• [x] Write a few tests
• [x] Get passing on CircleCI
• [x] Get passing using Python 3
• [x] Conditional imports (Python 3 wont have future)
• [x] TRIED!! Add super() overrides to some __init__ more simply
• [x] Fix str/unicode problem

Testing a (single-threaded) script of mine I got blacklisted( 2 times!!)

Did not make any call from the web interface. Just run the program and went to sleep. (No API calls in the previous hours either). All the requests went through the baseriotapi.

I don't think the problem is related to https://github.com/robrua/cassiopeia/pull/14 , as my program is not multi thread and thus there can not happen the race condition.

At a first glance I can not spot the problem, but I'm not really an export in python threading.

Hello,

I am coming back to work with Cass since the Cass 3.0/Riot v5 update.

Previously I was able to make a call in the following fashion to get every match for a particular summoner

summoner = cass.get_summoner(name=summoner_name, region="NA")
total_games = len(summoner.match_history)

For some reason now I only get 20 matches back regardless of settings. Documentation seems to still support that it should return all matches and not just the latest 20, but maybe I'm missing something?

Good morning,

I tried to use your library to get some information on base stats champions and I had trouble accessing these informations :+1:

• 'StatsData' object has no attribute 'criticalStrikeChance'
• 'StatsData' object has no attribute 'attackSpeedOffset'
• 'StatsData' object has no attribute 'attackDamage'

The code I used was like this :

champions = cass.get_champions() champions[0].stats.attack_damage champions[0].stats.critical_strike_chance champions[0].stats.attack_speed

I didn't try for the per_level of each but I guess the same issue can exist too.

Thanks for your help !

import os

import cassiopeia as cass

cass.set_riot_api_key(os.getenv("RIOT_API_KEY"))

s = cass.get_summoner(name="é", region="EUW")
s.exists

Outputs Making call: https://euw1.api.riotgames.com/lol/summoner/v4/summoners/by-name/\xc3\xa9

Then fails with UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 65: ordinal not in range(128)

I believe that the problem is this line: url = "https://{platform}.api.riotgames.com/lol/summoner/v4/summoners/by-name/{name}".format(platform=query["platform"].value.lower(), name=query["name"].replace(" ", "")).encode("utf-8").

Removing the final .encode("utf-8") fixes the problem for me. I was surprised by the encode since the other urls aren't encoded at this stage and I would expect requests or urllib to handle the encoding.

This PR adds the ability (disabled by default) of tracking the requests which are made.

This allows users of the library to track of the usage of their limit, allowing to better investigate performances and efficiency of their code.

I find this fundamental as I try a different architectural approach for my library, to be able to compare if I'm effectively improving the performances or not.

This would make debugging issues like #16 a lot easier as well.

Accept one PR, get one fix for free: fixed a typo in the documentation

#Participantstats item list position not respected

#Match.py

@lazy_property
    @load_match_on_attributeerror
    def items(self) -> List[Item]:
        ids = [self._data[ParticipantStatsData].item0,
               self._data[ParticipantStatsData].item1,
               self._data[ParticipantStatsData].item2,
               self._data[ParticipantStatsData].item3,
               self._data[ParticipantStatsData].item4,
               self._data[ParticipantStatsData].item5,
               self._data[ParticipantStatsData].item6
        ]
        version = _choose_staticdata_version(self.__match)
        return SearchableList([Item(id=id, version=version, region=self.__match.region) for id in ids if id])

Currently the list will only contain items that exist. It would be useful to have the position of each item preserved as well (eg. to see a relationship between active items and key binds).

I can think of 2 ways of solving this:

1. Add properties for item0-6 to the stats object
2. Add empty items to the list to let it contain everything (or at least an option to with a param).

Hello!

Background: Kinda-ish new to Python, and really new to rate limits/calls.

I'm running a code where I'm pulling all Master tier matches from 4 October. I'm using the code you've kindly provided "pull_masters_tier.py" as a base. To make sure things are running smoothly, I have the line "print("Got {0}".format(match))" to show me that it is gathering matches correctly. However, I'm getting a lot of "SERVICE 429." It looks something like this as the script is running: Got Match #2310443223 SERVICE 429 SERVICE 429 Got Match #2310385404 Got Match #2310326909 Got Match #2310279651 Got Match #2310264967 Got Match #2310198579 Got Match #2310203223 Got Match #2309999296 SERVICE 429 SERVICE 429 Got Match #2309988823 Got Match #2309994894 Got Match #2309974510 SERVICE 429 SERVICE 429 SERVICE 429 SERVICE 429

Is this related to my rate limit? I don't want to get blacklisted and need to know if things are going alright. The data is getting saved to a file nicely, so that is alright. But I'm working on a very large project with this data and will need to gather data a LOT in the near future.

Sorry for the noob question and thank you in advance!

Hey guys,

I spent half an hour to understand an error happened when I used Cass. Firstly you can try this query, and will find a match_id '2405929288':

https://na.api.pvp.net/api/lol/na/v2.2/matchlist/by-summoner/73099728?rankedQueues=RANKED_SOLO_5x5&seasons=PRESEASON2016&api_key=XXX

Then you try to get the details of this match, and it will return 404, which means even if we can find a match_id in one match list, we are not 100% sure it has record from the match method:

https://na.api.pvp.net/api/lol/na/v2.2/match/2405929288?includeTimeline=0&api_key=XXX

{
    "status": {
        "message": "Not Found",
        "status_code": 404
    }
}

Because of this, we may get an None when we use match = riotapi.get_match(mf) in Cass. Right now I choose to use if match is None to avoid this (can not use '==' because Match.eq use Match.id).

Update: And then I found the region of this match is 'EUW', which means the region setting is useless?

Update 2: I reconsidered this problem, and found that if Cass. returned 404 correctly, there should not be this problem. So I think the exception part of Cass. should be checked.

So, I'm trying to work through this, form your example match.py code you have a list of p = match.participants[summoner]. So if I wanted the stats of these participants wouldn't it just be p = match.participantstats[summoner]? That doesn't run and I'm unsure of why.

Also thanks for your work so far!

I set begin_time, but cass makes a bunch of calls like: Making call: https://na1.api.riotgames.com/lol/match/v3/matchlists/by-account/#########?beginIndex=0&endIndex=100 Making call: https://na1.api.riotgames.com/lol/match/v3/matchlists/by-account/#########?beginIndex=100&endIndex=200 Making call: https://na1.api.riotgames.com/lol/match/v3/matchlists/by-account/#########?beginIndex=200&endIndex=300

And only then it filters needed matches. So there are lots of unnecessary API calls.

A new example was created to showcase match statistics, please see examples/match_statistics.py

Adjusted participants method in Match class to properly hint a SearchableList, see issue:

https://github.com/meraki-analytics/cassiopeia/issues/431#issue-1474219230

Accessing a ParticipantState in a CumulativeTimeline object (i.e. at a particular timestamp) doesn't fetch all the info available by the API.

For example, there is no attribute champion stats with ability haste, ability power, etc ...

This is however available on Riot's API:

In the example file: https://github.com/meraki-analytics/cassiopeia/blob/master/examples/timeline.py, we do:

    summoner = Summoner(name=name, region=region)

    match_history = summoner.match_history
    match = match_history[0]
    p = match.participants[summoner]

match.participants is supposed to be a List[Participant] (or a SearchableListmore precisely), but the type-checker detects an unexpected type when feeding a Summoner to it:

In match.py:

The undo function is defined by the following script.

def undo(self, event: Event): assert event.after_id == 0 or event.before_id == 0 item_id = event.before_id or event.after_id prev = None while prev is None or prev.item_id != item_id: prev = self._events.pop() if prev.type == "ITEM_PURCHASED": self.destroy(prev.item_id) elif prev.type == "ITEM_DESTROYED": self.add(prev.item_id) elif prev.type == "ITEM_SOLD": self.add(prev.item_id) else: raise TypeError(f"Unexpected event type {prev.type}")

The event of synthetic an item is down by destroying the previous item first and then purchasing a new item. If an undo event happens to this item, the item will be destroyed directly. However, the correct undo of synthetic is disassembled this item.

There is currently no new release on this repo since v4.0.5

This doesn't really matter so to speak, but it's a bit confusing when looking at the releases on pypi where currently the latest release is 5.0.1

Can it be possible to add the tags also in the repo, this way I can easily determine if a bug was fixed between latest release and master.

First I get the match history for a summoner. Then on the first match I get an exception when I call match.load():

Traceback (most recent call last):
  File "C:\Users\Patrick\code\LeagueStats\lol.py", line 28, in <module>
    main(sys.argv)
  File "C:\Users\Patrick\code\LeagueStats\lol.py", line 24, in main
    command.run(argv[2:])
  File "C:\Users\Patrick\code\LeagueStats\lol\command.py", line 93, in run
    self._run_impl(argv)
  File "C:\Users\Patrick\code\LeagueStats\lol\commands\update_matches.py", line 43, in _run_impl
    match_data = match.load().to_dict()
  File "C:\Users\Patrick\AppData\Roaming\Python\Python39\site-packages\cassiopeia\core\common.py", line 226, in load
    self.__load__()
  File "C:\Users\Patrick\AppData\Roaming\Python\Python39\site-packages\cassiopeia\core\common.py", line 239, in __load__
    self.__load__(group)
  File "C:\Users\Patrick\AppData\Roaming\Python\Python39\site-packages\cassiopeia\core\common.py", line 246, in __load__
    data = configuration.settings.pipeline.get(type=self._load_types[load_group], query=query)
  File "C:\Users\Patrick\AppData\Roaming\Python\Python39\site-packages\datapipelines\pipelines.py", line 459, in get
    return handler.get(query, context)
  File "C:\Users\Patrick\AppData\Roaming\Python\Python39\site-packages\datapipelines\pipelines.py", line 185, in get
    result = self._source.get(self._source_type, deepcopy(query), context)
  File "C:\Users\Patrick\AppData\Roaming\Python\Python39\site-packages\datapipelines\sources.py", line 120, in get
    return source.get(type, deepcopy(query), context)
  File "C:\Users\Patrick\AppData\Roaming\Python\Python39\site-packages\datapipelines\sources.py", line 69, in wrapper
    return call(self, query, context=context)
  File "C:\Users\Patrick\AppData\Roaming\Python\Python39\site-packages\datapipelines\queries.py", line 325, in wrapped
    validator(query)
  File "C:\Users\Patrick\AppData\Roaming\Python\Python39\site-packages\datapipelines\queries.py", line 209, in __call__
    return self._root.evaluate(query, context)
  File "C:\Users\Patrick\AppData\Roaming\Python\Python39\site-packages\datapipelines\queries.py", line 60, in evaluate
    child.evaluate(query, context)
  File "C:\Users\Patrick\AppData\Roaming\Python\Python39\site-packages\datapipelines\queries.py", line 198, in evaluate
    self.child.evaluate(query, context)
  File "C:\Users\Patrick\AppData\Roaming\Python\Python39\site-packages\datapipelines\queries.py", line 173, in evaluate
    raise WrongValueTypeError("{key} must be of type {type} in query! Got {badtype}.".format(key=self.key, type=self, badtype=type(value)))
ValueError: invalid literal for int() with base 10: 'NA1_4055198406'

When I remove

    "SimpleKVDiskStore": {
      "package": "cassiopeia_diskstore",
      "path": "D:/Data/lol_cache"
    },

from my settings. the call succeeds. I tried clearing my lol cache folder with no success.