Hello and thank you for this project. I am attempting to scan a RouterOS device running version 7.1.3 and I am getting an authentication failure from paramiko. The RouterOS logs say expected msg: 50 got: 5. After some good old fashioned BING searches I saw similar issues opened with an Ansible module (see here: https://github.com/ansible/ansible/issues/55042). I tried a few suggestions mentioned in that thread but did not find luck. Regular ssh user@address -p 2223 works as expected.

python3 main.py -i 172.16.254.1 -p 2223 -u jared+cet1024w -ps PASSWORD
Mikrotik ip address: 172.16.254.1

Traceback (most recent call last):
  File "/Users/jared/routeros-scanner/main.py", line 62, in <module>
    main(args)
  File "/Users/jared/routeros-scanner/main.py", line 28, in main
    ssh_client.connect(hostname=args.ip, port=args.port, username=args.userName, password=args.password)
  File "/usr/local/lib/python3.9/site-packages/paramiko/client.py", line 435, in connect
    self._auth(
  File "/usr/local/lib/python3.9/site-packages/paramiko/client.py", line 766, in _auth
    raise saved_exception
  File "/usr/local/lib/python3.9/site-packages/paramiko/client.py", line 753, in _auth
    self._transport.auth_password(username, password)
  File "/usr/local/lib/python3.9/site-packages/paramiko/transport.py", line 1563, in auth_password
    return self.auth_handler.wait_for_response(my_event)
  File "/usr/local/lib/python3.9/site-packages/paramiko/auth_handler.py", line 244, in wait_for_response
    raise e
paramiko.ssh_exception.AuthenticationException: Authentication failed.`

I'm trying to scan my home router and get this error:

Mikrotik ip address: 192.168.27.1

Traceback (most recent call last):
  File "main.py", line 62, in <module>
    main(args)
  File "main.py", line 31, in main
    res = command.run_ssh(ssh_client)
  File "/home/medusa/routeros-scanner/commands/dns.py", line 16, in run_ssh
    sus_dns, recommendation = self.check_results_ssh(res, enabled)
  File "/home/medusa/routeros-scanner/commands/dns.py", line 27, in check_results_ssh
    if int(item['ttl'].partition('s')[0]) > 200000:
ValueError: invalid literal for int() with base 10: '3d21h23m50'

Device model is RouterBOARD 962UiGS-5HacT2HnT (Mikrotik hAP ac) RouterOS version: 7.1.2 Steps to reproduce:

• run command python3 main.py -i 192.168.1.1 -p 22 -u admin -ps routerpassword

Hi Guys - Thanks for creating this tool! I'm trying to scan our routers, and everyone gives an error similar to below:

Mikrotik ip address: 192.168.0.1

Traceback (most recent call last):
  File "C:\Users\werne\Downloads\routeros-scanner-main\main.py", line 62, in <module>
    main(args)
  File "C:\Users\werne\Downloads\routeros-scanner-main\main.py", line 31, in main
    res = command.run_ssh(ssh_client)
  File "C:\Users\werne\Downloads\routeros-scanner-main\commands\dns.py", line 16, in run_ssh
    sus_dns, recommendation = self.check_results_ssh(res, enabled)
  File "C:\Users\werne\Downloads\routeros-scanner-main\commands\dns.py", line 27, in check_results_ssh
    if int(item['ttl'].partition('s')[0]) > 200000:
ValueError: invalid literal for int() with base 10: '1d'

Traceback (most recent call last): File "C:\apps\routeros-scanner-main\main.py", line 62, in main(args) File "C:\apps\routeros-scanner-main\main.py", line 31, in main res = command.run_ssh(ssh_client) File "C:\apps\routeros-scanner-main\commands\dns.py", line 16, in run_ssh sus_dns, recommendation = self.check_results_ssh(res, enabled) File "C:\apps\routeros-scanner-main\commands\dns.py", line 27, in check_results_ssh if int(item['ttl'].partition('s')[0]) > 200000: ValueError: invalid literal for int() with base 10: '2h11m36'

Greetings, The original script would crash on my mikrotik when it would hit a date format as shown above the "time_str_convert2sec" function. Attached is code that should convert and make the rest of everything else function. Feel free to adjust, re-write or otherwise consume however you'd like. This may be a newer firmware thing.

I ran into this issue when trying to test my router, it seems to be a common issue with paramiko.

The fix was to add look_for_keys=False to main.py:

ssh_client.connect(hostname=args.ip, port=args.port, username=args.userName, password=args.password, look_for_keys=False)

Some people on the internet also suggest to add allow_agent=False

Can you possibly add this to readme-file?

Fixed "invalid literal for int()" error:

1. function get_seconds(ttl) - parses the time string from item["ttl"]
2. item["address"] does not exist, it is the next error. The correct column name is item["data"].

Tests on routeros versions 6.49 and 7.1.3.

For example, the project use paramiko to run command on the server. However, the /ip command is not on the server, why it works？

data = self._ssh_data(sshc, '/ip dns print')

stdin, stdout, stderr = sshc.exec_command(command)

add close ssh client (main.py) change ssh port required to default ssh port 22 (main.py) change The Mikrotik version to RouterOS version (version.py) add example default port ssh (README.md) change ip 1.2.3.4 to default mikrotik ip 192.168.88.1 in executing examples (README.md) change The tested Mikrotik SSH port of Must to Optional in the arguments (README.md) tested in RouterOS v6.49.5 (stable) and v7.1.3 (stable)

for CVE-2017-6297 there is version 6.83.3 (exactly as in CVE description) however there is no such version of RouterOS available. There should be 6.38.3

This PR tries to allow usage of SSH agents for improved security (by removing passwords from the equation) in the SSH handshake process. This also mitigates a related issue, namely the blind trust of the router's SSH fingerprint (enabled by this line - ssh_client.set_missing_host_key_policy(paramiko.AutoAddPolicy())): When using keys, there is very little even an active network attacker can do.

There is one additional flag added that I found necessary when working with Mikrotik routers - failure to negotiate a viable handshake algorithm, as described here: https://forum.mikrotik.com/viewtopic.php?t=157598. I can attest to experiencing this issue firsthand, hence the added flag.

This PR can also provide partial support for the larger feature of SSH key authentication support, as reported here - https://github.com/microsoft/routeros-scanner/issues/25

Bumps paramiko from 2.9.2 to 2.10.1.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.