Close #209

~~Written in a coffee break, so WIP.~~ ~~Currently has to be generated with --fields=n to get the line numbers. So ctags -R --fields=+n~~

• [x] ~~Create ctags for user if file does not exists~~
• [x] Jump does not work
• [x] Write make_entry
• [x] Create display with new table create
• [x] ~~Take another look at how lines numbers get retrieved in fzf, so we don't have to use --fields=+n. I decided to just force having --fields=+n. We could search for the lines but it is kinda unnecessary.~~
• [x] ~~Only --fields=n will not generate the other fields like type but using --fields=+n includes these fields aswell but does not work this current version~~
• [x] Some lines are not displayed. Happens in a file with tabs. has to be fixed by not only splitting with \t and don't split if the line has \^\t

default | hide_filename | show_line | hide_previewer :-------------:|:-------------------------:|:-------------------:|:-----------------: |||

Available options:

only_current_file = true -- default is false, setting this to true will only show tags for the current file
hide_filename = true     -- default is false
show_line = true           -- default is false

Thought it was easier to submit this to show the effect working than describe it.
Making the selection movement easier on the eye by staying full width, not sticking to the content width.

The code I've written is a very quick hack, it just adds spaces to the end of a line to pad it out.
This can probably be done in a much nicer way using virtual text which could allow it to happen on the previewer as well.
I've also had to add an extra 2 to the width for the math to work correctly, still looking at why.

I'm looking into what's going on with the = not being highlighted, don't think it's related to this code.

Plan:

• [x] Implement hierarchy of options that affect window size. (requires fuller testing)
• [x] Remove width_padding and height_padding option from layout strategies.
• [x] Add new option for width and height allowing a table of the form {padding=foo} where foo is one of the other options, and then define width in terms of padding.
• [x] Add documentation for the new method of defining dimensions of the picker.

For more details on the general idea, see the discussion in this issue.

Feedback is very welcome 🙂

Add new options:

• to hide and unhide preview leaving just results and prompt.
• ~~to hide and unhide results and prompt leaving just preview window active. Active preview buffer inherits autocmd for BufLeave and config mappings from prompt which makes it possible to also cycle through previews.~~ This feature will be introduced in another PR

Example key mapping:

require("telescope").setup({
	defaults = {
		mappings = {
			n = {
				["<C-h>"] = actions.toggle_preview,
				["<C-j>"] = actions.toggle_results_and_prompt,
			},
			i = {
				["<C-h>"] = actions.toggle_preview,
				["<C-j>"] = actions.toggle_results_and_prompt,
			},
               }
       }
})

This still require little tweaks for example I am not really sure how should I keep selection ( or if it is currently possible ) for specific entry when hiding preview in vertical layout because the size of results window changes and picker refresh also change the order of results.

This will allow users to delete entries from the picker without closing telescope.

Discussion ref: https://github.com/nvim-telescope/telescope.nvim/pull/803#pullrequestreview-654985978 fixes: #689 fixes: #621 fixes: #672

This function in and of itself will just remove the entry, what I'm proposing next is: Idea: Should we provide a callback parameter which will be called with the removed entry, so that the user or the specific picker can do exactly what needs to be done outside of telescope? Eg., delete the buffer, delete the file, etc.

The selection strategy is temporarily set to "row" as that will help keep the selection in the same position instead of resetting to the top. If there is any other way to achieve this, do suggest :)

Thanks @Conni2461 for helping!

https://user-images.githubusercontent.com/67177269/117562588-a9434e00-b0bd-11eb-9181-275e82cce317.mov

This adds options to the oldfiles finder to make it optionally more useful as a MRU (most recently used) finder.

• include_current_session
  • Normally v:oldfiles only lists files from past vim sessions. This option will include recently accessed files in the current vim session using :buffers! t (the ! bang shows unlisted buffers after they are closed, and the t modifier sorts the list by MRU).
• cwd_only
  • This option filters the results to only show files within the cwd. This makes for a nice project-specific-MRU finder.

At the moment both options don't change default oldfiles finder behaviour, as they are both opt-in. I might argue making include_current_session=true a default, having to restart vim to see new entries populated into v:oldfiles is kind of weird. Either way though, it'd just be nice to have the option!

PS. I know there was an issue/discussion at #433 around MRU pickers that was closed because of the (very cool) frecency extension, but I'd argue that MRU and frecency are different things:

• Frecency = Frequency + Recency
• MRU = Recency only

Here we can post ideas of features, improvement and new pickers.

Later we can further refine an idea and update progress on it or link it to a more detailed "enhancement/feature issue", or even reference the comment in a PR.

Try to leave discussions out of here, but if necessary or your have something in mind post it then mark your replies and mentions as out of scope to keep the Wishlist clean.

[telescope] ^I...ck/packer/start/telescope.nvim/lua/telescope/pickers.lua:410: in function <...ck/packer/start/telescope.nvim/lua/telescope/pickers.lua:364>[telescope] ^I...ck/packer/start/telescope.nvim/lua/telescope/pickers.lua:410: in function <...ck/packer/start/telescope.nvim/lua/telescope/pickers.lua:364>

Closes #307 Closes #627

Look at it here: https://streamable.com/sxi8fz

Continuation of #314

Edit: would be cool if we could somehow show the context of the previewer. Idk how we would do this.

I was reading your port of fzy and one easy improvement over the original fzy that I always do (yes I've ported it multiple times) is to avoid converting the string to lowercase if the needle contains an uppercase character. It improves the results a lot when the user knows there is an uppercase character in there.

• Changes

  • New structure:

    • Overview
      • Installation (add examples for three plugin managers)
      • Dependencies (dependencies sounds better then requirements :D < opinionated)
      • Quick Start (to test telescope)
    • Configuration (contains a quick overview of configuration options and mappings)
    • FAQ (How to questions with answers)
    • API (oh boy needs review, and where most of todos is located. @tjdevries help :D)
    • Media (moved all links and videos here)
    • Recipes (some recipes I thought will be make it easier to configure telescope)

  • Strip previews, I feel telescope preview and screenshot should be located in gallery. It might be good to include a signle preview in the introduction, but I feel it may constrian the expectations of new users, "This what I expect telescope offer", where as having previews only in gallery, "Oh telescope can be configured to look in different ways". :D < opinionated

  • Add faq section, any question answered in issues should be written here. (future pr I guess.) Add some questions I previously had, but more is needed to be added here.

  • Add configuration recipes based on how I configure telescope, @tjdevries please consider having the second recipe a builtin function. (perhaps with introducing an additional parameter for the dict)

TODO:

• Fix links
• Proofreading introduction

Is your feature request related to a problem? Please describe. Sometimes we need save the telescope to find a target file but wont edit it immediately. Just save the result to register or variable in lua. And we can use the target file name later.

Describe the solution you'd like Provide a function which can return the target file name string or save the target file name in register.

Describe alternatives you've considered None

Additional context None

Is your feature request related to a problem? Please describe. I work with a monorepo and when inside a file, I can't search for/in files in other projects in the monorepo.

Describe the solution you'd like I would like for telescope to work across the projects inside the monorepo. Maybe recursively find parent folders with .git folder or a .editorconfig with root = true

Describe alternatives you've considered

Additional context

I was trying to live-grep something like this:

first
second

I.e. / + first\nsecond in vim.

Is this achievable with telescope pickers? One thing I tried was passing --multiline to rg but to no avail.

I noticed that cycling the prompt history doesn't wrap around — picking the wrong (presumably next) direction prevents any history from showing up. I'm very used to the wrapping behavior from terminals and telescope behaves that way in the Results pane. Is there a way to achieve that currently?

telescope.setup({
  defaults = {
    mappings = {
      i = {
        ["<C-n>"] = actions.cycle_history_next,
        ["<C-p>"] = actions.cycle_history_prev,
      }
  }
}

The GitHub Issue → Question template leads to the Gitter chat, which is also mentioned in the project README. Going there I mostly see unanswered questions. I'm wondering if there's a better solution than users sending their questions into the void, while not burdening developers too much.

Description

The below works from both the command line and keybindings, but does not seem to work when placing within the telescope.setup({pickers block

Works:

:Telescope find_files find_command=rg,--ignore,--hidden,--files,-u,--glob,!**/.git/*,--glob,!**/node_modules/*

vim.keymap.set('n', '<leader>ff', ":Telescope find_files find_command=rg,--ignore,--hidden,--files,-u,--glob,!**/.git/*,--glob,!**/node_modules/*,--glob,!**/.next/*<CR>")

Not working

    pickers = {
      find_files = {
        find_command = {"rg", "--files", "--hidden", "--ignore", "-u", "--glob=!**/.git/*", "--glob=!**/node_modules/*"},    
      }
    },

Neovim version

NVIM v0.8.2
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by brew@Ventura

Operating system and version

macOS 13.0.1

Telescope version / branch / rev

telescope branch: 0.1.x

checkhealth telescope

telescope: require("telescope.health").check()
========================================================================
## Checking for required plugins
  - OK: plenary installed.
  - OK: nvim-treesitter installed.

## Checking external dependencies
  - OK: rg: found ripgrep 13.0.0
  - WARNING: fd: not found. Install [sharkdp/fd](https://github.com/sharkdp/fd) for extended capabilities

## ===== Installed extensions =====

## Telescope Extension: `fzf`
  - OK: lib working as expected
  - OK: file_sorter correctly configured
  - OK: generic_sorter correctly configured

Steps to reproduce

Keybindings reverted back to below via docs:

vim.keymap.set('n', '<leader>ff', builtin.find_files, {})

add to setup

    pickers = {
      find_files = {
        find_command = {"rg", "--files", "--hidden", "--ignore", "-u", "--glob=!**/.git/*", "--glob=!**/node_modules/*"},    
      }
    },

• open a project in nvim
• ff
• Search for hidden file or ignored file.

Expected behavior

Hidden and Ignored files are found. Example:

• ff
• search .env.loc
• see .env.local file

Actual behavior

With setup > long string keybind

• ff
• search .env.loc
• no files found

Minimal config

vim.cmd [[set runtimepath=$VIMRUNTIME]]
vim.cmd [[set packpath=/tmp/nvim/site]]
local package_root = '/tmp/nvim/site/pack'
local install_path = package_root .. '/packer/start/packer.nvim'
local function load_plugins()
  require('packer').startup {
    {
      'wbthomason/packer.nvim',
      {
        'nvim-telescope/telescope.nvim',
        requires = {
          'nvim-lua/plenary.nvim',
          { 'nvim-telescope/telescope-fzf-native.nvim', run = 'make' },
        },
      },
      -- ADD PLUGINS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. '/plugin/packer_compiled.lua',
      display = { non_interactive = true },
    },
  }
end
_G.load_config = function()
  require('telescope').setup({
    pickers = {
      find_files = {
        find_command = {"rg", "--files", "--hidden", "--ignore", "-u", "--glob=!**/.git/*", "--glob=!**/node_modules/*", "--glob=!**/.next/*"},    
      }
    }
})
  require('telescope').load_extension('fzf')
  -- ADD INIT.LUA SETTINGS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
end
if vim.fn.isdirectory(install_path) == 0 then
  print("Installing Telescope and dependencies.")
  vim.fn.system { 'git', 'clone', '--depth=1', 'https://github.com/wbthomason/packer.nvim', install_path }
end
load_plugins()
require('packer').sync()
vim.cmd [[autocmd User PackerComplete ++once echo "Ready!" | lua load_config()]]