I have updated the Plastic plugin (plastic.py) to be compatible with version 4.0 of this SCM tool.

I would like to get it integrated in the next release of ReviewBoard.

If you have any doubts, please, tell me.

Thanks and best regards, Luis

The collectstatic command is currently broken as it is trying to use certain keyword arguments that are not supported by the latest version of django-pipeline.

Because the requirement for django-pipeline is defined as >= in setup.py it brings in the latest version (as of this writing 1.2.15) although ReviewBoard is known to work with version 1.2.1.

This pull request fixes this problem (traceback cut off for brevity) by setting the requirement to 1.2.1 strict:

...
File "/opt/devel/rboard/lib/python2.6/site-packages/django_pipeline-1.2.15-py2.6.egg/pipeline/compilers/__init__.py", line 41, in compile
    compiler.compile_file(infile, outfile, outdated=outdated, force=force)
TypeError: compile_file() got an unexpected keyword argument 'outdated'  

The next problem is that jsmin doesn't get installed because it is not defined anywhere as a dependency so I included that into the requirements, the latest version (2.0.2) seemed to work correctly and finally was able to compile absolutely everything that ReviewBoard needs to work. The error that that fix prevents is below (again, traceback cut for brevity):

...
File "/opt/devel/rboard/lib/python2.6/site-packages/pipeline/compressors/jsmin/__init__.py", line 10, in compress_js
  from jsmin import jsmin
 ImportError: No module named jsmin

Hi, here's a tiny patch that adds two shortcut keys into diffviewer.js which have completely changed our lives:

• Hitting r is a shortcut for clicking 'Review', bringing up the review-editing pop-up.
• Hitting shift+r is a shortcut for clicking 'Review', checking 'Ship It', and clicking 'Publish Review', for quickly signing off on simple diffs much more efficiently.

Hope you pull these changes. Thanks!

Changed default value for branch as the None value will be inserted to MySQL if it's not sent when creating a review. I tried this change on our server and it looks to fix the null exception.

This is to try and solve the ticket 4009

Hi, when I commit a review request, I specify the reviewer people ping.ni, but another people jun.he can ship it. I do not know why, can you give me the answer. Thank you for your attention.

We moved the extensions docs out of the codebase docs, but this left 1.7 users with no way to get to the new docs. This restores the old docs, but under the 1.7 manual.

Now rbsite picks up management commands only from installed applications, i.e. rbsite doesn't take extensions into account. To fix it, rbsite can load all extensions before generating list of management commands.

Description:

Our RB instance has many repositories and I like to have email filters to divide my incoming requests into sub-folders. Having filters based on headers instead of the contents of the message is preferable.

I'm happy to change the header name to something else. "X-ReviewBoard-Repository" maybe?

Testing Done:

Visual.

The current value (256) makes the size of the row too big for MySQL InnoDB engine, resulting in this error:

django.db.utils.DatabaseError: Specified key was too long; max key length is 767 bytes

As the RFC (http://www.ietf.org/rfc/rfc1035.txt) fix this value to 255 as bigger, and it is enough to avoid the issue with InnoDB, it would be great to change it.

Thank you in advance.

The port being an integer blows up as the regex expects a string resulting in a TypeError.

When not specifying the port via rb-site install, it blows up.

* Installing the site...
Building site directories ... OK
Building site configuration files ... Traceback (most recent call last):
  File "/home/venvs/bin/rb-site", line 8, in <module>
    load_entry_point('ReviewBoard==1.7.7', 'console_scripts', 'rb-site')()
  File "/home/venvs/lib/python2.7/site-packages/ReviewBoard-1.7.7-py2.7.egg/reviewboard/cmdline/rbsite.py", line 1937, in main
    command.run()
  File "/home/venvs/lib/python2.7/site-packages/ReviewBoard-1.7.7-py2.7.egg/reviewboard/cmdline/rbsite.py", line 1405, in run
    self.show_install_status()
  File "/home/venvs/lib/python2.7/site-packages/ReviewBoard-1.7.7-py2.7.egg/reviewboard/cmdline/rbsite.py", line 1682, in show_install_status
    site.generate_config_files)
  File "/home/venvs/lib/python2.7/site-packages/ReviewBoard-1.7.7-py2.7.egg/reviewboard/cmdline/rbsite.py", line 885, in step
    func()
  File "/home/venvs/lib/python2.7/site-packages/ReviewBoard-1.7.7-py2.7.egg/reviewboard/cmdline/rbsite.py", line 290, in generate_config_files
    os.path.join(conf_dir, web_conf_filename))
  File "/home/venvs/lib/python2.7/site-packages/ReviewBoard-1.7.7-py2.7.egg/reviewboard/cmdline/rbsite.py", line 626, in process_template
    template)
  File "/home/venvs/lib/python2.7/re.py", line 151, in sub
    return _compile(pattern, flags).sub(repl, string, count)
TypeError: sequence item 1: expected string, int found

I verified this patch works as expected with the port. For kicks, I added a cast to str for the site_id, but that is just for good measure. The port is what blows up for me.

My invocation of rb-site:

rb-site install \
  --copy-media \
  --noinput \
  --domain-name="${vhost}.${domain}" \
  --site-root=/ \
  --static-url=static/ \
  --media-url=media/ \
  --db-type=mysql \
  --db-name="$database" \
  --db-host=localhost \
  --db-user="$team" \
  --db-pass="$password" \
  --cache-type=memcached \
  --cache-info="localhost:11211" \
  --web-server-type=apache \
  --python-loader=wsgi \
"${basedir}/$vhost"

Chrome does not currently wrap very long lines with no spaces (though Firefox does).

This makes the diff view unusable since one such line will cause all other long lines to also not break, even if they do have spaces. The result is that you have to scroll to read every line that is longer than what fits in the split diff view.

(I agree that in a perfect world all code would be hard-wrapped at 80 characters, and there would be no long lines without spaces.)

There is a small typo in reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js.

Should read success rather than succes.

Semi-automated pull request generated by https://github.com/timgates42/meticulous/blob/master/docs/NOTE.md