I've tried installing pep8ify by PIP, easy_install and by cloning the git repo and using setup.py. Each time I get this error:

$ pep8ify test2.py Traceback (most recent call last): File "/usr/local/bin/pep8ify", line 9, in load_entry_point('pep8ify==0.0.5', 'console_scripts', 'pep8ify')() File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 337, in load_entry_point return get_distribution(dist).load_entry_point(group, name) File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2279, in load_entry_point return ep.load() File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 1989, in load entry = import(self.module_name, globals(),globals(), ['name']) File "/usr/local/lib/python2.7/dist-packages/pep8ify-0.0.5-py2.7.egg/pep8ify/pep8ify.py", line 6, in from lib2to3.main import main ImportError: No module named main

This is running Python 2.7.3 on Ubuntu Pangolin. The library lib2to3 is installed and I can import it from the interactive interpreter.

pep8ify makes the following unnecessarily translation:

• foo # bar
• foo # bar

As per PEP8 inline comments should be separated by 2 spaces, not 1, therefore this particular translation should be avoided.

Traceback (most recent call last):
  File "/usr/local/bin/pep8ify", line 9, in <module>
    load_entry_point('pep8ify==0.0.12', 'console_scripts', 'pep8ify')()
  File "/usr/local/lib/python2.7/dist-packages/pep8ify/pep8ify.py", line 17, in _main
    raise SystemExit(lib2to3.main.main("pep8ify.fixes"))
  File "/usr/lib/python2.7/lib2to3/main.py", line 260, in main
    options.processes)
  File "/usr/lib/python2.7/lib2to3/refactor.py", line 706, in refactor
    items, write, doctests_only)
  File "/usr/lib/python2.7/lib2to3/refactor.py", line 299, in refactor
    self.refactor_dir(dir_or_file, write, doctests_only)
  File "/usr/lib/python2.7/lib2to3/refactor.py", line 319, in refactor_dir
    self.refactor_file(fullname, write, doctests_only)
  File "/usr/lib/python2.7/lib2to3/refactor.py", line 747, in refactor_file
    *args, **kwargs)
  File "/usr/lib/python2.7/lib2to3/refactor.py", line 354, in refactor_file
    tree = self.refactor_string(input, filename)
  File "/usr/lib/python2.7/lib2to3/refactor.py", line 386, in refactor_string
    self.refactor_tree(tree, name)
  File "/usr/lib/python2.7/lib2to3/refactor.py", line 426, in refactor_tree
    self.traverse_by(self.bmi_post_order_heads, tree.post_order())
  File "/usr/lib/python2.7/lib2to3/refactor.py", line 502, in traverse_by
    new = fixer.transform(node, results)
  File "/usr/local/lib/python2.7/dist-packages/pep8ify/fixes/fix_missing_whitespace.py", line 31, in transform
    new_prefix = " %s" % next_sibling.prefix.lstrip(' \t')
AttributeError: 'NoneType' object has no attribute 'prefix'

This is a punch of changes I've done when pep8ifying shinken (see this pull-request), but never created a pull-request for.

I rebased the changes on current master.

Here's the code:

# Copyright 2013 Donald Stufft
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
from __future__ import absolute_import, division, print_function
from __future__ import unicode_literals

import psycopg2cffi.compat

from warehouse.__about__ import (
    __title__, __summary__, __uri__, __version__, __author__, __email__,
    __license__, __copyright__, __build__,
)

__all__ = [
    "__title__", "__summary__", "__uri__", "__version__", "__author__",
    "__email__", "__license__", "__copyright__", "__build__",
]


psycopg2cffi.compat.register()

And the traceback:

$ pep8ify warehouse/__init__.py
RefactoringTool: Skipping implicit fixer: maximum_line_length
Traceback (most recent call last):
  File "/Users/alex_gaynor/.virtualenvs/tempenv-6c9a3044561e1/bin/pep8ify", line 9, in <module>
    load_entry_point('pep8ify==0.0.10', 'console_scripts', 'pep8ify')()
  File "/Users/alex_gaynor/.virtualenvs/tempenv-6c9a3044561e1/lib/python2.7/site-packages/pep8ify/pep8ify.py", line 12, in _main
    sys.exit(main("pep8ify.fixes"))
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/lib2to3/main.py", line 260, in main
    options.processes)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/lib2to3/refactor.py", line 706, in refactor
    items, write, doctests_only)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/lib2to3/refactor.py", line 301, in refactor
    self.refactor_file(dir_or_file, write, doctests_only)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/lib2to3/refactor.py", line 747, in refactor_file
    *args, **kwargs)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/lib2to3/refactor.py", line 354, in refactor_file
    tree = self.refactor_string(input, filename)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/lib2to3/refactor.py", line 386, in refactor_string
    self.refactor_tree(tree, name)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/lib2to3/refactor.py", line 426, in refactor_tree
    self.traverse_by(self.bmi_post_order_heads, tree.post_order())
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/lib2to3/refactor.py", line 500, in traverse_by
    results = fixer.match(node)
  File "/Users/alex_gaynor/.virtualenvs/tempenv-6c9a3044561e1/lib/python2.7/site-packages/pep8ify/fixes/fix_whitespace_before_inline_comment.py", line 36, in match
    prev_node = get_previous_node(node)
  File "/Users/alex_gaynor/.virtualenvs/tempenv-6c9a3044561e1/lib/python2.7/site-packages/pep8ify/fixes/fix_whitespace_before_inline_comment.py", line 12, in get_previous_node
    return get_previous_node(node.parent)
  File "/Users/alex_gaynor/.virtualenvs/tempenv-6c9a3044561e1/lib/python2.7/site-packages/pep8ify/fixes/fix_whitespace_before_inline_comment.py", line 12, in get_previous_node
    return get_previous_node(node.parent)
  File "/Users/alex_gaynor/.virtualenvs/tempenv-6c9a3044561e1/lib/python2.7/site-packages/pep8ify/fixes/fix_whitespace_before_inline_comment.py", line 12, in get_previous_node
    return get_previous_node(node.parent)
  File "/Users/alex_gaynor/.virtualenvs/tempenv-6c9a3044561e1/lib/python2.7/site-packages/pep8ify/fixes/fix_whitespace_before_inline_comment.py", line 12, in get_previous_node
    return get_previous_node(node.parent)
  File "/Users/alex_gaynor/.virtualenvs/tempenv-6c9a3044561e1/lib/python2.7/site-packages/pep8ify/fixes/fix_whitespace_before_inline_comment.py", line 10, in get_previous_node
    if node.prev_sibling:
AttributeError: 'NoneType' object has no attribute 'prev_sibling'

I dislike line continuations with \ as much as the next guy, but pep8ify seems to be proposing an unwarranted change to my codebase:

foo = \
    'some long stuff'

is being corrected to

foo =\
    'some long stuff'

Which looks weird to my eye. It feels like pep8ify should leave those lines alone.

I don't believe it should do so, the following code is perfectly fine:

import foo

# a comment

foo.bar()

but pep8ify emits the following diff:

--- t.py    (original)
+++ t.py    (refactored)
@@ -1,5 +1,4 @@
 import foo
-
-# a comment
+  # a comment

 foo.bar()

with python2.6, pep8ify raises ImportError as following:

Traceback (most recent call last):
  File "bin/pep8ify", line 14, in <module>
    pep8ify.pep8ify._main()
  File "/home/mete0r/prj/pyhwp/eggs/pep8ify-0.0.5-py2.6.egg/pep8ify/pep8ify.py", line 12, in _main
    sys.exit(main("pep8ify.fixes"))
  File "/usr/lib/python2.6/lib2to3/main.py", line 156, in main
    options.nobackups, not options.no_diffs)
  File "/usr/lib/python2.6/lib2to3/main.py", line 32, in __init__
    super(StdoutRefactoringTool, self).__init__(fixers, options, explicit)
  File "/usr/lib/python2.6/lib2to3/refactor.py", line 606, in __init__
    super(MultiprocessRefactoringTool, self).__init__(*args, **kwargs)
  File "/usr/lib/python2.6/lib2to3/refactor.py", line 200, in __init__
    self.pre_order, self.post_order = self.get_fixers()
  File "/usr/lib/python2.6/lib2to3/refactor.py", line 218, in get_fixers
    mod = __import__(fix_mod_path, {}, {}, ["*"])
  File "/home/mete0r/prj/pyhwp/eggs/pep8ify-0.0.5-py2.6.egg/pep8ify/fixes/fix_blank_lines.py", line 2, in <module>
    from lib2to3.fixer_util import find_indentation
ImportError: cannot import name find_indentation

It seems not clear that whether this is a known limitation or unintended error.

Just curious if you've seen autopep8. Wondering if you guys should work together if there are no philosophical differences. If there are philosophical differences, it would be nice to document what's different about this one.

pep8ify is inserting an extra line when I do in-place list copies with the foo[:] idiom:

-        return self.prop[:]
+        return self.prop[:
+            ]

This doesn't seem right...

I’m not entirely sure if this is a bug, but I don’t think this yields compliant code?

Versions

pep8ify/0.0.13 on Python/2.7.11

$ pep8ify -f blank_lines test.py

Input

class Foo:
    def __init__(self):
        bar = 13
    def baz(self):
        pass
class Bar:
    def __init__(self):
        bar = 13  # comment
    def baz(self):
        pass  # comment
class Baz:
    pass

Expected

--- test.py     (original)
+++ test.py     (refactored)
@@ -1,12 +1,18 @@
 class Foo:
     def __init__(self):
         bar = 13
+
     def baz(self):
         pass
+
+
 class Bar:
     def __init__(self):
         bar = 13  # comment
+
     def baz(self):
         pass  # comment
+
+
 class Baz:
     pass

Actual

% pep8ify -f blank_lines pep8.py
RefactoringTool: Refactored pep8.py
--- test.py     (original)
+++ test.py     (refactored)
@@ -1,12 +1,18 @@
 class Foo:
     def __init__(self):
         bar = 13
+
     def baz(self):
         pass
+
+
 class Bar:
     def __init__(self):
-        bar = 13  # comment
+        bar = 13
+  # comment
     def baz(self):
-        pass  # comment
+        pass
+
+  # comment
 class Baz:
     pass
RefactoringTool: Files that need to be modified:
RefactoringTool: pep8.py

See https://gist.github.com/dhermes/85c3a3a464d2cff312ea for a (super hacky) way to make this work.

Currently, pep8ify takes

def hello_func(name):
  """Prints hello with the name.

  Args:
    name: String, to print.
  """
  print 'Hello %s, nice to meet you.' % (name,)

and turns it into

def hello_func(name):
    """Prints hello with the name.

  Args:
    name: String, to print.
  """
    print 'Hello %s, nice to meet you.' % (name, )

Running indent_docstrings.py on it gives the desired:

def hello_func(name):
    """Prints hello with the name.

    Args:
      name: String, to print.
    """
    print 'Hello %s, nice to meet you.' % (name, )

Currently pep8ify seems to insert a blank between the comma and the closing bracket of a singleton tuple. I consider this an error. In contradiction to what was written in issue #8, there is a difference between singleton tuples and singleton lists :

>>> tup = (1,)
>>> tup
(1,)
>>> liz = [1,]
>>> liz
[1]

IMO, since the string representation of singleton tuples includes no space before the closing bracket, pep8ify should not insert one. The rule to avoid blanks inside brackets beats the rule to insert a space after commas in this special case.

I just installed pep8ify today and found it very useful; thank you!

When I look for help at the command line:

$ pep8ify -h Usage: 2to3 [options] file|dir ...

I have searched around in the repo and cannot figure out where the help message is being generated (so I can give you a pull request to change '2to3' to 'pep8ify'). Help?

ie

text = "Imagine this is a string that goes over 80 chars"

to

text = "Imagine this is a string that"
    " goes over 80 chars"