We need to add tests for woql_view.py, a file named test_woqlView.py can be added to terminusdb_client/tests/

In the test, it would check the WOQLView methods against the js_config, for example, test for WOQLView().height(100) should give you woqlGraphConfig.height(100) when you call the print_js_config.

The issue would need more guidance so please don't feel shy to ask for clarification here.

PR should be made to master branch

Is your feature request related to a problem? Please describe. I have been looking at the code to try and understand how some functions work, and as often with python it is difficult to guess what sort of data is expected in a variable or function call.

Describe the solution you'd like Python type hints are a great way to provide such info. I see them as automated documentation, which also serves as a debugging help. Given how strong the data typing is inside the database, I think it would also make sense to extend it over to the client code.

Describe alternatives you've considered I am not aware of any alternatives to type hints, but I think they can be implemented in a couple of different ways:

• directly into the code, probably the goal in the end, given how they help with understanding the code
• as *.pyi stub files that live side by side with the actual code, or even in a different repo. I think they have value in code bases that also aim at working under older python version (2.7 and so on), but given that you're aiming for python 3.6+, I don't think this applies. They're also useful if you don't want to include hints in the main code base, as the stubs can live their own life elsewhere (and constantly try to stay up to date with the code).

Additional context When I've added type hint to existing code bases before, I've almost always found a couple of bugs that mypy made immediately obvious. Some argue that type hints make the code harder to read, but I think it's a minor disagreement considering the value they bring. I could be up for sending a PR with annotations for the core functions, if you think that would be useful.

Now the WOQLClient.rollback allows a user to put in how many step to go back and 1 step is the default. Maybe the default should be going back to when the connection starts or when the user calls WOQLCLient.commit?

Quite often there is a need to generate several unique yet anonymous instances of a class, that is, the client doesn't care about their names but you want to make sure they are all separate). Neither id_gen() nor unique() provide this function directly and require you to programmatically maintain some kind of global counter to pass as part of the key_list to ensure there is no collision with past ids. And the client then needs to keep a record of the counter in the DB so inserts and queries during subsequent sessions continue to be unique. The db server should provide this function. In LISP, this function was called gensym (for generate a symbol); if no prefix was given it used 'G' and returned 'G00345', etc.

Various document query elements changed recently. They need to be updated in the client.

• See also https://github.com/terminusdb/terminusdb-client-js/issues/78 for the JavaScript issue.
• See https://github.com/terminusdb/terminusdb/commit/1c75eef9365fdb50abee013d502f89ab21082867 for a large change to json_woql.pl that describes some, if not all, changes.
• See the current WOQL schema.

Ubuntu 18.04 running bootstrap version 4.1.2 in docker container, via python client:

WOQLQuery().cast('http:foo','xsd:string','v:Value').execute(client) yields: *** terminusdb_client.woqlclient.errors.APIError: { "api:message":"Error: key_has_unknown_prefix("http:foo")\n [47] ...."}

WOQLQuery().cast('scm:foo','xsd:string','v:Value').execute(client) yields: *** terminusdb_client.woqlclient.errors.APIError: { "@type":"api:FrameErrorResponse", "api:error": { "@type":"api:BadCast", "api:type":"http://www.w3.org/2001/XMLSchema#string", "api:value":"'terminusdb:///schema#foo'" }, "api:message":"The value 'terminusdb:///schema#foo' could not be cast as 'http://www.w3.org/2001/XMLSchema#string'", "api:status":"api:failure" }

xsd:string should just take the string as-is (except perhaps deal with embedded '<' and '&') and ignore apparent prefixes.

Describe the bug I am setting up the terminusdb-client-python repo and following this guide here. However when I reach the step for tox -e check, it throws an error. I have performed all the steps as mentioned in that guide.

To Reproduce Clone a fresh repo and perform the steps mentioned in the guide here. When you reach the line tox -e check it throws an error. An additional step I took which is not mentioned in the guide, is to activate the virtualenv by running pipenv shell. Apart from this, all the steps are same.

Expected behavior The check should be performed and should give the result.

Error logs The error is thrown as

terminusdb-client-python on  master via 🐍 v3.8.2 (terminusdb-client-python-kX6_7a_V) took 1m48s 
❯ tox -e check
check installed: appdirs==1.4.4,attrs==20.2.0,autoflake==1.4,bandit==1.6.2,black==20.8b1,click==7.1.2,dataclasses==0.6,flake8==3.8.3,flake8-assertive==1.2.1,flake8-bandit==2.1.2,flake8-bugbear==20.1.4,flake8-builtins==1.5.3,flake8-comprehensions==3.2.3,flake8-polyfill==1.0.2,flake8-print==3.1.4,gitdb==4.0.5,GitPython==3.1.8,importlib-metadata==2.0.0,isort==5.5.4,libcst==0.3.11,mccabe==0.6.1,mypy-extensions==0.4.3,pathspec==0.8.0,pbr==5.5.0,pep8-naming==0.11.1,pybetter==0.3.5,pycodestyle==2.6.0,pyemojify==0.2.0,pyflakes==2.2.0,Pygments==2.7.1,pyupgrade==2.7.2,PyYAML==5.3.1,regex==2020.9.27,shed==0.2.4,six==1.15.0,smmap==3.0.4,stevedore==3.2.2,tokenize-rt==4.0.0,toml==0.10.1,typed-ast==1.4.1,typing-extensions==3.7.4.3,typing-inspect==0.6.0,zipp==3.2.0
check run-test-pre: PYTHONHASHSEED='459764776'
check run-test: commands[0] | shed
Traceback (most recent call last):
  File "/home/prashant/Documents/personal/OSS/terminusdb-client-python/.tox/check/bin/shed", line 5, in <module>
    from shed import cli
  File "/home/prashant/Documents/personal/OSS/terminusdb-client-python/.tox/check/lib/python3.8/site-packages/shed/__init__.py", line 46, in <module>
    from com2ann import com2ann
ModuleNotFoundError: No module named 'com2ann'
ERROR: InvocationError for command /home/prashant/Documents/personal/OSS/terminusdb-client-python/.tox/check/bin/shed (exited with code 1)
_____________________________________________________________________________________________________ summary _____________________________________________________________________________________________________
ERROR:   check: commands failed

System information (please complete the following information):

• OS: Ubuntu 20.04
• terminus-client-python version: The editable version installed from pip install -e .

Additional context None

Describe the bug Performing a path query with least/most fails. Using the same query with the + quantifiers works with the same query in other respects.

To Reproduce Steps to reproduce the behavior:

1. Go to TerminusX
2. Have model where a path query can be performed with edge property names known
3. Click on Data Product Explorer
4. Enter queries
5. Open Browser console --> Network information --> clear cache
6. Press Run
7. See error as the response (HTTP 400)

Non-working query (note the {1,2}):

WOQL.and(
  WOQL.triple("v:person","rdf:type","@schema:Capability"),
  WOQL.triple("v:circle","rdf:type","@schema:Gap"),
  WOQL.path("v:person","((capability_userstory|userstory_gap){1,2})","v:circle","v:path_var5")
  )

Working query (note the +):

WOQL.and(
  WOQL.triple("v:person","rdf:type","@schema:Capability"),
  WOQL.triple("v:circle","rdf:type","@schema:Gap"),
  WOQL.path("v:person","((capability_userstory|userstory_gap)+)","v:circle","v:path_var5")
  )

Expected behavior I expected to get the same result between both queries

Screenshots See error message below (the error message is not reported in TerminusX, and just fails silently, showing the result of the previous query instead of failing).

{
  "api:message":"Type error for '1'/0 which should be evaluable",
  "api:status":"api:failure",
  "system:witnesses": [
    {
      "@type":"vio:ViolationWithDatatypeObject",
      "vio:literal":"'1'/0",
      "vio:message":"Type error for '1'/0 which should be evaluable",
      "vio:type":"evaluable"
    }
  ]
}

Info (please complete the following information):

• OS: Microsoft Edge (chromium)
• TerminusX

Additional context Add any other context about the problem here.

Addressing #207

Modified mocked_requests_get() to return function to be able to override response code like @mock.patch("requests.post", side_effect=mocked_request(response_code=400))

When running the usage in the readme am having issues with context

To Reproduce 1- Install the python client 2- Connect to the terminusdb 3- Create a database 4- Error occurs when creating the db schema

Expected behavior Expecting to have a newly created schema

Error logs .Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/Users/nkeumo/Documents/pycharmWorkspace/terminusdb-client-python/terminusdb_client/woqlquery/woql_query.py", line 481, in execute return client.query(self, commit_msg, file_dict=file_dict) File "/Users/nkeumo/Documents/pycharmWorkspace/terminusdb-client-python/terminusdb_client/woqlclient/woqlClient.py", line 1101, in query request_woql_query["@context"] = self._context AttributeError: 'WOQLClient' object has no attribute '_context'

This occurs when I run this command WOQLQuery().doctype("scm:student").property("scm:name", "xsd:string").execute(client, "student schema created.")

System information (please complete the following information):

• OS: [e.g. Mac OS Bigsur]
• terminus-client-python dev version

This PR adds typing annotations to woqlClient.py.

Running mypy on the code brings up a few issues for which I'd like to have your opinion @Cheukting to make sure the code stays consistent across the various files.

I'm adding a few comments directly in the code to help understand the context to which I'm referring. Please let me know what you think of them, and I'll update the PR accordingly. I usually like stronger typing, because I find that it helps catch mistakes as you write the code, instead of waiting for execution to find them :)

Bumps certifi from 2022.6.15 to 2022.12.7.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Bumps cryptography from 37.0.4 to 38.0.3.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

https://github.com/terminusdb/terminusdb-client-python/blob/1d04acc95a77c6210d5fd63a27aeecbd591374a4/terminusdb_client/woqlquery/woql_query.py#L951

needs to be harmonized with Client.get_triples

https://github.com/terminusdb/terminusdb-client-python/blob/1d04acc95a77c6210d5fd63a27aeecbd591374a4/terminusdb_client/woqlclient/init.py#L4

it's confusing to have two clients.

openapi-python-client.exe update --url https://raw.githubusercontent.com/terminusdb/openapi-specs/main/terminusdb.yaml
Updating terminus_db_api_client
Warning(s) encountered while generating. Client was generated, but some pieces may be missing
WARNING parsing GET /schema within frame. Endpoint will not be generated.

Incorrect path templating for /schema (Path parameters do not match with path)


If you believe this was a mistake or this tool is missing a feature you need, please open an issue at https://github.com/openapi-generators/openapi-python-client/issues/new/choose

probably nothing for terminusdb to do: cause for ref.: https://github.com/openapi-generators/openapi-python-client/issues/539