Thanks for creating such a useful extension, has been really helpful!

Problem

Doing a pip install . in the root directory after a clone is failing to install the package contents correctly. It didn't create a fava_portfolio_summary directory with the python files in the site-packages directory, and only copied the metadata to it.

Solution

I was able to resolve it by adding the package_dir option to setup.py:

...
packages=find_packages(),
package_dir={'fava_portfolio_summary': '.'}
...

PS: setuptools is deprecated, so it might be prudent to switch to pyproject.toml to specify the package details :)

PS2: Would be good to add some installation instructions to the readme. After the proposed change, doing pip install git+https://github.com/PhracturedBlue/fava-portfolio-summary does the job!

I had to make a few changes to setup.py in order to be able to integrate fava-portfolio-summary into my docker image where run beancount/fava. The Dockerfile is as follows:

FROM python:3

# Keeps Python from generating .pyc files in the container
ENV PYTHONDONTWRITEBYTECODE=1

RUN /usr/local/bin/python -m pip install --upgrade pip
RUN /usr/local/bin/python -m pip install --upgrade setuptools
COPY requirements.txt .
RUN python -m pip install -r requirements.txt

WORKDIR /beancount

ENV FAVA_HOST=0.0.0.0
ENV FAVA_PORT=15000
ENV MAIN_FILE=main.beancount

EXPOSE 15000

CMD ["/bin/bash", "-c", "fava $MAIN_FILE"]

And requirements.txt contains:

fava
git+https://github.com/PhracturedBlue/fava-portfolio-summary

The package was being created without the source and template files, so fava was failing to load it. This gets resolved with this proposal.

I originally tried out the fava-portfolio-summary extension because I was looking for a simple way to track my stock allocation versus the rest of my portfolio. While associating different accounts to my stocks portfolio, fava-portfolio-summary will show me the percentage of each security under this portfolio but not the percentage of stocks in the whole portfolio. This PR adds this as part of the summary, on the top under All portifolios.

For example, this is how it looks for me with this change: https://paste.pics/GPRDG

I encountered following error when using the extension:

Exception on /beancount/extension/PortfolioSummary/ [GET]
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/fava_portfolio_summary/__init__.py", line 71, in portfolio_accounts
    portfolio = self._account_metadata_pattern(tree, key, pattern, internal, mwr, twr)
  File "/usr/local/lib/python3.10/site-packages/fava_portfolio_summary/__init__.py", line 172, in _account_metadata_pattern
    portfolio_data = self._portfolio_data(selected_accounts, internal, mwr, twr)
  File "/usr/local/lib/python3.10/site-packages/fava_portfolio_summary/__init__.py", line 263, in _portfolio_data
    rows.append(total)
  File "/usr/local/lib/python3.10/site-packages/fava_portfolio_summary/__init__.py", line 233, in _process_node
    try:
  File "/usr/local/lib/python3.10/site-packages/fava/core/__init__.py", line 538, in prices
    all_prices = get_all_prices(self.price_map, (base, quote))
  File "/usr/local/lib/python3.10/site-packages/beancount/core/prices.py", line 303, in get_all_prices
    return _lookup_price_and_inverse(price_map, base_quote)
  File "/usr/local/lib/python3.10/site-packages/beancount/core/prices.py", line 278, in _lookup_price_and_inverse
    return price_map[base_quote]
KeyError: ('CHF', 'VT')

The problem for me is that I have securities which are traded in USD, while my operating currency is CHF. It seems operating currency does not work in the situation where the user needs to trade uisng different currencies. I propose to add this workaround for the time being and later work on a smarter solution to figure out which currency should be used to obtain the prices.