Still have some work to do to clean up the output and write tests, but I'm gonna make this draft for now so that y'all can see what's been done so far.

Closes #49

…_instructor functions

There were some data fields I couldn't find in the JSON. I just left these as empty strings or False for now. Will add comments over the code to show where these are.

A lot of our users were confused by the positioning of our Add Course button. This PR puts the Add course button right below the last course card, but makes the button "sticky" so that it can't go below the bottom of the CourseSelectColumn. Make sure that the spacing looks right to y'all

welcome page skeleton is done. Still needs:

• google login redirect and logo
• text to be centered

later:

• linking semester dropdown text to following page

Description

Users have commented that it feels jerky for cards to suddenly collapse and expand. Using Material-UI's Collapse component, I have added a 300ms transition between these states. I think Collapse probably uses some secret wizardry where they keep a pre-rendered copy of the collapsed card on hand so that they can rapidly add it back to the DOM during expansion.

Although Collapse makes it fast to expand and collapse the cards, it has no effect on switching between Basic and Section modes. I tried applying useMemo to sectionSelect to speed up this second transition, but to no avail. It appears that the time-consuming portion is not actually running the React code to determine what the SectionSelect should be, but to take that result and render it to the screen. (This was fairly surprising because of how inefficiently the SectionSelect component is written.) To eliminate the expensive step of rendering HTML elements to the DOM, I switched to using display: none; to hide the customizationContent that wasn't currently being used.

Rationale

There is one sort of sketchy area where I manually calculate the height of the card (the fixHeight function), and this is liable to be accidentally broken in the future. Actually, it'll break as soon as Troy merges his Select All button. I'm not sure how I could add tests for it, though, so lmk if you have ideas.

Also, the part with the MutationObserver seems pretty hacky, too. The problem was that when the initially expanded card is rendered, it only has the loading circle, which is small enough to apply expandedRowSmall. So if I try to set the height of sectionRows while the overflow: visible; from expandedRowSmall is still active, it'll tell me I have all the space in the world. Instead, I waited until CourseSelectColumn changed the class to expandedRow, and then applied fixHeight. Waiting for the class to change meantt using a mutation observer. unless y'all have any better ideas.

How to test

I'd like to try to get some automated tests for this, but JS DOM doesn't mock height and CSS rules IIRC, so I can't think of a way to do it.

For manual tests, open small classes like JAPN 201, medium classes like CSCE 314, and enormous classes like KINE 199. They should all collapse and expand smoothly no matter what order you open them in and regardless of how many times you switch between Basic and Section in between.

Screenshots

|Before|After| |--|--| |||

Related tasks

Closes #415 Closes #387

SectionSelect now shows the available seats for each section. I changed the section number to show on its own line so that this can look better on low resolutions (specifically, I wanted to make it still look good on 1366x768 since some people might still have laptops with that terrible resolution), and still be self-explanatory, rather than just having it say "0/50" or something like that.

This is a draft for now since I haven't made tests yet, and this is based off of Adel's frontend/show-honors branch.

A couple design choices I made, but feel free to argue the other way if you feel there's a reason to do so:

• Shows max seats instead of just available seats so that people can easily tell if a section is really full, or if it just hasn't had all of its seats opened yet
• Seats are right-aligned which might look a little weird on high resolutions (for example, this is what it looks like on my 1440p monitor):

Closes #186.

Description

A common request that we have received is the ability to select all sections taught by a particular professor, as this is a common way for students to pick classes. This PR adds such a checkbox next to the instructor name. From a design perspective, this makes the instructor header a little cramped on small screen sizes, but it can't really be helped imo 🤷. Maybe consider showing professor's last name only?

Anyway, in order to provide a sense of hierarchy, the SectionInfos for the individual sections had to be indented to the right of the professor checkbox. Because of this indentation, on smaller screens, the meeting info may be wrapped onto 2 lines. If you don't like the current wrapping, we might need to look into CSS Grid rather than Flexbox (the current approach), which honestly scares me just a little bit.

Also, I elected to use alternating colors (light maroon & white) to distinguish between mulitple meetings in the same section. Because I didn't like how this looked when there was only one meeting, I added a CSS rule to override the alternating colors for single-meeting sections. ~Someone remind me to add~ Added a comment to that line, because I'm 90% sure we're going to forget what it does in the future.

We had previously discussed adding icons, but after trying them out, they felt like they cluttered the space to me. Since alternating colors was pretty effective at distinguishing between one meeting and the next, I honestly don't feel that icons are necessary.

Small design bug: If a section has an odd number of meetings (e.g. ENGR 102), the mini-divider will be covered by the background of the last meeting. First fix that I thought of was throwing in a 3px margin between the last section and the divider, and I think I can use CSS selectors to limit this to the cases when the last meeting is colored. Lmk if y'all have better ideas.

How to test

Automated tests added for the selecting functionality. For visuals, check out KINE 199 for 1-meeting sections, BIOL 351 for 2-meeting sections, ENGR 102 for 3-meeting sections, PHYS 202 for 4-meeting sections, and any other classes you like.

Screenshots

|1 meeting|2 meetings|3 meetings| |--|--|--| ||||

Related tasks

Closes #259

Description

Adds messages describing what went wrong when generate schedules doesn't return any schedules. I'd appreciate if everyone could try to think of other reason generating schedules might fail so we can be sure these error messages are accurate and cover everything that could possibly go wrong.

Rationale

There are a couple assumptions I make to avoid making extra queries just to check if sections still exist in the queryset:

• Courses have sections for the term given (since when searching for courses it only gives courses with sections in the current term, this should be fine)
• Web/honors filters don't result in an empty queryset (I made changes to make sure this assumption is always valid on the frontend, as before when the course changed it didn't change your existing choice for web/honors)

With these assumptions, these are the three ways generating schedules can fail and their messages:

_NO_SECTIONS_WITH_SEATS = (
    'None of the sections you selected for {subject} {course_num} have available seats.'
)
_NO_SECTIONS_MATCH_AVAILABILITIES = (
    'No sections for {subject} {course_num} are compatible with your available times. '
    'Either select more sections, or remove some of your busy times.'
)
_NO_SCHEDULES_POSSIBLE = 'No schedules are possible with your selected constraints.'

There's also the possibility that the call fails (since the server is down or the schedules are malformatted), for this case I added another message to the frontend saying that something went wrong.

I also refactored the section filters on the frontend to use an enum for consistency, since it's always bothered me that we use explicit values and this PR is vaguely related to section filters.

How to test

Try to generate schedules with various constraints that may or may not result in no schedules being generated. I think I was pretty thorough with the ways the call can fail, but there's always the possibility I missed something.

Screenshots

Previous error message:

Example new error messages:

Related tasks

Closes #399.

Added an icon for honors sections and appropriate tests. Currently, the icon is gray to match th professor's name, and there isn't a whole lot of space between the text and the icon. Seems fine to me, but if y'all don't like it, it's an easy fix.

Closes #230

So this is mostly implemented other than the tests. I made this a PR (although probs should be a draft) just so we could discuss the testing for it, since a lot of the functions in it are kind of funky to test.

I'm also considering adding optional --year and --college arguments to it so we can quickly scrape a small amount, rather than scraping everything from 2013 - 2019.

I also need to figure out how to add SSL certificate creation to requests.get call in fetch_page_data, as not doing so gives a warning on the function call.

I have more or less implemented the course select card. I believe it has full functionality at this point, and all that remains is fixing some spacing issues and writing tests to ensure that multiple meetings/sections are handled properly. i'll leave it as a draft until the spacing and tests are fixed.

Closes #109

I was looking at this layout here, taken from MATH 140 - Spring 2021, when I realized that sections 500 and 501 weren't aligned with each other. This bothered me, but not enough to fix in #568, so I'm making a separate issue to remind myself to fix it later. The solution,if I'm not mistaken, is to move the root grid element up one level so that both sections are within the same grid container

so i know that you guys arent currently accepting contributions right now but i was wondering when you guys might be. additionally when and if you guys accept contributors, do contributors have to go through becoming a member of aggie coding club etc.?

We've been frequently getting the following error on the /complete/google-oauth2/ route:

"Internal Server Error: /complete/google-oauth2/
Traceback (most recent call last):
  File "/layers/google.python.pip/pip/lib/python3.7/site-packages/django/core/handlers/exception.py", line 34, in inner
    response = get_response(request)
  File "/layers/google.python.pip/pip/lib/python3.7/site-packages/django/core/handlers/base.py", line 115, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/layers/google.python.pip/pip/lib/python3.7/site-packages/django/core/handlers/base.py", line 113, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/layers/google.python.pip/pip/lib/python3.7/site-packages/django/views/decorators/cache.py", line 44, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)
  File "/layers/google.python.pip/pip/lib/python3.7/site-packages/django/views/decorators/csrf.py", line 54, in wrapped_view
    return view_func(*args, **kwargs)
  File "/layers/google.python.pip/pip/lib/python3.7/site-packages/social_django/utils.py", line 49, in wrapper
    return func(request, backend, *args, **kwargs)
  File "/layers/google.python.pip/pip/lib/python3.7/site-packages/social_django/views.py", line 33, in complete
    *args, **kwargs)
  File "/layers/google.python.pip/pip/lib/python3.7/site-packages/social_core/actions.py", line 45, in do_complete
    user = backend.complete(user=user, *args, **kwargs)
  File "/layers/google.python.pip/pip/lib/python3.7/site-packages/social_core/backends/base.py", line 40, in complete
    return self.auth_complete(*args, **kwargs)
  File "/layers/google.python.pip/pip/lib/python3.7/site-packages/social_core/utils.py", line 248, in wrapper
    return func(*args, **kwargs)
  File "/layers/google.python.pip/pip/lib/python3.7/site-packages/social_core/backends/oauth.py", line 375, in auth_complete
    state = self.validate_state()
  File "/layers/google.python.pip/pip/lib/python3.7/site-packages/social_core/backends/oauth.py", line 87, in validate_state
    raise AuthStateMissing(self, 'state')
social_core.exceptions.AuthStateMissing: Session value state missing." 

Easy way to query on GCP Logs Explorer: severity=(EMERGENCY OR ALERT OR CRITICAL OR ERROR) OR protoPayload.resource =~ "/complete/google-oauth2/.*"