The new 2.3.7 release depends on six.moves.collections_abc, which was introduced in six 1.13.0, but setup.py does not specify that that the six dependency must be >=1.13.0. This can result in failures if projects depend on pathlib2 without manually specifying a newer six version themselves.

The issue is that sys.getfilesystemencoding() == "mcbs" on Windows/Python 2.7, which is lossy. So one looses info when passes path as unicode to Path.

>>> pathlib2.Path(u'/c/Documents and Settings/User/\u041c\u043e\u0438 \u0434\u043e\u043a\u0443\u043c\u0435\u043d\u0442\u044b/.ipython/profile_default/db')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python2.7/site-packages/pathlib2.py", line 1095, in __new__
    self = cls._from_parts(args, init=False)
  File "/usr/lib/python2.7/site-packages/pathlib2.py", line 760, in _from_parts
    drv, root, parts = self._parse_args(args)
  File "/usr/lib/python2.7/site-packages/pathlib2.py", line 748, in _parse_args
    parts.append(str(a))
UnicodeEncodeError: 'ascii' codec can't encode characters in position 31-33: ordinal not in range(128)

As you may have guessed, this appears when starting ipython in Cygwin if Cygwin's home dir is a junction to the Windows one.

Since str is Unicode in Python 3, I believe the error is specific to the backport.

i want to use

from pathlib import Path
Path('foo').mkdir(exist_ok=True)

instead of

try:
    from pathlib import Path
except ImportError:
    from pathlib2 import Path
Path('foo').mkdir(exist_ok=True)

this should be no problem since the stdlib pathlib should be backwards compatible.

in order to make the change backwards compatible, you could make setup.py create both pathlib.py and a symlink named pathlib2.py

numpy.fromfile() is a critically important function for loading raw binary data in a very fast manner.

Python 2.x with Numpy 1.10 requires NOT to have io.BufferedReader. This patch makes pathlib2 return a traditional file handle for the .open() method on Python 2.x.

Astropy had to do this too, see lines 387-414 of https://github.com/astropy/astropy/blob/master/astropy/io/fits/util.py

This is not a problem for Python 3.4-3.5 with Numpy 1.10, so I left as is.

After future testing I realize this causes an issue with encoding/writing files. Perhaps you have more experience in this area, I didn't want to layer on hacks.

Perhaps for now I will just put in my own user code a if PY2: then open() etc. instead of messing with pathlib2, as Python<3.4 is an edge case for me.

In Python 3.5.0:

  from pathlib import Path
  f = Path('~')
  f.expanduser()

gives the home directory full path.

In Python 3.4.3 with pathlib2 2.0.1:

  from pathlib2 import Path
  f = Path('~')
  f.expanduser()

gives AttributeError: 'PosixPath' object has no attribute 'expanduser'

WIP

• Drop support for python versions which are EOL (i.e. 2.6 and 3.<4)
• Use tox to control testing
• Switch from the unicode compile script to just copying the test file with from __future__ import unicode_literals at the top
• Include a Makefile which controls the above and the testing
• context.py still exists but doesn't do the path mangling: make test ensures that pathlib2 is installed (in develop/ editable mode)

In python 3, os.path.join(pathlib.Path('my/path'), 'my.file') returns a string, my/path/my.file.

However, os.path.join(pathlib2.Path('my/path'), 'my.file') raises an AttributeError:

     68         if b.startswith('/'):
     69             path = b
---> 70         elif path == '' or path.endswith('/'):
     71             path +=  b
     72         else:

AttributeError: 'PosixPath' object has no attribute 'endswith'

This is an issue for someone trying to gradually port a large codebase over to using Paths

While strictly speaking, this may be due to py2's implementation of os.path.join rather than pathlib2's implementation of PurePath, it may be useful to reverse engineer compatibility for such a common path operation.

Usually, this would require implementing startswith, endswith, and __iadd__ on PurePath. However, giving pathlib2.PurePath a significant amount of behaviour not seen in the 'real' PurePath doesn't seem like a good idea. Is there another way round it? Is it possible for importing pathlib2 to insert a shim into os.path?

@graingert Anything else needed that you can think of? Can you think of any good upstream projects or high profile users which need this package that might be interested to help testing this?

Hello @mcmtroffaes 👋🏻 I just refactor some functions in the code itself and edit the test relate to testing the pathlib.

• Replace range(0, x) with range(x).
• Replace unneeded comprehension with generator.

In Python before 3.2, it's possible to get None from this. However AWS Codebuild is setting things up, this causes pathlib2 to explode:

...
  File "/codebuild/output/src991325250/src/github.com/.../ve-web/local/lib/python2.7/site-packages/pathlib2/__init__.py", line 928, in _make_child 
    drv, root, parts = self._parse_args(args) 
  File "/codebuild/output/src991325250/src/github.com/.../ve-web/local/lib/python2.7/site-packages/pathlib2/__init__.py", line 885, in _parse_args 
    parts.append(a.encode(sys.getfilesystemencoding())) 
TypeError: encode() argument 1 must be string, not None 

Follow up from #66.

The main activity for pathlib2 is to backport any updates from cpython into this repository, typically a few times a year, with the main development of pathlib happening in upstream cpython. As stated, in the long term, I really would like to stand down as lead maintainer. I'm happy to keep helping along in the background e.g. reviewing PRs and submitting trivial patches if need be.

Is someone interested (e.g. someone who uses pathlib2 in their work) to take on the lead responsibility for this package?

This issue tracks the implementation of the Jazzband guidelines for the project pathlib2

It was initiated by @mcmtroffaes who was automatically assigned in addition to the Jazzband roadies.

See the TODO list below for the generally required tasks, but feel free to update it in case the project requires it.

Feel free to ping a Jazzband roadie if you have any question.

TODOs

• [x] Fix all links in the docs (and README file etc) from old to new repo
• [x] Add the Jazzband badge to the README file
• [x] Add the Jazzband contributing guideline to the CONTRIBUTING.md or CONTRIBUTING.rst file
• [x] Check if continuous testing works with GitHub Actions
• [x] Check if test coverage is tracked with Codecov
• [x] Add jazzband account to PyPI project as maintainer role (e.g. URL: https://pypi.org/manage/project/pathlib2/collaboration/)
• [x] Add jazzband-bot as maintainer to the Read the Docs project (e.g. URL: https://readthedocs.org/dashboard/pathlib2/users/)
• [x] Add incoming GitHub webhook integration to Read the Docs project (e.g. URL: https://readthedocs.org/dashboard/pathlib2/integrations/) https://github.com/jazzband/pathlib2/issues/72
• [x] Fix project URL in GitHub project description
• [x] Review project if other services are used and port them to Jazzband
• [ ] Decide who is project lead for the project (if at all) https://github.com/jazzband/pathlib2/issues/70
• [x] https://github.com/jazzband/pathlib2/issues/68
• [x] https://github.com/jazzband/pathlib2/pull/69

Project details