The Chambolle paper this is based on -- http://www.cmap.polytechnique.fr/preprint/repository/578.pdf -- initializes Xi_0 with 0, not with g (see page 13 at the bottom).

Consider this code:

im = misc.lena()
U, T = rof.denoise(im, im, tv_weight=30)
imshow(U)

Before this change, this produced the output http://i.imgur.com/u68Vakj.jpg . With this change, it produces http://i.imgur.com/3eHli7J.jpg which looks more correct.

Dear Jan Erik Solem,

Many thanks for your book, "Programming Computer Vision with Python." I'm learning how to process computer images by your book.

Although there are many image files used in the sample programs, I could not find them in this repository. Some files have path like 'data/image.png', but I could not find such folder.

We can find several reference sites for us to collect image files in your book. But do we have to pick up each image file to trace your sample codes?

I'll be happy if I could have a good way to gather the image files. Thanks.

Best, Takeshi Akutsu (@akucchan_world)

function plot_matches in sift.py should contain: plot([locs1[i][0],locs2[m][0]+cols1],[locs1[i][1],locs2[m][1]])

because in locs coordinate x comes before y

Traceback (most recent call last): File "imgsearch.py", line 32, in res_reg = [w[1] for w in src.query(imlist[q_ind])[:nbr_results]] # 查询的结果 File "/opt/conda/lib/python3.8/site-packages/PCV/imagesearch/imagesearch.py", line 128, in query h = self.get_imhistogram(imname) File "/opt/conda/lib/python3.8/site-packages/PCV/imagesearch/imagesearch.py", line 96, in get_imhistogram return pickle.loads(str(s[0])) TypeError: a bytes-like object is required, not 'str'

env: python3.8.8

Hi Jan-

Any chance you could post the code from chapter 5? I wanted to mess around with the plane_sweep stuff (stereo.py) and right now it looks like that would require typing in the code manually from the book?

-darkgreen

File "gen_vocabulary.py", line 24, in voc.train(featlist, 122, 10) File "/opt/conda/lib/python3.8/site-packages/PCV/imagesearch/vocabulary.py", line 24, in train descr.append(sift.read_features_from_file(featurefiles[0])[1]) File "/opt/conda/lib/python3.8/site-packages/PCV/localdescriptors/sift.py", line 26, in read_features_from_file return f[:,:4],f[:,4:] # feature locations, descriptors IndexError: too many indices for array: array is 1-dimensional, but 2 were indexed

I'm not familiar with python, when I run the sample, it say: Traceback (most recent call last): File "/Users/leocone/Study/PCV/examples/ch1_morphology.py", line 1, in from PIL import Image ImportError: No module named PIL

https://github.com/prajwalkr/SnapSudoku/issues/3

It would be cool to get SnapSudoku running on the iPhone so that you could use the camera to do the snap and immediately solve the puzzle right on the phone. It would drive Sudoku players crazy if you could walk up with your smart phone, snap a picture of their puzzle, and show them the solution. Pythonista is a Python 2.7 and 3.5 IDE for iOS. Pythonista does support NumPy, Matplotlib, and Pillow (PIL) but does not yet support OpenCV or SciPy.

@jesolem @nico @The-Penultimate-Defenestrator

Your fix of Harris corner detector on Jan 23, 2013 would be wrong. According to Noble 1989, the corner measure is not det/trace^2, but det/trace. The original source code is right and the quotient on P.30 is wrong.

Thank you for consideration in advance.

There is a minor error in morphology.py, reported here: http://oreilly.com/catalog/errataunconfirmed.csp?isbn=0636920022923

In the above post, the reporter fixed the problem by replacing the original line

 im = 1*(im<128)

with

 im = (im<128)

while I fixed the problem by replacing the line with

 im = 1.0*(im<128)

not sure which is more appropriate/robust.

-Rich Signell

I took the liberty of removing the *.pyc files from your repo and adding a suitable .gitignore; nothing fancy. I also took the liberty of converting all of your tabs in source files to 4 spaces. This is obviously not essential, but python always looks better to me that way.

Hello, thanks of your contribution about such good work. I am using graph neural network to parcel brain region, however the result is not good, I want to use graph cut as post process. The inputs of my current model are: adjacency matrix (10242, 10242), feature matrix (10242, 6), label matrix (10242). The output is the probability y that each node belongs to a label, and its dimension is (10242, 36) I want to use graph cut to update y for better performance.

I have a few questions about your code: First, it seems that your code is only for two categories. Can you do multi label tasks? Second, if I want to do post-processing, what should my input be?

Hello, I am working on image feature matching and I started following the code examples of the PCV book. the following code `imname1 = './data/sample1.jpg' imname2 = './data/sample2.jpg'

process and save features to file

sift.process_image(imname1, 'sample1.sift') sift.process_image(imname2, 'sample2.sift')works fine and I get a message when done _" processed tmp.pgm to sample1.sift" "processed tmp.pgm to sample2.sift"_ but when I am trying to use thisl1, d1 = sift.read_features_from_file('sample1.sift') l2, d2 = sift.read_features_from_file('sample2.sift') matchscores = sift.match_twosided(d1, d2)` I get an OSError that says sample.sift not found Can you help me?

There is a small typo in PCV/tools/imtools.py, pcv_book/imtools.py.

Should read function rather than funtion.

Semi-automated pull request generated by https://github.com/timgates42/meticulous/blob/master/docs/NOTE.md

Hello,

I downloaded shift and while executing (this is in reference to book "programming computer Vision with python" by author Jan Erik Solem)

what I need to do to resolve this...?

-Thanks -Alok

python examples/ch3_panorama.py Error: unknown flag `edge-thresh' processed tmp.pgm to ../data/Univ1.sift Traceback (most recent call last): File "examples/ch3_panorama.py", line 24, in l[i],d[i] = sift.read_features_from_file(featname[i]) File "/Users/akmishra/Development/python2.7/lib/python2.7/site-packages/PCV/localdescriptors/sift.py", line 25, in read_features_from_file f = loadtxt(filename) File "/Users/akmishra/Development/python2.7/lib/python2.7/site-packages/numpy/lib/npyio.py", line 962, in loadtxt fh = np.lib._datasource.open(fname, 'rt', encoding=encoding) File "/Users/akmishra/Development/python2.7/lib/python2.7/site-packages/numpy/lib/_datasource.py", line 266, in open return ds.open(path, mode, encoding=encoding, newline=newline) File "/Users/akmishra/Development/python2.7/lib/python2.7/site-packages/numpy/lib/_datasource.py", line 624, in open raise IOError("%s not found." % path) IOError: ../data/Univ1.sift not found.

Hello, when lauch the code with an image, according to Programing Computer visión book, i get the following issue:

ValueError: cannot reshape array of size 14 into shape (3)

please, could you help me? thanks