Hi,

When running against .co.uk domains this seems to be excluding contact information. (when searching 'google.co.uk' address information is included in raw output but not parsed by the code). I've also noticed it seems to be missing the "Registration status:" field too.

Thanks

Attempted to pull whois record for UK HE institutions as follows (for example):

pythonwhois.get_whois("imperial.ac.uk")

This responds with the whois record for "ac.uk" not "imperial.ac.uk". From the response data:

Domain name:\r\n        ac.uk

I guess you require explicit lists of supported extensions?

Noticing a lot of a open pull requests. Happy to join on maintenance, or to take over. Never done that before, so I'm not sure exactly the best process. This is a great library, I'd be happy to help. Let me know!

Sorry i'm new to python. I've done 'pip install pythonwhois' my current verison is - pythonwhois-2.4.3-py2.7.egg

Then i've written this python script to just do a WHOis lookup on "www.google.com"

I get this error running the script: AttributeError: 'module' object has no attribute 'get_whois'

It's not finding the get_whois function from the library. What am i missing?

_code_*

import pythonwhois

domain = "www.google.com" normalized = True

pythonwhois.get_whois(domain, True)

Looking up some IP addresses seems to lead to an UnicodeDecodeError:

>>> pythonwhois.get_whois('179.175.242.131')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/fsufitch/python-whois/pythonwhois/__init__.py", line 4, in get_whois
    raw_data, server_list = net.get_whois_raw(domain, with_server_list=True)
  File "/home/fsufitch/python-whois/pythonwhois/net.py", line 42, in get_whois_raw
    response = whois_request(request_domain, target_server)
  File "/home/fsufitch/python-whois/pythonwhois/net.py", line 92, in whois_request
    return buff.decode("utf-8")
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xd4 in position 565: invalid continuation byte

Also:

>>> pythonwhois.get_whois('80.148.135.28')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/fsufitch/python-whois/pythonwhois/__init__.py", line 8, in get_whois
    return parse.parse_raw_whois(raw_data, normalized=normalized, never_query_handles=False, handle_server=server_list[-1])
  File "/home/fsufitch/python-whois/pythonwhois/parse.py", line 553, in parse_raw_whois
    data["contacts"] = parse_registrants(raw_data, never_query_handles, handle_server)
  File "/home/fsufitch/python-whois/pythonwhois/parse.py", line 894, in parse_registrants
    contact = fetch_nic_contact(data_reference["handle"], handle_server)
  File "/home/fsufitch/python-whois/pythonwhois/parse.py", line 981, in fetch_nic_contact
    response = net.get_whois_raw(handle, lookup_server)
  File "/home/fsufitch/python-whois/pythonwhois/net.py", line 42, in get_whois_raw
    response = whois_request(request_domain, target_server)
  File "/home/fsufitch/python-whois/pythonwhois/net.py", line 92, in whois_request
    return buff.decode("utf-8")
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xdf in position 706: invalid continuation byte

More IPs that break in this way:

• 177.169.129.223
• 80.148.135.28
• 181.1.55.141
• 91.6.97.224
• 179.246.105.144
• 94.92.58.77

I ran into this while testing a separate program on completely random IPs. To reproduce:

import ipaddress, random, traceback
import pythonwhois

randip = lambda: ipaddress.ip_address(random.randint(0,256**4-1)).compressed

for i in range(50):
   ip = randip()
   try:
       pythonwhois.get_whois(ip)
   except UnicodeDecodeError as e:
       print('========', ip, '========')
       traceback.print_exc()
   except Exception as e:
       continue

Thanks!

I can use this module to lookup ASN, but sometimes encountered errors: (1) AS4515 - No root WHOIS server found for domain (2) AS2706 - No root WHOIS server found for domain

Please have a look, thanks.

You seem to query whois.denic.de for the .de TLD. Unfortunately no data is received by your module as you're lacking the -T dn,ace -C US-ASCII string before the actually domain to query.

You can easily check the behaviour through echo "-T dn,ace -C US-ASCII test.de" | nc whois.denic.de 43 and echo "test.de" | nc whois.denic.de 43

Added domain test.de to test-cases as this very domain is unlikely to change over time due to the state-sponsored organisation behind.

Test-cases are green and I guess there is no need to print the whole output there considered the case that this change is a quite trivial one. I do hope you agree :smile:

After seeing some strange behavior while trying to write unittests for my script which uses python-whois, I thought I would go ahead and submit this patch. This PR addresses a comment made here:

https://github.com/joepie91/python-whois/commit/d86e4ba9166e80b8c66b093b355f3c32e94c0229#commitcomment-6967148

This stackoverflow question covers the topic pretty well: “Least Astonishment” in Python: The Mutable Default Argument

From docs.python.org:

Default parameter values are evaluated when the function definition is executed. This means that the expression is evaluated once, when the function is defined, and that the same “pre-computed” value is used for each call. This is especially important to understand when a default parameter is a mutable object, such as a list or a dictionary: if the function modifies the object (e.g. by appending an item to a list), the default value is in effect modified. This is generally not what was intended. A way around this is to use None as the default, and explicitly test for it in the body of the function

https://docs.python.org/2/reference/compound_stmts.html#function-definitions

It does not appear python-whois has Python 3.x support. As 3.x grows more commonplace, this will become a serious obstacle to adoption.

Some problems I ran into:

~/python-whois$ python3 pwhois
  File "pwhois", line 6
    except ImportError, e:
                      ^
SyntaxError: invalid syntax


~/python-whois$ python3
Python 3.4.0 (default, Apr 11 2014, 13:05:11) 
[GCC 4.8.2] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from pythonwhois import get_whois
>>> get_whois('google.com')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/fsufitch/python-whois/pythonwhois/__init__.py", line 4, in get_whois
    raw_data = net.get_whois_raw(domain)
  File "/home/fsufitch/python-whois/pythonwhois/net.py", line 15, in get_whois_raw
    domain = encode( domain if type(domain) is unicode else decode(domain, "utf8"),    "idna" )
NameError: name 'unicode' is not defined

There may be other problems too, but I do not have the time to conduct a code review of it right now.

Thanks for looking into this! I really wanted to use pythonwhois but my project is unfortunately python3-only.

The parser cannot parse the following whois domains:

• .co.th like starbucks.co.th
• .ir like nic.ir
• .com like servequake.com
• .com.mx like expopack.com.mx (already referred to issue #22 )

Edit: I'll add non-working tlds with example domains to this post.

This is similar to issue #2. The call takes ~400s to complete; if interrupted, the traceback is somewhere is re module.

>>> import pythonwhois
>>> pythonwhois.get_whois('drpciv.biz')
^CTraceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "[...]/lib/python2.7/site-packages/pythonwhois/__init__.py", line 5, in get_whois
    return parse.parse_raw_whois(raw_data, normalized=normalized)
  File "[...]/lib/python2.7/site-packages/pythonwhois/parse.py", line 255, in parse_raw_whois
    data["contacts"] = parse_registrants(raw_data)
  File "[...]/lib/python2.7/site-packages/pythonwhois/parse.py", line 639, in parse_registrants
    match = re.search(regex, segment)
  File "[...]/lib/python2.7/re.py", line 148, in search
    return _compile(pattern, flags).search(string)
KeyboardInterrupt