MoinMoin Wiki Development (2.0+), unstable, for production please use 1.9.x.

Hello

When we write @ in code, for example:

{{{ [email protected] }}}

we push OK button and the Server return 500 Internal error:

Internal Server Error The server encountered an internal error and was unable to complete your request. Either the server is overloaded or there is an error in the application.

2018-10-31 14:16:07,565 ERROR flask.app:1761 Exception on /+modify/Home/Customer/Orange/OP018438/Syslog-NG [POST] Traceback (most recent call last): File "k:\moin-master-venv-python\lib\site-packages\flask\app.py", line 2292, in wsgi_app response = self.full_dispatch_request() File "k:\moin-master-venv-python\lib\site-packages\flask\app.py", line 1815, in full_dispatch_request rv = self.handle_user_exception(e) File "k:\moin-master-venv-python\lib\site-packages\flask\app.py", line 1718, in handle_user_exception reraise(exc_type, exc_value, tb) File "k:\moin-master-venv-python\lib\site-packages\flask\app.py", line 1813, in full_dispatch_request rv = self.dispatch_request() File "k:\moin-master-venv-python\lib\site-packages\flask\app.py", line 1799, in dispatch_request return self.view_functionsrule.endpoint File "k:\moin-master\src\moin\apps\frontend\views.py", line 721, in modify_item return crash(item, None, None) File "k:\moin-master\src\moin\apps\frontend\views.py", line 2142, in crash item=item, File "k:\moin-master\src\moin\themes_init.py", line 55, in render_template return render_theme_template(get_current_theme(), template, **context) File "k:\moin-master-venv-python\lib\site-packages\flask_theme_init.py", line 470, in render_theme_template return render_template(template_name, **context) File "k:\moin-master-venv-python\lib\site-packages\flask\templating.py", line 135, in render_template context, ctx.app) File "k:\moin-master-venv-python\lib\site-packages\flask\templating.py", line 117, in _render rv = template.render(context) File "k:\moin-master-venv-python\lib\site-packages\jinja2\environment.py", line 1008, in render return self.environment.handle_exception(exc_info, True) File "k:\moin-master-venv-python\lib\site-packages\jinja2\environment.py", line 780, in handle_exception reraise(exc_type, exc_value, tb) File "k:\moin-master\src\moin\templates\crash_view.html", line 5, in top-level template code {% extends theme("show.html") %} File "k:\moin-master\src\moin\themes\basic\templates\show.html", line 8, in top-level template code {% set footer_meta = snippets.footer_meta() %} File "k:\moin-master\src\moin\themes\basic\templates\layout.html", line 57, in top-level template code

File "k:\moin-master\src\moin\templates\base.html", line 67, in top-level template code {%- block layout %} File "k:\moin-master\src\moin\themes\basic\templates\layout.html", line 204, in block "layout" {% block content %} File "k:\moin-master\src\moin\templates\crash_view.html", line 8, in block "content" {% include "crash.html" %} File "k:\moin-master\src\moin\templates\crash.html", line 12, in top-level template code

{{ server_time }}

File "k:\moin-master-venv-python\lib\site-packages\markupsafe_native.py", line 22, in escape return Markup(text_type(s) UnicodeDecodeError: 'ascii' codec can't decode byte 0xe1 in position 28: ordinal not in range(128)

In previous versions is working fine, but I don't know to begin the issue.

Original report by Thomas Waldmann (Bitbucket: thomaswaldmann, GitHub: thomaswaldmann).

currently, meta[NAME] has a single unicode value (the item name).

it could be changed to be a list of unicode item names.

all these names would be valid names for the item, maybe with some preference on the first one (e.g. if we need to display the name).

like for tags, searching for name_exact:foo would automatically search the list for a member "foo".

practically, this would make the following stuff possible:

• having "alias names" for items
• make same thing show up at multiple places (like hardlinks in file system)
• not needing redirect items if you "rename" an item (== add another name to the list) that is linked from other items or from the outside
• the name list could have zero elements, making the item somehow vanish from the surface (namespace, index) and be "deleted" (but still being there in storage, just not having a name, but still an itemid, revisions, etc.). the name(s) it had before can still be fetched from its parent revision.

This happened after installing python 3.8.3, downloading a fresh clone of moin, and executing python quickinstall.py on an old PC running Windows 10.

This issue not present on another PC running Windows 10 with python 3.8.3.

Obtaining file:///C:/git/moin
    ERROR: Command errored out with exit status 1:
     command: 'c:\git\moin-venv-python\scripts\python.exe' -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\git\\moin\\setup.py'"'"'; __file__='"'"'C:\\git\\moin\\setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info
         cwd: C:\git\moin\
    Complete output (33 lines):
    C:\Python38\lib\distutils\dist.py:274: UserWarning: Unknown distribution option: 'message_extractors'
      warnings.warn(msg)
    c:\git\moin\.eggs\setuptools_scm-5.0.1-py3.8.egg\setuptools_scm\version.py:88: UserWarning: tag 'moin20-repo-reboot' no version found
      warnings.warn("tag {!r} no version found".format(tag))
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "C:\git\moin\setup.py", line 141, in <module>
        setup(**setup_args)
      File "c:\git\moin-venv-python\lib\site-packages\setuptools\__init__.py", line 145, in setup
        return distutils.core.setup(**attrs)
      File "C:\Python38\lib\distutils\core.py", line 108, in setup
        _setup_distribution = dist = klass(attrs)
      File "c:\git\moin-venv-python\lib\site-packages\setuptools\dist.py", line 445, in __init__
        _Distribution.__init__(self, {
      File "C:\Python38\lib\distutils\dist.py", line 292, in __init__
        self.finalize_options()
      File "c:\git\moin-venv-python\lib\site-packages\setuptools\dist.py", line 734, in finalize_options
        ep.load()(self, ep.name, value)
      File "c:\git\moin\.eggs\setuptools_scm-5.0.1-py3.8.egg\setuptools_scm\integration.py", line 26, in version_keyword
        dist.metadata.version = _get_version(config)
      File "c:\git\moin\.eggs\setuptools_scm-5.0.1-py3.8.egg\setuptools_scm\__init__.py", line 173, in _get_version
        parsed_version = _do_parse(config)
      File "c:\git\moin\.eggs\setuptools_scm-5.0.1-py3.8.egg\setuptools_scm\__init__.py", line 127, in _do_parse
        version = _version_from_entrypoints(config) or _version_from_entrypoints(
      File "c:\git\moin\.eggs\setuptools_scm-5.0.1-py3.8.egg\setuptools_scm\__init__.py", line 65, in _version_from_entrypoints
        version = _call_entrypoint_fn(root, config, ep.load())
      File "c:\git\moin\.eggs\setuptools_scm-5.0.1-py3.8.egg\setuptools_scm\__init__.py", line 46, in _call_entrypoint_fn
        return fn(root, config=config)
      File "c:\git\moin\.eggs\setuptools_scm-5.0.1-py3.8.egg\setuptools_scm\git.py", line 133, in parse
        return meta(
      File "c:\git\moin\.eggs\setuptools_scm-5.0.1-py3.8.egg\setuptools_scm\version.py", line 212, in meta
        assert parsed_version is not None, "Can't parse version %s" % tag
    AssertionError: Can't parse version moin20-repo-reboot
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
WARNING: You are using pip version 19.2.3, however version 20.3.3 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command.

Original report by RogerHaase (Bitbucket: RogerHaase, GitHub: RogerHaase).

The original report had attachments: destroy.txt, DestroyTraceback.txt

Upon occasion, when an attempt is made to destroy an item via the global index or global history page, Windows 7 reports that "The process cannot access the file because it is being used by another process."

See attached file destroy.txt.

Original report by buzmakov (Bitbucket: buzmakov, GitHub: buzmakov).

The original report had attachments: wikiconfig.py

When I try to go on page wich contain cyrillic symbols like http://localhost:8080/Домашняя moin2 raise "UnicodeEncodeError" Full stacktrace:

UnicodeEncodeError
UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-2: ordinal not in range(128)

Traceback (most recent call last)
File "/home/makov/opt/moin-2.0/env/lib/python2.7/site-packages/flask/app.py", line 1518, in __call__
return self.wsgi_app(environ, start_response)
File "/home/makov/opt/moin-2.0/env/lib/python2.7/site-packages/flask/app.py", line 1506, in wsgi_app
response = self.make_response(self.handle_exception(e))
File "/home/makov/opt/moin-2.0/env/lib/python2.7/site-packages/flask/app.py", line 1504, in wsgi_app
response = self.full_dispatch_request()
File "/home/makov/opt/moin-2.0/env/lib/python2.7/site-packages/flask/app.py", line 1264, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/makov/opt/moin-2.0/env/lib/python2.7/site-packages/flask/app.py", line 1262, in full_dispatch_request
rv = self.dispatch_request()
File "/home/makov/opt/moin-2.0/env/lib/python2.7/site-packages/flask/app.py", line 1248, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File "/home/makov/opt/moin-2.0/MoinMoin/apps/frontend/views.py", line 197, in show_item
flaskg.user.addTrail(item_name)
File "/home/makov/opt/moin-2.0/MoinMoin/user.py", line 652, in addTrail
item_name = getInterwikiName(item_name)
File "/home/makov/opt/moin-2.0/MoinMoin/util/interwiki.py", line 135, in getInterwikiName
return "{0}:{1}".format(app.cfg.interwikiname, item_name)
UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-2: ordinal not in range(128)

Original report by RogerHaase (Bitbucket: RogerHaase, GitHub: RogerHaase).

The original report had attachments: quickinstall.txt, setup.py

New Windows based user li yan has a failing quickinstall, see attached file quickinstall.txt.

Quickinstall is failing to install pdfminer, then omits the download for ~18 packages, then omits running setup for ~39 packages, then more or less completes successfully:

Downloading/unpacking pdfminer (from moin==2.0.0a0)
      Could not find a version that satisfies the requirement pdfminer (from moin==2.0.0a0)
          (from versions: [20100829 (bb)](https://bitbucket.org/thomaswaldmann/moin-2.0/commits/20100829), [20101226 (bb)](https://bitbucket.org/thomaswaldmann/moin-2.0/commits/20101226), [20091219 (bb)](https://bitbucket.org/thomaswaldmann/moin-2.0/commits/20091219), [20100213 (bb)](https://bitbucket.org/thomaswaldmann/moin-2.0/commits/20100213), [20100327 (bb)](https://bitbucket.org/thomaswaldmann/moin-2.0/commits/20100327), [20100424 (bb)](https://bitbucket.org/thomaswaldmann/moin-2.0/commits/20100424), [20100322 (bb)](https://bitbucket.org/thomaswaldmann/moin-2.0/commits/20100322),
          [20101017 (bb)](https://bitbucket.org/thomaswaldmann/moin-2.0/commits/20101017), [20100104 (bb)](https://bitbucket.org/thomaswaldmann/moin-2.0/commits/20100104), [20110227 (bb)](https://bitbucket.org/thomaswaldmann/moin-2.0/commits/20110227), [20091129 (bb)](https://bitbucket.org/thomaswaldmann/moin-2.0/commits/20091129), [20091024 (bb)](https://bitbucket.org/thomaswaldmann/moin-2.0/commits/20091024), [20100131 (bb)](https://bitbucket.org/thomaswaldmann/moin-2.0/commits/20100131), 20100619p1, [20110515 (bb)](https://bitbucket.org/thomaswaldmann/moin-2.0/commits/20110515),
          dist-20080727, dist-20090201, dist-20080629, dist-20080429, dist-20080906,
          dist-20090110, dist-20090517, dist-20090117)
      Cleaning up...
    No distributions matching the version for pdfminer (from moin==2.0.0a0)
    Storing complete log in C:\Documents and Settings\Administrator\pip\pip.log
    Compiling translations (not required if wiki is English only) ...
    running compile_catalog

A clue may be these "real name" messages that I do not see on my Windows 7 quickinstall output.:

  Real name of requirement babel is Babel
  Real name of requirement pytest-pep8 is pytest-pep8
  Real name of requirement sphinx is Sphinx

In addition to fixing whatever is wrong with pdfminer, maybe:

• change install docs to suggest "quickinstall > quickinstall.txt"
• have an example of text output from a successful quickinstall
• have an example of output dlc and env directory structure
• have a post process that checks quickinstall.txt for strings like:
  • Could not find
  • error
  • fail
  • traceback
  • timeout
• have a post process that checks for key files in env directory

(When needed, the post processes should output a clear FAILURE message as the last message).

Original report by ishayahu_lastov (Bitbucket: ishayahu_lastov, GitHub: Unknown).

I try this code:

#!wiki

{{attachment:Switch.jpg||width=50}}

but image has still the same size like without "width=50" example

Original report by Thomas Waldmann (Bitbucket: thomaswaldmann, GitHub: thomaswaldmann).

for the wiki, the url needs to identify a resource the code operates on then.

usually we used to give a name to identify a wiki item (and default to latest revision). or, a name plus a revision, to identify a specific revision.

the indexing layer (using whoosh) then uses this data to look up the revid we need to give to the backend.

we could generalize this idea so that the url just gives SOMETHING we can give to whoosh to identify the object(s) we want.

could be:

itemid:...
revid:...
name_exact:... (default)

(every unique key would work to indentify a single object)

if the lookup gives more than one result, we maybe could show a selection, so the user can choose what he wanted, e.g.:

tags:...
userid:... (revs edited by this userid)
language:... (all items in that language)
content:... (show all items with that content
itemlinks:...
itemtransclusions:...

Original report by RogerHaase (Bitbucket: RogerHaase, GitHub: RogerHaase).

If wiki admin changes name of start page by adding

item_root = "FrontPage"

to wikiconfig, then Navibar link should say FrontPage, not Home.

Original report by Reimar Bauer (Bitbucket: ReimarBauer, GitHub: ReimarBauer).

For hierarchical acls it is important to know what a subitem of an item is. This is only based on the name currently. Is that correct? Because at setting up hacl it is done on items uuid mapping to the names in the hierarchy. If the item has more than one name, which are the valid rights? How does it work if an item has a name and a subitem name?

That looks rather complex now. May be we should replace hacl by something like range acls? By that we could setup in meta the ids of the items which have same rights as the item where we have acls defined.

Converting Pages/Attachments...

Traceback (most recent call last):
  File "c:\GIT\moin-venv-python\Scripts\moin-script.py", line 11, in <module>
    load_entry_point('moin', 'console_scripts', 'moin')()
  File "c:\git\moin\src\moin\scripts\__init__.py", line 59, in main
    return manager.run(default_command=default_command)
  File "c:\git\moin-venv-python\lib\site-packages\flask_script\__init__.py", line 417, in run
    result = self.handle(argv[0], argv[1:])
  File "c:\git\moin-venv-python\lib\site-packages\flask_script\__init__.py", line 386, in handle
    res = handle(*args, **config)
  File "c:\git\moin-venv-python\lib\site-packages\flask_script\commands.py", line 216, in __call__
    return self.run(*args, **kwargs)
  File "c:\git\moin\src\moin\scripts\migration\moin19\import19.py", line 105, in run
    for rev in PageBackend(data_dir, deleted_mode=DELETED_MODE_KILL, default_markup='wiki'):
  File "c:\git\moin\src\moin\scripts\migration\moin19\import19.py", line 206, in __iter__
    itemname = unquoteWikiname(f)
  File "c:\git\moin\src\moin\scripts\migration\moin19\_utils19.py", line 135, in unquoteWikiname
    for needle in QUOTED.finditer(filename):
TypeError: <moin.scripts.migration.moin19.import19.ImportMoin19 object at 0x0000029A13F49A08>: cannot use a string pattern on a bytes-like object

Hi, I had to update a xstatic package, and added there a toml definition too. Take it as an example if needed https://github.com/ReimarBauer/xstatic-font-awesome

greetings Reimar

doctype string has been changed to lowercase in Werkzeug 2.1.2, see https://github.com/pallets/werkzeug/pull/2391/files

The if statement in line 42 is a workaround to allow all versions and can be removed when 2.1.2 is minimum version in setup.py.

Prepare for Werkzeug 2.x and related to #1109.

These packages were updated: pytz, setuptools, pycryptodome, lxml, greenlet, chardet, sqlalchemy by running "m quickinstall".

These warning were logged after running tests:

C:\GIT\moin.tox\py310\lib\site-packages\flask_caching_init_.py:158: DeprecationWarning: Using the initialization functions in flask_caching.backend is deprecated. Use the a full path to backend classes directly. warnings.warn(

.tox/py310/lib/site-packages/moin/apps/frontend/_tests/test_frontend.py: 124 warnings C:\GIT\moin.tox\py310\lib\site-packages\moin\themes\topside\templates\layout.html:153: DeprecationWarning: 'soft_unicode' has been renamed to 'soft_str'. The old name will be removed in MarkupSafe 2.1.

.tox/py310/lib/site-packages/moin/storage/stores/_tests/test_fs.py::test_create[BytesStore] C:\GIT\moin.tox\py310\lib\site-packages_pytest\python.py:199: PytestReturnNotNoneWarning: Expected None, but .tox/py310/lib/site-packages/moin/storage/stores/_tests/test_fs.py::test_create[BytesStore] returned <moin.storage.stores.fs.BytesStore object at 0x0000011279CA3610>, which will be an error in a future version of pytest. Did you mean to use assert instead of return? warnings.warn(

.tox/py310/lib/site-packages/moin/storage/stores/_tests/test_fs.py::test_create[FileStore] C:\GIT\moin.tox\py310\lib\site-packages_pytest\python.py:199: PytestReturnNotNoneWarning: Expected None, but .tox/py310/lib/site-packages/moin/storage/stores/_tests/test_fs.py::test_create[FileStore] returned <moin.storage.stores.fs.FileStore object at 0x0000011279D6B400>, which will be an error in a future version of pytest. Did you mean to use assert instead of return? warnings.warn(

.tox/py310/lib/site-packages/moin/storage/stores/_tests/test_memory.py::test_create[BytesStore] C:\GIT\moin.tox\py310\lib\site-packages_pytest\python.py:199: PytestReturnNotNoneWarning: Expected None, but .tox/py310/lib/site-packages/moin/storage/stores/_tests/test_memory.py::test_create[BytesStore] returned <moin.storage.stores.memory.BytesStore object at 0x0000011279A92B00>, which will be an error in a future version of pytest. Did you mean to use assert instead of return? warnings.warn(

.tox/py310/lib/site-packages/moin/storage/stores/_tests/test_memory.py::test_create[FileStore] C:\GIT\moin.tox\py310\lib\site-packages_pytest\python.py:199: PytestReturnNotNoneWarning: Expected None, but .tox/py310/lib/site-packages/moin/storage/stores/_tests/test_memory.py::test_create[FileStore] returned <moin.storage.stores.memory.FileStore object at 0x00000112799E9AE0>, which will be an error in a future version of pytest. Did you mean to use assert instead of return? warnings.warn(

.tox/py310/lib/site-packages/moin/storage/stores/_tests/test_sqla.py::test_create[BytesStore] C:\GIT\moin.tox\py310\lib\site-packages_pytest\python.py:199: PytestReturnNotNoneWarning: Expected None, but .tox/py310/lib/site-packages/moin/storage/stores/_tests/test_sqla.py::test_create[BytesStore] returned <moin.storage.stores.sqla.BytesStore object at 0x000001127860C670>, which will be an error in a future version of pytest. Did you mean to use assert instead of return? warnings.warn(

.tox/py310/lib/site-packages/moin/storage/stores/_tests/test_sqla.py::test_create[FileStore] C:\GIT\moin.tox\py310\lib\site-packages_pytest\python.py:199: PytestReturnNotNoneWarning: Expected None, but .tox/py310/lib/site-packages/moin/storage/stores/_tests/test_sqla.py::test_create[FileStore] returned <moin.storage.stores.sqla.FileStore object at 0x0000011279C32D10>, which will be an error in a future version of pytest. Did you mean to use assert instead of return? warnings.warn(

.tox/py310/lib/site-packages/moin/storage/stores/_tests/test_sqlite.py::test_create[bytes_uncompressed] C:\GIT\moin.tox\py310\lib\site-packages_pytest\python.py:199: PytestReturnNotNoneWarning: Expected None, but .tox/py310/lib/site-packages/moin/storage/stores/_tests/test_sqlite.py::test_create[bytes_uncompressed] returned <moin.storage.stores.sqlite.BytesStore object at 0x0000011279C33C40>, which will be an error in a future version of pytest. Did you mean to use assert instead of return? warnings.warn(

.tox/py310/lib/site-packages/moin/storage/stores/_tests/test_sqlite.py::test_create[bytes_compressed] C:\GIT\moin.tox\py310\lib\site-packages_pytest\python.py:199: PytestReturnNotNoneWarning: Expected None, but .tox/py310/lib/site-packages/moin/storage/stores/_tests/test_sqlite.py::test_create[bytes_compressed] returned <moin.storage.stores.sqlite.BytesStore object at 0x00000112798B82E0>, which will be an error in a future version of pytest. Did you mean to use assert instead of return? warnings.warn(

.tox/py310/lib/site-packages/moin/storage/stores/_tests/test_sqlite.py::test_create[file_uncompressed] C:\GIT\moin.tox\py310\lib\site-packages_pytest\python.py:199: PytestReturnNotNoneWarning: Expected None, but .tox/py310/lib/site-packages/moin/storage/stores/_tests/test_sqlite.py::test_create[file_uncompressed] returned <moin.storage.stores.sqlite.FileStore object at 0x0000011279BB85E0>, which will be an error in a future version of pytest. Did you mean to use assert instead of return? warnings.warn(

.tox/py310/lib/site-packages/moin/storage/stores/_tests/test_sqlite.py::test_create[file_compressed] C:\GIT\moin.tox\py310\lib\site-packages_pytest\python.py:199: PytestReturnNotNoneWarning: Expected None, but .tox/py310/lib/site-packages/moin/storage/stores/_tests/test_sqlite.py::test_create[file_compressed] returned <moin.storage.stores.sqlite.FileStore object at 0x0000011279798970>, which will be an error in a future version of pytest. Did you mean to use assert instead of return? warnings.warn(

From .tox/log/GLOB-0.log:

C:\GIT\moin-venv-python\lib\site-packages\setuptools\installer.py:27: SetuptoolsDeprecationWarning: setuptools.installer is deprecated. Requirements should be satisfied by a PEP 517 installer.

In addition to https://github.com/moinwiki/moin/issues/1298: Converting to Docbook seems to fail in general with no further info given. There also seem to be some general errors when converting that pop up multiple times, like stylings being added as plaintext instead of applied when converting moinwiki to markdown, the image issues mentioned in https://github.com/moinwiki/moin/issues/1298 or missing newlines when converting moin/creole to ReST.

Are these issues part of not yet implemented features or issues of the converter itself?

M. Scott Reynolds reports on moin-devel mailing list:

Tue, Aug 23 at 12:34 PM

I tried importing a 1.9 Moin wiki into a fresh development install of Moin2, and while it appears to have successfully imported most of the pages, the performance is horrible! There are nearly 400 pages that were imported, and selecting any of them can take 5 seconds or more before rendering. The 1.9 setup is just fine. And the Moin2 setup is fine, when it is empty.

<-snip->

I ran at the command prompt, "moin index-optimize" and that fixed it!

Change docs to suggest running moin index-optimize after import, or run moin index-optimize automatically.