I'm running into an issue today getting Filebrowser running in my project. I've got it configures in all locations according to the docs for settings and urls. The only thing different about my setup is that I'm using django-storages with s3boto for our media. I have sites.storage set accordingly.

This is the traceback I'm getting when trying to run the filebrowser tests:

$ ./manage.py test filebrowser Traceback (most recent call last): File "./manage.py", line 14, in execute_manager(settings) File "/Users/greg/.virtualenvs/newyork.com/lib/python2.6/site-packages/django/core/management/init.py", line 438, in execute_manager utility.execute() File "/Users/greg/.virtualenvs/newyork.com/lib/python2.6/site-packages/django/core/management/init.py", line 379, in execute self.fetch_command(subcommand).run_from_argv(self.argv) File "/Users/greg/.virtualenvs/newyork.com/lib/python2.6/site-packages/django/core/management/base.py", line 191, in run_from_argv self.execute(_args, *_options.dict) File "/Users/greg/.virtualenvs/newyork.com/lib/python2.6/site-packages/django/core/management/base.py", line 220, in execute output = self.handle(_args, *_options) File "/Users/greg/.virtualenvs/newyork.com/lib/python2.6/site-packages/south/management/commands/test.py", line 8, in handle super(Command, self).handle(_args, *_kwargs) File "/Users/greg/.virtualenvs/newyork.com/lib/python2.6/site-packages/django/core/management/commands/test.py", line 37, in handle failures = test_runner.run_tests(test_labels) File "/Users/greg/.virtualenvs/newyork.com/lib/python2.6/site-packages/django/test/simple.py", line 358, in run_tests suite = self.build_suite(test_labels, extra_tests) File "/Users/greg/.virtualenvs/newyork.com/lib/python2.6/site-packages/django/test/simple.py", line 248, in build_suite suite.addTest(build_suite(app)) File "/Users/greg/.virtualenvs/newyork.com/lib/python2.6/site-packages/django/test/simple.py", line 77, in build_suite test_module = get_tests(app_module) File "/Users/greg/.virtualenvs/newyork.com/lib/python2.6/site-packages/django/test/simple.py", line 35, in get_tests test_module = import('.'.join(app_path + [TEST_MODULE]), {}, {}, TEST_MODULE) File "/Users/greg/.virtualenvs/newyork.com/src/django-filebrowser/filebrowser/tests/init.py", line 2, in from filebrowser.tests.base import FileObjectPathTests, FileObjectVersionTests, FileObjectUnicodeTests File "/Users/greg/.virtualenvs/newyork.com/src/django-filebrowser/filebrowser/tests/base.py", line 17, in from filebrowser.sites import site File "/Users/greg/.virtualenvs/newyork.com/src/django-filebrowser/filebrowser/sites.py", line 524, in site = FileBrowserSite(name='filebrowser') File "/Users/greg/.virtualenvs/newyork.com/src/django-filebrowser/filebrowser/sites.py", line 109, in init self.directory = DIRECTORY File "/Users/greg/.virtualenvs/newyork.com/src/django-filebrowser/filebrowser/sites.py", line 118, in _directory_set raise ImproperlyConfigured("Directory '%(dir)s' for the site %(app_name)s.%(name)s does not exist." % {'dir': val, 'app_name': self.app_name, 'name': self.name}) django.core.exceptions.ImproperlyConfigured: Directory '/Users/greg/dev/newyork.com/newyork/../static/filebrowser/' for the site filebrowser.filebrowser does not exist.

This PR enables the usage of django-filebrowser with django-image-cropping, as proposed in #313.

There's another PR to the django-image-cropping project in order to provide the other side of the integration, with django-filebrowser as an backend.

Highlights:

1. Replaces the direct call to utils.scale_and_crop by a stack of "processor functions" that are configurable on settings using FILEBROWSER_PROCESSORS, with the default pointing to scale_and_crop.
2. Allow override the FileBrowseWidget using Admin.formfield_overrides param widget.
3. FileBrowseWidget now renders data-* attributes on the <input> tag.
4. FileObject.version_generate param version_suffix is not required to be in VERSIONS anymore, any suffix should work, if the new extra_options param contains enough data to generate a version.
5. New concept of namers to delegate the construction of a version filename, and deconstruct a version filename back to the original. The FILEBROWSER_VERSION_NAMER setting points to the default namer filebrowser.namers.VersionNamer.
6. namers.VersionNamer: A namer that acts like the current behaviour of django-filebrowser, generating names based on the VERSIONS dict and version_suffix.
7. namers.OptionsNamer: A namer that generates an unique name using the options provided to the FileObject.version_generate and the options in VERSIONS if an version_suffix is provided. Restores the original file name wipping out the last _version_suffix--plus-any-configs block entirely.
8. Replaces FileObject.is_version verfification to only verify if the file is in VERSIONS_BASEDIR since with the namers there's no guarantee that the version file name is a subset of VERSIONS keys.

Motivations behind the design decisions:

1. FILEBROWSER_PROCESSORS is required in order to register the crop_corners processor. A processor that crops an image based on a box that is stored on ImageRadioFields.
2. Allow override the FileBrowseWidget is required because django-image-cropping has the custom widget mixin CropWidget that generates meta-data from the source image field (now allowing FileBrowserField) and put that meta-data into data-* attributes, requiring the FileBrowseWidget to render those attrs into the <input> tag.
3. Since django-image-cropping should potentially generates many versions from the same original source image, there's no concept of version_prefix, all information required to generate a version is on the call stack, so I created the extra_options to hold that data, that is mixed with the VERSION if version_suffix exists.
4. Any box (edges to generate a crop) should generate an unique file name, so the concept of namers was used. It's from the easy_thubnails.namers.

Please let me know what do you think, and anything that I could improve.

Best regards,

• Using the default site from filebrowser.versions.sites is equivalent to using the old one
• Using the default site from filebrowser.sites is a stripped down version without versions and admin thumbnails
• Both admin interfaces seem fully functional
• filebrowser.tests passing
• filebrowser.versions.tests.sites are failing, tests URL resolver don't work after moving the site to a different module.
• FileBrowserField is now a base class without previews, VersionFileBrowserField provided

I couldn't figure out how the test suite in sites.py actually work. They stopped working after moving the site to a versions module, the tests apparently can't resolve the installed site and fail with a KeyError on APP_NAME. The admin is fully functional though.

Can you help me making those tests pass? Also, tests for FileBrowserField are needed.

To install and test this branch:

• Adding filebrowser to INSTALLED_APPS and using the old filebrowser.sites.site on urls.py will provide a stripped down version
• Adding both filebrowser and filebrowser.versions to INSTALLED_APPS and using filebrowser.versions.sites.site will provide the equivalent of the current version
• VersionFileBrowserField is provided, FileBrowserField is now a base class without previewing functionality

I'm not sure if this is the intended behaviour or not. But right now it seems filebrowser is completely bypassing django's upload handlers. Looking at fileuploader.js it seems the content-type "application/octet-stream" causes this.

See line 358: https://github.com/django/django/blob/1.4.2/django/http/init.py

This isn't a problem for small uploads but uploading anything larger than a few MB's makes memory usage go through the roof.

Tests: ERROR ( ···· EEEEEE....FE.....EEE.................. ···· FAILED (failures=1, errors=11) ) Version: ( ···· FileBrowser 3.6.1, Grappelli 2.7.1, Django 1.8.3, ···· Python 2.7.6, Pillow 2.9.0 ) apt-get libraries for images/files: ( ···· libjpeg8, libjpeg8-dev, zlib1g-dev, libfreetype6, ···· libfreetype6-dev, libjpeg-turbo8, libjpeg-turbo8-dev, libpng12-dev )

SUMMARY

Filebrowser fails silently from GUI at generating versions (just 404 errors are seen when running python manage.py runserver). However, I can see the original image is uploaded to STATIC_ROOT/uploads - and accessible via web browser aiming to STATIC_URL -, but versions are not generated at STATIC_ROOT/_versions folder.

DETAILS

I'm not sure if I did anything wrong with myproject/settings.py, so here I post the relevant settings for django-filebrowser:

INSTALLED_APPS = (
    'grappelli',
    'filebrowser',
    'modeltranslation',
    # ...
)

FILEBROWSER_DIRECTORY = "static/uploads/"
FILEBROWSER_VERSIONS_BASEDIR = "static/_versions"
FILEBROWSER_VERSIONS = {
        'admin_thumbnail': {'verbose_name': 'Admin Thumbnail', 'width': 60, 'height': 60, 'opts': 'crop'},
        'thumbnail': {'verbose_name': 'Thumbnail (1 col)', 'width': 60, 'height': 60, 'opts': 'crop'},
        'small': {'verbose_name': 'Small (2 col)', 'width': 140, 'height': '', 'opts': ''},
        'medium': {'verbose_name': 'Medium (4col )', 'width': 300, 'height': '', 'opts': ''},
        'big': {'verbose_name': 'Big (6 col)', 'width': 460, 'height': '', 'opts': ''},
        'large': {'verbose_name': 'Large (8 col)', 'width': 680, 'height': '', 'opts': ''},

        # ...long story short...       

        'my_custom': {'verbose_name': 'Large (8 col)', 'width': 1202, 'height': 100, 'opts': 'crop'},
}

FILEBROWSER_DIRECTORY = "static/uploads/"
FILEBROWSER_VERSIONS_BASEDIR = "static/_versions"

STATICFILES_DIRS = (
       os.path.join(PROJECT_DIR, "static"),
       os.path.join(BASE_DIR, "static/admin/js"),
       os.path.join(BASE_DIR, "static/*"),
)

# XXX HACK This is ugly because it overrides the default behaviour
# ........ of Django, but it worked for me to fix Grappelli's GUI
STATICFILES_FINDERS = (
       'django.contrib.staticfiles.finders.AppDirectoriesFinder',
       'django.contrib.staticfiles.finders.FileSystemFinder',
)

When I perform the tests, the results seem completely catastrophic. It called my attention the fact that tests seem to be looking for PIL(which is deprecated and NOT installed in my machine):

('Creating Test for the FileBrowser site:', 'filebrowser')
Creating test database for alias 'default'...
EEEEEE....FE.....EEE..................
Select a version you want to generate:
 * large
 * admin_thumbnail
(leave blank to generate all versions): generating version "large" for: fb_test_directory/fb_tmp_dir/fb_tmp_dir_sub/testimage.jpg
E.
======================================================================
ERROR: runTest (filebrowser.tests.test_sites.TestSite_filebrowser)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/tests/test_sites.py", line 438, in runTest
    test_browse(self)
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/tests/test_sites.py", line 47, in test_browse
    response = test.c.get(url)
  File "/venvs/mdrcms/lib/python2.7/site-packages/django/test/client.py", line 500, in get
    **extra)
  File "/venvs/mdrcms/lib/python2.7/site-packages/django/test/client.py", line 303, in get
    return self.generic('GET', path, secure=secure, **r)
  File "/venvs/mdrcms/lib/python2.7/site-packages/django/test/client.py", line 379, in generic
    return self.request(**r)
  File "/venvs/mdrcms/lib/python2.7/site-packages/django/test/client.py", line 466, in request
    six.reraise(*exc_info)
  File "/venvs/mdrcms/lib/python2.7/site-packages/django/core/handlers/base.py", line 132, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/decorators.py", line 45, in decorator
    return function(request, *args, **kwargs)
  File "/venvs/mdrcms/lib/python2.7/site-packages/django/contrib/auth/decorators.py", line 22, in _wrapped_view
    return view_func(request, *args, **kwargs)
  File "/venvs/mdrcms/lib/python2.7/site-packages/django/views/decorators/cache.py", line 57, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/sites.py", line 349, in browse
    }, context_instance=Context(request, current_app=self.name))
  File "/venvs/mdrcms/lib/python2.7/site-packages/django/shortcuts.py", line 45, in render_to_response
    using=using)
  File "/venvs/mdrcms/lib/python2.7/site-packages/django/template/loader.py", line 116, in render_to_string
    template_name, context, context_instance, dirs, dictionary)
  File "/venvs/mdrcms/lib/python2.7/site-packages/django/template/engine.py", line 221, in render_to_string
    return t.render(context_instance)
  File "/venvs/mdrcms/lib/python2.7/site-packages/django/template/base.py", line 208, in render
    with context.bind_template(self):
  File "/usr/bin/python2.7.9/lib/python2.7/contextlib.py", line 17, in __enter__
    return self.gen.next()
  File "/venvs/mdrcms/lib/python2.7/site-packages/django/template/context.py", line 241, in bind_template
    updates.update(processor(self.request))
  File "/venvs/mdrcms/mdrcms/coreapp/context.py", line 11, in navbar
    current_siteman = SiteManager.objects.get(id=current_site.id)
  File "/venvs/mdrcms/lib/python2.7/site-packages/django/db/models/manager.py", line 127, in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
  File "/venvs/mdrcms/lib/python2.7/site-packages/django/db/models/query.py", line 334, in get
    self.model._meta.object_name
DoesNotExist: SiteManager matching query does not exist.

======================================================================
ERROR: test_scale_crop (filebrowser.tests.test_versions.VersionTemplateTagsTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/tests/test_versions.py", line 44, in setUp
    self.original_placeholder = filebrowser.templatetags.fb_versions.PLACEHOLDER
AttributeError: 'module' object has no attribute 'fb_versions'

======================================================================
ERROR: test_version (filebrowser.tests.test_versions.VersionTemplateTagsTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/tests/test_versions.py", line 44, in setUp
    self.original_placeholder = filebrowser.templatetags.fb_versions.PLACEHOLDER
AttributeError: 'module' object has no attribute 'fb_versions'

======================================================================
ERROR: test_version_as_object (filebrowser.tests.test_versions.VersionTemplateTagsTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/tests/test_versions.py", line 44, in setUp
    self.original_placeholder = filebrowser.templatetags.fb_versions.PLACEHOLDER
AttributeError: 'module' object has no attribute 'fb_versions'

======================================================================
ERROR: test_version_object (filebrowser.tests.test_versions.VersionTemplateTagsTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/tests/test_versions.py", line 44, in setUp
    self.original_placeholder = filebrowser.templatetags.fb_versions.PLACEHOLDER
AttributeError: 'module' object has no attribute 'fb_versions'

======================================================================
ERROR: test_version_setting (filebrowser.tests.test_versions.VersionTemplateTagsTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/tests/test_versions.py", line 44, in setUp
    self.original_placeholder = filebrowser.templatetags.fb_versions.PLACEHOLDER
AttributeError: 'module' object has no attribute 'fb_versions'

======================================================================
ERROR: test_delete (filebrowser.tests.test_base.FileObjectAttributeTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/tests/test_base.py", line 438, in test_delete
    f_version = self.f_image.version_generate("large")
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/base.py", line 506, in version_generate
    version_path = self._generate_version(version_suffix)
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/base.py", line 527, in _generate_version
    version = scale_and_crop(im, VERSIONS[version_suffix]['width'], VERSIONS[version_suffix]['height'], VERSIONS[version_suffix]['opts'])
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/utils.py", line 85, in scale_and_crop
    im = im.resize((int(math.ceil(x * r)), int(math.ceil(y * r))), resample=Image.ANTIALIAS)
  File "/venvs/mdrcms/lib/python2.7/site-packages/PIL/Image.py", line 1557, in resize
    self.load()
  File "/venvs/mdrcms/lib/python2.7/site-packages/PIL/ImageFile.py", line 203, in load
    d = Image._getdecoder(self.mode, d, a, self.decoderconfig)
  File "/venvs/mdrcms/lib/python2.7/site-packages/PIL/Image.py", line 420, in _getdecoder
    raise IOError("decoder %s not available" % decoder_name)
IOError: decoder jpeg not available

======================================================================
ERROR: test_version_attributes_1 (filebrowser.tests.test_base.FileObjectAttributeTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/tests/test_base.py", line 317, in test_version_attributes_1
    f_version = self.f_image.version_generate("large")
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/base.py", line 506, in version_generate
    version_path = self._generate_version(version_suffix)
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/base.py", line 527, in _generate_version
    version = scale_and_crop(im, VERSIONS[version_suffix]['width'], VERSIONS[version_suffix]['height'], VERSIONS[version_suffix]['opts'])
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/utils.py", line 85, in scale_and_crop
    im = im.resize((int(math.ceil(x * r)), int(math.ceil(y * r))), resample=Image.ANTIALIAS)
  File "/venvs/mdrcms/lib/python2.7/site-packages/PIL/Image.py", line 1557, in resize
    self.load()
  File "/venvs/mdrcms/lib/python2.7/site-packages/PIL/ImageFile.py", line 203, in load
    d = Image._getdecoder(self.mode, d, a, self.decoderconfig)
  File "/venvs/mdrcms/lib/python2.7/site-packages/PIL/Image.py", line 420, in _getdecoder
    raise IOError("decoder %s not available" % decoder_name)
IOError: decoder jpeg not available

======================================================================
ERROR: test_version_attributes_2 (filebrowser.tests.test_base.FileObjectAttributeTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/tests/test_base.py", line 362, in test_version_attributes_2
    f_version = self.f_image.version_generate("large")
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/base.py", line 506, in version_generate
    version_path = self._generate_version(version_suffix)
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/base.py", line 527, in _generate_version
    version = scale_and_crop(im, VERSIONS[version_suffix]['width'], VERSIONS[version_suffix]['height'], VERSIONS[version_suffix]['opts'])
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/utils.py", line 85, in scale_and_crop
    im = im.resize((int(math.ceil(x * r)), int(math.ceil(y * r))), resample=Image.ANTIALIAS)
  File "/venvs/mdrcms/lib/python2.7/site-packages/PIL/Image.py", line 1557, in resize
    self.load()
  File "/venvs/mdrcms/lib/python2.7/site-packages/PIL/ImageFile.py", line 203, in load
    d = Image._getdecoder(self.mode, d, a, self.decoderconfig)
  File "/venvs/mdrcms/lib/python2.7/site-packages/PIL/Image.py", line 420, in _getdecoder
    raise IOError("decoder %s not available" % decoder_name)
IOError: decoder jpeg not available

======================================================================
ERROR: test_version_attributes_3 (filebrowser.tests.test_base.FileObjectAttributeTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/tests/test_base.py", line 408, in test_version_attributes_3
    f_version = self.f_image.version_generate("large")
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/base.py", line 506, in version_generate
    version_path = self._generate_version(version_suffix)
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/base.py", line 527, in _generate_version
    version = scale_and_crop(im, VERSIONS[version_suffix]['width'], VERSIONS[version_suffix]['height'], VERSIONS[version_suffix]['opts'])
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/utils.py", line 85, in scale_and_crop
    im = im.resize((int(math.ceil(x * r)), int(math.ceil(y * r))), resample=Image.ANTIALIAS)
  File "/venvs/mdrcms/lib/python2.7/site-packages/PIL/Image.py", line 1557, in resize
    self.load()
  File "/venvs/mdrcms/lib/python2.7/site-packages/PIL/ImageFile.py", line 203, in load
    d = Image._getdecoder(self.mode, d, a, self.decoderconfig)
  File "/venvs/mdrcms/lib/python2.7/site-packages/PIL/Image.py", line 420, in _getdecoder
    raise IOError("decoder %s not available" % decoder_name)
IOError: decoder jpeg not available

======================================================================
ERROR: test_fb_version_generate (filebrowser.tests.test_commands.CommandsTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/tests/test_commands.py", line 99, in test_fb_version_generate
    call_command('fb_version_generate', 'fb_test_directory')
  File "/venvs/mdrcms/lib/python2.7/site-packages/django/core/management/__init__.py", line 120, in call_command
    return command.execute(*args, **defaults)
  File "/venvs/mdrcms/lib/python2.7/site-packages/django/core/management/base.py", line 444, in execute
    output = self.handle(*args, **options)
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/management/commands/fb_version_generate.py", line 68, in handle
    versionobject = fileobject.version_generate(selected_version)  # FIXME force?
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/base.py", line 506, in version_generate
    version_path = self._generate_version(version_suffix)
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/base.py", line 527, in _generate_version
    version = scale_and_crop(im, VERSIONS[version_suffix]['width'], VERSIONS[version_suffix]['height'], VERSIONS[version_suffix]['opts'])
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/utils.py", line 85, in scale_and_crop
    im = im.resize((int(math.ceil(x * r)), int(math.ceil(y * r))), resample=Image.ANTIALIAS)
  File "/venvs/mdrcms/lib/python2.7/site-packages/PIL/Image.py", line 1557, in resize
    self.load()
  File "/venvs/mdrcms/lib/python2.7/site-packages/PIL/ImageFile.py", line 203, in load
    d = Image._getdecoder(self.mode, d, a, self.decoderconfig)
  File "/venvs/mdrcms/lib/python2.7/site-packages/PIL/Image.py", line 420, in _getdecoder
    raise IOError("decoder %s not available" % decoder_name)
IOError: decoder jpeg not available

======================================================================
FAIL: test_walk (filebrowser.tests.test_base.FileListingTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/venvs/mdrcms/lib/python2.7/site-packages/filebrowser/tests/test_base.py", line 584, in test_walk
    self.assertEqual(list(f.path for f in self.f_listing.files_walk_total()), [u'fb_test_directory/testimage.jpg', u'fb_test_directory/fb_tmp_dir', u'fb_test_directory/fb_tmp_dir/fb_tmp_dir_sub', u'fb_test_directory/fb_tmp_dir/fb_tmp_dir_sub/testimage.jpg'])
AssertionError: Lists differ: [u'fb_test_directory/testimage... != [u'fb_test_directory/testimage...

First differing element 1:
fb_test_directory/fb_tmp_dir/fb_tmp_dir_sub
fb_test_directory/fb_tmp_dir

  [u'fb_test_directory/testimage.jpg',
+  u'fb_test_directory/fb_tmp_dir',
   u'fb_test_directory/fb_tmp_dir/fb_tmp_dir_sub',
-  u'fb_test_directory/fb_tmp_dir/fb_tmp_dir_sub/testimage.jpg',
?                                                              ^

+  u'fb_test_directory/fb_tmp_dir/fb_tmp_dir_sub/testimage.jpg']
?                                                              ^

-  u'fb_test_directory/fb_tmp_dir']

----------------------------------------------------------------------
Ran 40 tests in 1.790s

FAILED (failures=1, errors=11)
Destroying test database for alias 'default'...

I wonder why are tests looking for PIL if it is a deprecated library, and even the README file says that Pillow has to be used instead...

Hi When I am adding a field like these:

FileBrowseField('testfield', format='media', max_length=255, blank=True)

or

FileBrowseField('testfield', format='image', max_length=255, blank=True)

It shows 0 result to me, but when I am adding like these:

FileBrowseField('testfield', format='Video', max_length=255, blank=True)

FileBrowseField('testfield', format='Image', max_length=255, blank=True)

It works OK, It seems you are looking for EXTENSIONS setting for format argument instead of SELECT_FORMATS setting. I think the extensions argument should look for EXTENSIONS setting (only if its value is a string) and format argument should look SELECT_FORMATS setting. Thank you.

Request Method: GET Request URL: http://localhost:8008/administracao/ Django Version: 1.6 Exception Type: ImportError Exception Value:

No module named defaults

Exception Location: /usr/local/envs/expoimob/local/lib/python2.7/site-packages/filebrowser/sites.py in get_urls, line 123

On /admin/filebrowser/browse/ I can't see images thumbs. I installed grappelli etc strict as documentation says. All works fine except thumb. Their generated HTML source looks that:

<td class="fb_thumbnail">
    <a href="/site_media/media/uploads/c7e2b502ad416f525fa38cb94dfcd933.png" class="fb_viewlink"><img src="" title="Zobacz obraz"></a>
</td>```

EDIT:
does not generate thumbs in virtualenv.

If VERSIONS_BASEDIR is specified, there is no need to filter file list while browsing directory. I use VERSIONS_BASEDIR to guarantee that user is unable to upload file incorrectly recognized as version file (and being hidden in browse view). Without this commit, user uploaded file "product_list_index.pdf" is hidden when there is "index" image VERSION.

In order to reproduce you need to run Django with Grapelli & FileBrowser on a Windows machine

1. Find a ImageField
2. Click Browse to open FileBrowser
3. Create a subdirectory
4. Click the subdirectory (you will see that the dir-query has backwards slash, due to Win)
5. Have an image on your hard drive that starts with letter "t"
6. Upload the image into the subdirectory
7. Click "Select"

You will now see a malformed string with "t" being replaced with tab character (javascript \t)

Hi,

I consider this a bug. I had the following situation: There was an image that was 61x59 px and I made a version preset with a size of 60x30 px. It did not rescale the image, even though I expecet it to do so. When I changed the version size to 64x32 px, it did rescale the image. This is my suggestion to fix it.

Bumps wheel from 0.37.1 to 0.38.1.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If a programmer configures django-filebrowser in settings.py like so:

FILEBROWSER_EXTENSIONS = {
    ...,  # other entries elided
    'Archive': ['.zip', '.tar', '.tar.gz', '.tar.xz']
}

...then a user will be shown the error: typeError: "{file} has invalid extension. Only {extensions} are allowed." when trying to upload a compressed tarball.

This is because _isAllowedExtension() sees myFile.tar.gz as simply ending in .gz, which is not in allowedExtensions.

_isAllowedExtension: function(fileName){

    // this trims ".tar.gz" to ".gz"
    var ext = (-1 !== fileName.indexOf('.')) ? fileName.substr(fileName.lastIndexOf('.')).toLowerCase() : '';

    var allowed = this._options.allowedExtensions;

    if (!allowed.length){return true;}        
    
    for (var i=0; i<allowed.length; i++){
        if (allowed[i].toLowerCase() == ext){ return true;}    
    }
    
    return false;
}, 

The naive solution is to change FILEBROWSER_EXTENSIONS to accept .xz or .gz (or whatever relevant extension). However, I would argue that this is problematic, as simply accepting all files ending in .gz or .xz is not the same as only accepting .tar.gz or .tar.xz.

Possible solution

(please note I have almost no JavaScript experience and haven't tested this)

_isAllowedExtension: function(fileName){

    var fileNameLower = fileName.toLowerCase()

    var allowed = this._options.allowedExtensions;
    if (!allowed.length){return true;}        
    
    for (var i=0; i<allowed.length; i++){
        if (fileNameLower.endsWith(allowed[i].toLowerCase())){ return true;}    
    }
    
    return false;
}, 

Edit 1: formatting

Edit 2: add permalink to source code

Add the ability to push extra context: example

def add_extra_context(self, request):
    
    query = request.GET.copy()

    if not query.get('pop'):
        from django.contrib.admin.sites import site
        return {
            'is_popup': query.get('pop'),
            'is_nav_sidebar_enabled': not query.get('pop'),
            'app_full_list': site.get_app_list(request),
        }
    else:
        return {}
  
FileBrowserSite.add_extra_context = add_extra_context

# My Custom FileBrowser site
custom_site = FileBrowserSite(name='custom_filebrowser', storage=DefaultStorage())

I notice there are a couple of references to a --force flag in the fb_version_generate code, e.g.: https://github.com/sehmaschine/django-filebrowser/blob/6686ffeb00bac1779539992d7bea6253522606f2/filebrowser/management/commands/fb_version_generate.py#L70

This would be a useful addition. Would you be happy to accept a pull request for that? Thanks

I have added video thumbnail support, and going to add more features soon. Will add:

• Video Trailer
• Video Versions (different resolutions)
• IS_STAFF_PERM_REQUIRED in settings
• Normal user can browse only his folders and files

Thank you :)