Dear authors:

Thank you for open source your work. I tried to reproduce your experiments on Ok-TopK by running sbatch vgg16_oktopk.h, but encountered the following error:

Exception in thread allreducer:
Traceback (most recent call last):
  File "<my-dir>/anaconda3/envs/py38_oktopk/lib/python3.8/threading.py", line 932, in _bootstrap_inner
    self.run()
  File "<my-dir>/anaconda3/envs/py38_oktopk/lib/python3.8/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "<my-dir>/frontera/Ok-Topk/VGG/allreducer.py", line 643, in run
    self._boundaries[new_name][i] = global_boundaries[i]
IndexError: index 0 is out of bounds for axis 0 with size 0
Exception in thread allreducer:
Traceback (most recent call last):
  File "<my-dir>/anaconda3/envs/py38_oktopk/lib/python3.8/threading.py", line 932, in _bootstrap_inner
    self.run()
  File "<my-dir>/anaconda3/envs/py38_oktopk/lib/python3.8/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "<my-dir>/<src-dir>/Ok-Topk/VGG/allreducer.py", line 643, in run
    self._boundaries[new_name][i] = global_boundaries[i]
IndexError: index 0 is out of bounds for axis 0 with size 0
Exception in thread allreducer:
Traceback (most recent call last):
  File "<my-dir2>/anaconda3/envs/py38_oktopk/lib/python3.8/threading.py", line 932, in _bootstrap_inner
    self.run()
  File "<my-dir2>//anaconda3/envs/py38_oktopk/lib/python3.8/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "<my-dir2>/<src-dir>/Ok-Topk/VGG/allreducer.py", line 643, in run
    self._boundaries[new_name][i] = global_boundaries[i]
IndexError: index 0 is out of bounds for axis 0 with size 0

Do you have any ideas on what happened here? The only changes I made is decreasing the number of nodes:

#SBATCH --nodes=4
#SBATCH --ntasks=4
...
nworkers="${nworkers:-4}"

Patching CVE-2007-4559

Hi, we are security researchers from the Advanced Research Center at Trellix. We have began a campaign to patch a widespread bug named CVE-2007-4559. CVE-2007-4559 is a 15 year old bug in the Python tarfile package. By using extract() or extractall() on a tarfile object without sanitizing input, a maliciously crafted .tar file could perform a directory path traversal attack. We found at least one unsantized extractall() in your codebase and are providing a patch for you via pull request. The patch essentially checks to see if all tarfile members will be extracted safely and throws an exception otherwise. We encourage you to use this patch or your own solution to secure against CVE-2007-4559. Further technical information about the vulnerability can be found in this blog.

If you have further questions you may contact us through this projects lead researcher Kasimir Schulz.

I was interested in your work on PPoPP'22, thank you for making the code open source. I tried to run the LSTM AN4 code, but cannot achieve the results claimed in the paper(WER=0.309 or 0.368)，only reach 0.46. I know I'm using a different environment, Perhaps you can give me some suggestions to improve the WER?

Here is the environment I use:

• 8*A100 within one server
• Horovod 0.22.1
• Here are the parameters I use: horovodrun -np 8 python horovod_trainer.py --dnn lstman4 --dataset an4 --max-epochs 1000 --batch-size 2 --nworkers 8 --data-dir ./audio_data --lr 0.001 --nwpernode 8 --nsteps-update 1

In addition, I also adjusted learning rate decay rate(In dl_trainer.py/_Adjust_Learning_Rate_LSTMan4() ). The original 1.01 May not be suitable for my environment, so I changed it to 1.005.

Thank you for seeing this, do you have any suggestions?

Bumps ujson from 4.0.2 to 5.2.0.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Thanks for your releasing Ok-Topk. It is an interesting work, and I am developing certain functions based this repo. I succeed in single-node training. However, when I try Ok-Topk across 2 nodes, a total 8 GPUs. I found that certain values in all_indexes are negative.

May I ask some suggestions about how to debug it?

Thanks.