This pull request has accomplished the following:

1. The main method has been simplified as it now uses a call() function from a newly created LedgerConvertor class instead of calling a method convert2ledger.
2. The classes Commodity, Account, Transaction, and Split all now have a str() function which will output readable text in Ledger format instead of using a toLedgerFormat method for each.
3. The docstrings have been updated.
4. The README.org file has been updated with an added "Future" section.

If invoked with -s gnucash2ledger emits the following error. The attached patch "fixes" the problem in that the -s functionality now works, but I'm sure it's not the proper soution. I'm not a python programmer but I'm guessing it's some kind of type mismatch with "None".

Error

Traceback (most recent call last):
  File "/Users/john/rwfin/2022/gnucash2ledger.py", line 791, in <module>
    main()
  File "/Users/john/rwfin/2022/gnucash2ledger.py", line 778, in main
    convertor = LedgerConvertor(args)
  File "/Users/john/rwfin/2022/gnucash2ledger.py", line 482, in __init__
    self.gcashData = GnucashData(
  File "/Users/john/rwfin/2022/gnucash2ledger.py", line 453, in __init__
    Account(self.accountDb, acc, useSymbols=useSymbols)
  File "/Users/john/rwfin/2022/gnucash2ledger.py", line 120, in __init__
    self.commodity = get_currency_symbol(
  File "/Users/john/rwfin/2022/gnucash2ledger.py", line 594, in get_currency_symbol
    return CurrencySymbols.get_symbol(currency_code) or currency_code
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/currency_symbols/currency_symbols.py", line 23, in get_symbol
    return CURRENCY_SYMBOLS_MAP.get(currency.upper(), None)
AttributeError: 'NoneType' object has no attribute 'upper'

Patch

currency_code.diff.txt

gnucash2ledger formats entries with a minimum single space between the account name and the amount. When this minimum is reached due to long account:sub-account strings, ledger complains and will not report. The attached patch increases the delimiter between account name and amount to a minimum of two spaces.

NOTE: This is a requirement of the ledger format. https://www.ledger-cli.org/3.0/doc/ledger3.html#The-Most-Basic-Entry

There must be at least two spaces, or a tab, between the amount and the account. If you do not have adequate separation between the amount and the account Ledger will give an error and stop calculating.

Ledger Error

While parsing file "/Users/john/rwfin/2022/fred.ledger", line 24:
Error: Only one posting with null amount allowed per transaction
While parsing file "/Users/john/rwfin/2022/fred.ledger", line 36:
Error: Only one posting with null amount allowed per transaction

Sample Data

22:2012-06-30 Reconcile to Asset Register - Disposal of Assets 30/06/2011
23-    ASSETS:NON-CURRENT ASSETS:Communications Equipment:Comm's Equip. Accum. Dep 5,132.00 AUD
24-    ASSETS:NON-CURRENT ASSETS:Communications Equipment:Comm's Equip. at Cost -5,132.00 AUD
25-
--
34:2012-06-30 Reconcile to Asset Register - Disposal of Assets 30/06/2011
35-    ASSETS:NON-CURRENT ASSETS:Computer Hardware:Computer H/W Accum. Dep. 61,319.19 AUD
36-    ASSETS:NON-CURRENT ASSETS:Computer Hardware:Computer H/W at Cost -61,319.19 AUD
37-

Patch

null_amount.diff.txt

The attached patch addresses the following error.

Error

Traceback (most recent call last):
  File "/Users/john/rwfin/2022/gnucash2ledger.py", line 791, in <module>
    main()
  File "/Users/john/rwfin/2022/gnucash2ledger.py", line 785, in main
    print(convertor())
  File "/Users/john/rwfin/2022/gnucash2ledger.py", line 563, in __call__
    results += self.add_transactions()
  File "/Users/john/rwfin/2022/gnucash2ledger.py", line 532, in add_transactions
    results += str(t)
  File "/Users/john/rwfin/2022/gnucash2ledger.py", line 355, in __str__
    splits = "\n".join(str(s) for s in self.splits)
  File "/Users/john/rwfin/2022/gnucash2ledger.py", line 355, in <genexpr>
    splits = "\n".join(str(s) for s in self.splits)
  File "/Users/john/rwfin/2022/gnucash2ledger.py", line 241, in __str__
    destCmdty=self.getAccount().commodity,
AttributeError: 'Split' object has no attribute 'getAccount'. Did you mean: 'get_account'?

Patch

get_account.diff.txt