i fixed the formatting to be a bit more traditional with the title always being the largest element, as well as just more appealing in my opinion. i also improved some wording and removed sudo where it did not need to be used (such as with the chmod command being used with sudo even when the user will have permission to make the file the executable).

I just noticed todo in the top, so I add --download-all feature, with a shorthand of -da, I also reorganized some parts and tried to minimized the redundancy of some part. Furthermore, the exception handling were also changed a bit, and I added func.py, to hold other functions, so the main source won't be clustered or become deorganized. I also add the deetupendencies and scripts to setup.py.

Also I added spinner while it is doing a task,e.g. downloading it shows as :

Downloading all fetched episodes. #<- green
Downloading episode 1 #<- cyan
▐____|\________▌#<- green Downloading the episode
Download complete! #<- green

Which is this in terminal :

Downloading all fetched episodes.
Downloading episode 1
▐____|\________▌Downloading the episode
Download complete! 

However, it removed the verbosity, so I think in order to add a verbose option or output, and making the code more organized, using argparse would be a better choice. I still don't touched or tried moving it to argparse yet, as I'm not the author of the file. And pardon for my partial intrusion in the development.

Also this feature is tested to some degree, but not intensively, so I think before merging it, playing with the patch first a handful of times would be a good idea.

I added a verbose parameter to show the download speed and other processes happening in download mode which can be done using -v or --verbose

[devel@fedora spongebob-cli]$ spongebob-cli -da -v
Downloading all fetched episodes : 338
Downloading episode 1
[generic] SpongeBob-SquarePants-Reef-Blower: Requesting header
[download] SpongeBob-SquarePants-Reef-Blower-SpongeBob-SquarePants-Reef-Blower.mp4 has already been downloaded
[download] 100% of 28.57MiB

Download complete!
Downloading episode 2
[generic] SpongeBob-SquarePants-Tea-at-the-Treedome: Requesting header
[download] Resuming download at byte 523264

and for single downloads :

[devel@fedora spongebob-cli]$ spongebob-cli -d 4 -v
Downloading episode 4
[generic] SpongeBob-SquarePants-Bubblestand: Requesting header
[download] SpongeBob-SquarePants-Bubblestand-SpongeBob-SquarePants-Bubblestand.mp4 has already been downloaded
[download] 100% of 77.02MiB

This PR contains the following changes:

• removing unnecessary variables
• improve some functionalities
• refactoring
• linting with black
• add other stuff to .gitignore
• Edit the contributor's list to be dynamically generated with icons

Installing on windows works fine When selecting episode an exception is raised:

.....
What episode do you want to watch? (type a number by the right side): 1
Now playing: https://www.megacartoons.net/video/SpongeBob-SquarePants-Help-Wanted.mp4

Traceback (most recent call last):
  File "C:\Users\User\spongebob-cli\spongebob-cli", line 214, in <module>
    Play(real)
  File "C:\Users\User\spongebob-cli\spongebob-cli", line 55, in Play
    subprocess.run(["mpv", DirectLink])
  File "C:\Users\User\AppData\Local\Programs\Python\Python39\lib\subprocess.py", line 505, in run
    with Popen(*popenargs, **kwargs) as process:
  File "C:\Users\User\AppData\Local\Programs\Python\Python39\lib\subprocess.py", line 951, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "C:\Users\User\AppData\Local\Programs\Python\Python39\lib\subprocess.py", line 1420, in _execute_child
    hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
FileNotFoundError: [WinError 2] The system cannot find the file specified

in https://github.com/trakBan/spongebob-cli/blob/main/spongebob-cli#L5-L11 if colored is missing code will use colorer to tell that colored is missing and fail because colored is missing

Some Unix Systems install this software under /usr/local/bin, and the uninstall script was not considering this.

Now, an OR statement was included to deal whether the app is inside /usr/bin or /usr/local/bin

*Also: After failed removal, the app is not launched anymore

The lines of code that raise SystemExit for the program to leave have arguments, those being simple quit messages, which mean when the program leaves it will return 1. This has been fixed by using a print instead.

Hi there! Love your work, man, but I cannot install it properly. Your code asks to install packages to the root files and I don't want to mess up my system. Should I create venv or maybe you should consider using another solution for automatic installation of packages?

Code

➜  spongebob-cli git:(main) chmod +x spongebob-cli
python3 setup.py install
running install
/usr/lib/python3.8/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(
/usr/lib/python3.8/site-packages/setuptools/command/easy_install.py:156: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(
error: can't create or remove files in install directory

The following error occurred while trying to add or remove files in the
installation directory:

    [Errno 13] Permission denied: '/usr/local/lib/python3.8'

The installation directory you specified (via --install-dir, --prefix, or
the distutils default setting) was:

    /usr/local/lib/python3.8/site-packages/

This directory does not currently exist.  Please create it and try again, or
choose a different installation directory (using the -d or --install-dir
option).

sometimes the source returns 503 status error due to server issues I think.

ERROR: Unable to download webpage: HTTP Error 503: Service Unavailable (caused by <HTTPError 503: 'Service Unavailable'>); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

• The spinner in download function were put back again, since it does not cause any error. During my testing before putting the spinner, the program is already returning only 143 or only 140's episode, not 300+, so I think it is rather a source problem. But I still didn't touched the Play function, only the download function.
• The code were also reorganized, the one prominent changes made is the function were passed onto each other instead of putting the returned value to another variable that will be used by another function. So instead of this :

...
source = VideoSource(episodes[x+1])
Download(source)
print(f"Episode {x+1} downloaded!", end="")
...

This was done instead :

...
Download(VideoSource(episodes[x+1]))
...

• raise SystemExit(ERROR_MESSAGE) was also used instead of :

...
print(ERROR_MESSAGE)
sys.exit()
...

since this one is more efficient.

• Duplicates of except KeyboardInterrupt were also removed.
• the output of subprocess calling youtube-dl were also redirected back into subprocess.DEVNULL and its STDERROR were also redirected back into subprocess.STDOUT
• else block were also used instead of try/except in some cases.
• Also, instead of specifying the number of episodes in list function, len(episodes) were used instead to avoid error.