This solves #10

There was a bug in grafana.api.put method: instead of JSON it was sending the request as application/x-www-form-urlencoded form data, so that's why it didn't work at all, basically resetting the home dashboard to 0.

Additionally I added Docker and Makefile and while at it I discovered that it doesn't build under Python 3.11, but didn't dig deeper into it.

Hi, This package seems great but I was unable to install it succesfully.

With poetry I got this error :

.poetry/bin/poetry run pip install grafana-dashboard-manager

  RuntimeError

  Poetry could not find a pyproject.toml file in /home/dtrckd or its parents

  at .poetry/lib/poetry/_vendor/py3.9/poetry/core/factory.py:369 in locate
      365│             if poetry_file.exists():
      366│                 return poetry_file
      367│ 
      368│         else:
    → 369│             raise RuntimeError(
      370│                 "Poetry could not find a pyproject.toml file in {} or its parents".format(
      371│                     cwd
      372│                 )
      373│             )

And with pip, it got installed, but can't execute with the following error

grafana-dashboard-manager     
Traceback (most recent call last):
  File "/home/dtrckd/.local/bin/grafana-dashboard-manager", line 5, in <module>
    from grafana_dashboard_manager.__main__ import app
  File "/home/dtrckd/.local/lib/python3.9/site-packages/grafana_dashboard_manager/__main__.py", line 21, in <module>
    import grafana_dashboard_manager.dashboard_upload
  File "/home/dtrckd/.local/lib/python3.9/site-packages/grafana_dashboard_manager/dashboard_upload.py", line 29, in <module>
    REPO = git.Repo(search_parent_directories=True)
  File "/home/dtrckd/.local/lib/python3.9/site-packages/git/repo/base.py", line 224, in __init__
    self.working_dir: Optional[PathLike] = self._working_tree_dir or self.common_dir
  File "/home/dtrckd/.local/lib/python3.9/site-packages/git/repo/base.py", line 307, in common_dir
    raise InvalidGitRepositoryError()
git.exc.InvalidGitRepositoryError

Any hints how to solve this ?

During the upload grafana-dashboard-manager tries to star the home dashboard in order to set it as default for the user.

It works well with --username/--password, but fails when using API key.

It's related to this: https://community.grafana.com/t/impossible-to-make-the-http-call-to-star-a-dashboard/300

This change should provide users an option to use a Grafana API token. I also make use of requests.Session to make sure Grafana session cookie persists across requests and for connection pooling; should be helpful when you got a lot of dashboards to download.

Motivation

• Following on from the merging of #7, I thought it was worthwhile to update the README.md content to mention this feature.
• I also found from my usage that the dump of a stack-trace on hitting a HTTP error was not useful. I have tidied this error up to be more legible.

Changes

• Update documentation to mention --token flag.
• Tidy up README.md content generally.
• Stop HTTP errors from printing a stack-trace to terminal.
• Print a clear HTTP error code & message.

Retrieving the version of grafana-dashboard-manager for the purpose of logging should not require that you are running inside of the git repository, or require you to run via poetry to succeed.

I have switched to using importlib.metadata from the stdlib to retrieve the package metadata which contains the version number.

Signed-off-by: Christian Witts [email protected]

Why

Dashboards can organise panels into rows, which help to group and structure panels. The output JSON would therefore be structured as follows:

{
  "rows": [
    {
      "panels": [{}]
    },
    {
      "panels": [{}]
    }
  ]
}

This was resulting in #3, as the program did not account for this edge case. This change resolves this.

What

• The change extracts the inner loop logic of update_dashlist_folder_ids out into a function.
• It introduces a conditional which checks if the dashboard actually has the panels attribute, if it has the rows attribute, or something else:
  • For the panels case, it uses a loop to call the function on each panel.
  • For the rows case, it uses a loop to cycle through each row, and then a nested loop to call the function on each panel.
  • For the something else, error.

Possible fix for #4 (Self Signed Certs?).

I also did some cleanup, added Path() to some places (failed otherwise, don't know the reason but I am using Python 3.10.4 and .venv instead of poetry).

Any support for self-signed certs?

(Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate (_ssl.c:1129)')))

I get this error when i try to download dashboards :

Found Zeus - Kubernetes App Metrics dashboard in folder API Management dashboard_download.py:80 Traceback (most recent call last): File "", line 1, in File "/home/clement/.cache/pypoetry/virtualenvs/grafana-dashboard-manager-GvvO0-hQ-py3.8/lib/python3.8/site-packages/typer/main.py", line 214, in call return get_command(self)(*args, **kwargs) File "/home/clement/.cache/pypoetry/virtualenvs/grafana-dashboard-manager-GvvO0-hQ-py3.8/lib/python3.8/site-packages/click/core.py", line 1128, in call return self.main(*args, **kwargs) File "/home/clement/.cache/pypoetry/virtualenvs/grafana-dashboard-manager-GvvO0-hQ-py3.8/lib/python3.8/site-packages/click/core.py", line 1053, in main rv = self.invoke(ctx) File "/home/clement/.cache/pypoetry/virtualenvs/grafana-dashboard-manager-GvvO0-hQ-py3.8/lib/python3.8/site-packages/click/core.py", line 1659, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) File "/home/clement/.cache/pypoetry/virtualenvs/grafana-dashboard-manager-GvvO0-hQ-py3.8/lib/python3.8/site-packages/click/core.py", line 1659, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) File "/home/clement/.cache/pypoetry/virtualenvs/grafana-dashboard-manager-GvvO0-hQ-py3.8/lib/python3.8/site-packages/click/core.py", line 1395, in invoke return ctx.invoke(self.callback, **ctx.params) File "/home/clement/.cache/pypoetry/virtualenvs/grafana-dashboard-manager-GvvO0-hQ-py3.8/lib/python3.8/site-packages/click/core.py", line 754, in invoke return __callback(*args, **kwargs) File "/home/clement/.cache/pypoetry/virtualenvs/grafana-dashboard-manager-GvvO0-hQ-py3.8/lib/python3.8/site-packages/typer/main.py", line 500, in wrapper return callback(**use_params) # type: ignore File "/home/clement/grafana-dashboard-manager/grafana_dashboard_manager/dashboard_download.py", line 52, in all _write_dashboards_to_local_folder_from_grafana_folder(folder, destination_dir) File "/home/clement/grafana-dashboard-manager/grafana_dashboard_manager/dashboard_download.py", line 86, in _write_dashboards_to_local_folder_from_grafana_folder dashboard_definition = update_dashlist_folder_ids(dashboard_definition) File "/home/clement/grafana-dashboard-manager/grafana_dashboard_manager/dashboard.py", line 58, in update_dashlist_folder_ids for panel in dashboard_definition["dashboard"]["panels"]: KeyError: 'panels'