Hi, can you check this page: http://dreamtravel.rs/sr-latn/destinacije/ i need that images to be full width and height, with zoom? I use it like this:

<img src="{% thumbnail article.thumbnail 966x330 upscale %}">
<img src="{% thumbnail category.image 406x200 crop upscale %}">

Tried with crop and upscale, but doesn't work. What is solution for this?

Hi,

I'm using amazon S3 as remote storage and easy-thumbnails for creating thumbnails. However, easy-thumbnails queries to db for each thumbnail and it is so slow to check existency and modified time of image for every thumbnail. Thus this makes using remote storage and easy-thumbnails together so slow. Actually, I think this is already a known issue.

I've forked your project and made some fixes for these issues. If you want to check, https://github.com/aykutozat/easy-thumbnails.

Basically, I changed your get_modtime methods for remote storages, it solved the query problem. However, checking the path and modified time of the image was still consuming much time. So I cache the modified time of thumbnails and source images.

Apart from all of these, there is still a problem which is saving the thumbnails into remote storage which consumes much time as well. I'm thinking of using celery for this issue. I will use user's local storage(media folder) for "temporary thumbnails" at first creation(or even maybe base64 format of the image can be used not sure) and pass the "real creation" to celery and after it creates the thumbnail, it will also delete the created "temporary thumbnail" from user's local storage.

I didn't want to open a pull request because I'm using cache which you may not like and I also want to add celery thing. However I wanted to take your opinions on my suggestions.

Thanks.

I am using easy-thumbnails 1.1 with THUMBNAIL_DEFAULT_STORAGE = 'storages.backends.s3boto.S3BotoStorage'

I have noticed that the time consumed by the get_thumbnailer is 4 time slower then using a local storage.

In my API I have to return about 20 thumbnails, and I build the with the following code:

try:
    avatar = request.build_absolute_uri(
        get_thumbnailer(friendship.friend.get_profile().avatar)['iPhoneAvatar'].url
    )
except InvalidImageFormatError:
    self.logger.error("Error loading avatar for user %s" % friendship.friend.username)
    avatar = None

Am I doing anything wrong? Is there any way to optimize the performances?

I'm getting the following error when trying to output a thumbnail in my Django template:

InvalidImageFormatError at /search/
The source file does not appear to be an image

This is happening with both JPEGs and PNGs. Here's how my template looks:

{% load thumbnail %}
{% thumbnail profile.profile_photo 220x160 %}

I have THUMBNAIL_DEBUG = True in my settings file and easy_thumbnails added to my installed apps.

In my requirements.txt:

Pillow==2.2.1
easy-thumbnails==1.4

And before people say I don't have png/jpeg support with Pillow/PIL here's a pip install -r requirements.txt:

Installing collected packages: PIL
  Running setup.py develop for PIL

    --------------------------------------------------------------------
    PIL 1.2a0 SETUP SUMMARY
    --------------------------------------------------------------------
    version       1.2a0
    platform      Python 2.7.3 (default, Apr 10 2013, 06:20:15)
                  [GCC 4.6.3] on linux2
    --------------------------------------------------------------------
    --- TKINTER support available
    --- JPEG support available
    *** WEBP support not available
    --- ZLIB (PNG/ZIP) support available
    --- FREETYPE2 support available
    *** LITTLECMS support not available
    --------------------------------------------------------------------
    To add a missing option, make sure you have the required
    library, and set the corresponding ROOT variable in the
    setup.py script.

    To check the build, run the selftest.py script.
    Creating /home/robbie/git/myproject/venv/lib/python2.7/site-packages/PIL.egg-link (link to .)
    PIL 1.2a0 is already the active version in easy-install.pth

So JPEG and PNG support are available. I'm also able to access the uploaded image from the browser by pointing to it's MEDIA_URL path. What gives?

edit: I also get the same error when trying to load a 3rd party image such as

{% thumbnail "http://www.gravatar.com/avatar/00000000000000000000000000000000?d=mm" 160x160 %}

I have a Profile model that looks something like this :

class Profile(Model):
    user = models.OneToOneField(User)
    avatar = ThumbnailerImageField(verbose_name=_("avatar"),
    upload_to="avatar",
    resize_source={"size": (150, 150)},   # <= This is the line that cause the problem
    blank=True, null=True)
   .....

Then somewhere in my I try to fetch an image from THE internet (aka Facebook :-) ) and stick it on the models. This blows in a mysterious way as soon as I add the resize_source argument.

The code look like something like this :

In [1]: from StringIO import StringIO
In [2]: from backstage.apps.accounts.models import Profile 
In [3]: from django.core.files.base import ContentFile
In [4]: from urllib2 import urlopen
In [5]: avatar_url = 'http://graph.facebook.com/100001437656687/picture?type=large'
In [6]: buffer = StringIO(urlopen(avatar_url, timeout=5).read())
In [7]: profile=Profile.objects.all()[1]
In [9]: profile.avatar.save('thefile.jpg', ContentFile(buffer.read()))

And the traceback is :

---------------------------------------------------------------------------
InvalidImageFormatError                   Traceback (most recent call last)
/srv/webapps/project/local/lib/python2.7/site-packages/django/core/management/commands/shell.pyc in <module>()
----> 1 profile.avatar.save('thefile.jpg', ContentFile(buffer.read()))

/srv/webapps/project/local/lib/python2.7/site-packages/easy_thumbnails/files.pyc in save(self, name, content, *args, **kwargs)
    519                 options['quality'] = self.thumbnail_quality
    520             import ipdb; ipdb.set_trace()
--> 521             content = Thumbnailer(content).generate_thumbnail(options)
    522         super(ThumbnailerImageFieldFile, self).save(name, content, *args,
    523                                                     **kwargs)

/srv/webapps/project/local/lib/python2.7/site-packages/easy_thumbnails/files.pyc in generate_thumbnail(self, thumbnail_options)
    258         if image is None:
    259             raise exceptions.InvalidImageFormatError(
--> 260                 "The source file does not appear to be an image")
    261 
    262         thumbnail_image = engine.process_image(image, thumbnail_options,

InvalidImageFormatError: The source file does not appear to be an image

This is akward because the file that I am grabbing seems to be a perfectly valid Image. Removing the resize_source argument make the issue not visible. And replacing the ThumbnailerImageField by a django's ImageField also works fine.

Am I doing something wrong in my save or is this a limitation/bug in easy-thumbnails. Thanks

This PR fixes some issues from #257.

Additionally, I added an optional postprocessor for image optimization. It can be activated by adding:

INSTALLED_APPS = (
    ...
    'easy_thumbnails.optimize'
    ...
)

and using the setting:

THUMBNAIL_OPTIMIZE_COMMAND = {
    'png': '/opt/local/bin/optipng {filename}',
    'gif': '/opt/local/bin/optipng {filename}',
    'jpeg': '/opt/local/bin/jpegoptim {filename}',
}

Sure, this could be installed as a 3rd party app, but consider that

• developers are strongly encouraged to optimize images after upload, so the audience is almost the entire user base of easy_thumbnail.
• this app contains less than 50 lines of code. Installing another micro-app from PyPI certainly is more embarrassing than getting some additional code, which in a few cases, might not be used.

Of course, if you don't like this embedded app approach, I'll move the optimizer into a micro-app. Docs and unittests will come.

BTW: I did not like the approach of image_diet, therefore I reused the idea from my previous patch. This one honors the storage object.

Hi Chris,

After a long long night I finally managed to add support for animated GIF images to easy-thumbnails.

It uses images2gif.py to extract all frames as PIL images. These frame images get processed by the thumbnail processors like every other still image. After they have been processed they get merged into one animated GIF (see Thumbnailer.generate_thumbnail).

Some animated GIFs react very badly to "resample=Image.ANTIALIAS" when resized. Therefore, I had to add a new "resample" kwarg to the default scale_and_crop processor (see easy_thumbnails/processors.py:158). This kwarg can be used to override the default behavior of Image.ANTIALIAS to Image.NEAREST. The NEAREST resample mode gets set explicitly when a GIF is getting processed (see easy_thumbnails/files.py:301). The downside is that resized GIFs do not have the best quality but the compatibility is improved. Maybe this is something that the user can specify in the Django settings (quality or compatibility)?

I thought this feature would be nice to have in the official version of easy-thumbnails. So feel free to add it! If you have any questions, do not hesitate to contact me!

Cheers Pascal

Hi, Is there a (quite) simple way to override thumbnail file names ? I prefer using a hash as a suffix instead of a string containing every thumbnail option.

I've taken a look at get_thumbnail_name but don't really know what to do from there.

easy_thumbnails used to raise an IOError when an invalid image was uploaded and save()'d. This behaviour changed around alpha 4 to this error

File "/home/pascal/yoosello/lib/python2.6/site-packages/easy_thumbnails/engine.py", line 30, in process_image
    image = processor(image, **processor_options)
File "/home/pascal/yoosello/lib/python2.6/site-packages/easy_thumbnails/processors.py", line 52, in colorspace
    if im.mode in ('L', 'RGB'):
AttributeError: 'NoneType' object has no attribute 'mode'

I made a patch that simply checks for the image object to be not None and raise a TypeError otherwise.

Hey,

the south migration with mysql fails with the current alpha-12 version.

easy_thumbnails:0010_rename_storage ! Error found during real run of migration! Aborting.

[...] File "/home/daniel/.virtualenvs/myenv/lib/python2.6/site-packages/easy_thumbnails/migrations/0010_rename_storage.py", line 13, in forwards db.drop_foreign_key('easy_thumbnails_source', 'storage_new_id') [...] raise ValueError("Cannot find a FOREIGN KEY constraint on table %s, column %s" % (table_name, column)) ValueError: Cannot find a FOREIGN KEY constraint on table easy_thumbnails_source, column storage_new_id

The for loop in get_existing_thumbnail calls repeatedly thumbnail_exists (terrible performance, see https://github.com/SmileyChris/easy-thumbnails/blob/master/easy_thumbnails/files.py#L381). The first of names does not exist but the second. Database and filesystem cache always fails, both are polled on every request. The JPG thumbnail can never be created as the PNG one already exists, nevertheless the check is done every time.

2014-01-14 00:32:07.622 get_existing_thumbnail NAMES [u'thumbnails/public/[email protected]__75x47_q85.jpg', u'thumbnails/public/[email protected]__75x47_q85.png'

After commit https://github.com/SmileyChris/easy-thumbnails/commit/7b9719e379916b19945623b8d3299a279e38c395, parameter 'quality' is not passed to pillow for any format except of 'JPEG'.

Django 4.1 added a system check to find duplicate template tags at startup. If easy-thumbnails and sorl-thumbnails are installed in the same project, it will detect the possible clash and will exit with an error. This happens even if the tags are not used in any template.

SystemCheckError: System check identified some issues:

ERRORS:
?: (templates.E003) 'thumbnail' is used for multiple template tag modules: 'easy_thumbnails.templatetags.thumbnail', 'sorl.thumbnail.templatetags.thumbnail'

I've added a minimal reproduction here: https://github.com/MarcoGlauser/template_tag_conflict Simply run a manage.py command like makemigrations

Facing import error while running migrate command for filer in Django application

error location "easy_thumbnails/engine.py"

Possible cause of errors was:

--file is importing modules using keywords that are not supported or depreciated now. --Using different versions of libraries that are depreciated.

I want to contribute to fix it

Hi there,

we had the issue that easy_thumbnail raised a 500 error (expected str, bytes or os.PathLike object, not NoneType) because our custom adapter to a cloud storage just returned a ContentFile without a name. We corrected this for ourselves by setting the name to ContentFile. Nevertheless it might be of interest to check if a name is set in eady_thumbnails at the following line of code:

https://github.com/SmileyChris/easy-thumbnails/blob/92060b9fd7b617cab1ac88d149dc5021d43b35c3/easy_thumbnails/files.py#L120

Regards

I accidentally ingested some bad images which are invalid data. Instead of failing silently as per normal, I end up with an uncaught exception when I try to render my page due to a ZeroDivisionError. This is very disruptive, and seems to go against the stated goal of the package to fail silently. Could I request error handling when source_x or source_y is zero?

  File "/Users/bixbyr/anaconda3/envs/Shelterware_v2/lib/python3.8/site-packages/django/template/base.py", line 1038, in render
    output = self.filter_expression.resolve(context)
  File "/Users/bixbyr/anaconda3/envs/Shelterware_v2/lib/python3.8/site-packages/django/template/base.py", line 728, in resolve
    new_obj = func(obj, *arg_vals)
  File "/Users/bixbyr/anaconda3/envs/Shelterware_v2/lib/python3.8/site-packages/easy_thumbnails/templatetags/thumbnail.py", line 301, in thumbnail_url
    raise e
  File "/Users/bixbyr/anaconda3/envs/Shelterware_v2/lib/python3.8/site-packages/easy_thumbnails/templatetags/thumbnail.py", line 298, in thumbnail_url
    thumb = get_thumbnailer(source)[alias]
  File "/Users/bixbyr/anaconda3/envs/Shelterware_v2/lib/python3.8/site-packages/easy_thumbnails/files.py", line 344, in __getitem__
    return self.get_thumbnail(options, silent_template_exception=True)
  File "/Users/bixbyr/anaconda3/envs/Shelterware_v2/lib/python3.8/site-packages/easy_thumbnails/files.py", line 508, in get_thumbnail
    thumbnail = self.generate_thumbnail(
  File "/Users/bixbyr/anaconda3/envs/Shelterware_v2/lib/python3.8/site-packages/easy_thumbnails/files.py", line 389, in generate_thumbnail
    thumbnail_image = engine.process_image(image, thumbnail_options,
  File "/Users/bixbyr/anaconda3/envs/Shelterware_v2/lib/python3.8/site-packages/easy_thumbnails/engine.py", line 35, in process_image
    image = processor(image, **processor_options)
  File "/Users/bixbyr/anaconda3/envs/Shelterware_v2/lib/python3.8/site-packages/easy_thumbnails/processors.py", line 179, in scale_and_crop
    scale = min(target_x / source_x, target_y / source_y)
ZeroDivisionError: float division by zero