For the sake of maintainability and also to enable easier control os CI services it would be much better to move this repo to a github organization

Thoughts @TheKevJames and @coagulant ?

I asked over https://github.com/lemurheavy/coveralls-public/issues/911

If the answer is not positive, I just created an organization called, coveralls-clients

If this does not already exists we could aggregate all other clients on this org.

Hello!

I have added logging, when some modules are not installed. I have a pure Linux Mint installation (pyyaml is not installed), and I have a project. There is .coveralls.yml, but coveralls does not work:

user@host ~/projects/project $ coveralls --verbose
You have to provide either repo_token in .coveralls.yml, or launch via Travis or CircleCI

I've spent a couple of hours, and found, that some exceptions were eaten in silence. It is bad. After patching:

user@host ~/projects/project $ coveralls --verbose
Seems, like some modules are not installed: No module named yaml
You have to provide either repo_token in .coveralls.yml, or launch via Travis or CircleCI

Changes

log.warn added to exc.handler block. This code will just notify user on absence of some modules (in my case - yaml)

Despite $COVERALLS_REPO_TOKEN being correctly defined and passed in (via tox), getting a 422 error on GitHub Actions https://github.com/casperdcl/git-fame/runs/1383075434?check_suite_focus=true#step:5:62 (https://github.com/casperdcl/git-fame/commit/20b3f10f084d4f176ce041c7ec7abd1fa948fa3a)

 Could not submit coverage: 422 Client Error: Unprocessable Entity for url: coveralls.io/api/v1/jobs

Note that codecov by comparison (using $CODECOV_TOKEN) works fine.

Thanks for this nice client.

It looks like since the github api was introduced, the Circle-CI version seems broken. When I try putting having a run that finishes up a parallel go, the wrong build number is being used to notify the service

(venv) circleci@b3cd35dd8048:~/project$ coveralls debug -v --finish
Missing .coveralls.yml file. Using only env variables.
Testing coveralls-python...
{"source_files": [], "git": {"branch": "coveralls", "head": {"id": "fad6a2cc6ab84ef45d06bf2150a4d103c16e1a76", "author_name": "Stephen Roller", "author_email": "[email protected]", "committer_name": "Stephen Roller", "committer_email": "[email protected]", "message": "Hm."}, "remotes": [{"name": "origin", "url": "git@github.
com:facebookresearch/ParlAI.git"}]}, "config_file": ".coveragerc", "parallel": true, "repo_token": "[secure]", "service_name": "circle-ci", "service_job_id": "48529", "service_pull_request": "2950"}
==
Reporting 0 files
==

Here you see that the CIRCLE_BUILD_NUM value has been put into "service_job_id" field of the config. In

However, the call to finish uses the "service_number" field instead:

https://github.com/coveralls-clients/coveralls-python/blob/30e4815169b3db2616981939d55d2f4495816821/coveralls/api.py#L217-L218

As such, when you try calling coveralls --finish you get the following error:

$ coveralls -v --finish
Missing .coveralls.yml file. Using only env variables.
Finishing parallel jobs...
Parallel finish failed: No build matching CI build number  found
Traceback (most recent call last):
  File "/home/circleci/venv/lib/python3.7/site-packages/coveralls/cli.py", line 80, in main
    coverallz.parallel_finish()
  File "/home/circleci/venv/lib/python3.7/site-packages/coveralls/api.py", line 236, in parallel_finish
    raise CoverallsException('Parallel finish failed: {}'.format(e))
coveralls.exception.CoverallsException: Parallel finish failed: No build matching CI build number  found

Note that Circle always puts None into the service_number field:

https://github.com/coveralls-clients/coveralls-python/blob/30e4815169b3db2616981939d55d2f4495816821/coveralls/api.py#L87

https://github.com/coveralls-clients/coveralls-python/blob/30e4815169b3db2616981939d55d2f4495816821/coveralls/api.py#L52-L59

Github Actions, and the coveralls side of support for it, seem to have changed/evolved. This PR brings coveralls-python in line with the official github action, which is commonly used to finish parallel builds.

Additionally, there is no need to manually provide your repo token anymore (though you still can, so existing setups should not be affected by this), since the native github support takes the automatically provided GITHUB_TOKEN instead, very similar to how things work on Travis. You do however have to export that GITHUB_TOKEN to an env var in your workflow.yml:

env:
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Apparently, Coveralls now supports branch coverage.

https://github.com/lemurheavy/coveralls-public/issues/31#issuecomment-284375195

I don't see the changes to the web API documented yet, but I do see that the Node client seems to support it via the branches key. branches is a sibling of coverage in the dictionary the client submits to Coveralls.

https://github.com/nickmerwin/node-coveralls/commit/15750503b69c3143b3020fa5d4fe4fc1d455356e https://coveralls.io/github/nickmerwin/node-coveralls?branch=master

Running coveralls or coveralls debug or coveralls debug --verbose gives me the following stack dump:

Testing coveralls-python...
Traceback (most recent call last):
  File "/tmp/ds/bin/coveralls", line 10, in <module>
    sys.exit(main())
  File "/tmp/ds/lib64/python3.7/site-packages/coveralls/cli.py", line 68, in main
    coverallz.wear(dry_run=True)
  File "/tmp/ds/lib64/python3.7/site-packages/coveralls/api.py", line 168, in wear
    json_string = self.create_report()
  File "/tmp/ds/lib64/python3.7/site-packages/coveralls/api.py", line 184, in create_report
    data = self.create_data()
  File "/tmp/ds/lib64/python3.7/site-packages/coveralls/api.py", line 238, in create_data
    self._data = {'source_files': self.get_coverage()}
  File "/tmp/ds/lib64/python3.7/site-packages/coveralls/api.py", line 260, in get_coverage
    return CoverallReporter(workman, workman.config).report()
  File "/tmp/ds/lib64/python3.7/site-packages/coveralls/reporter.py", line 47, in report
    self.parse_file(cu, analyzed)
  File "/tmp/ds/lib64/python3.7/site-packages/coveralls/reporter.py", line 158, in parse_file
    branches = self.get_arcs(analysis)
  File "/tmp/ds/lib64/python3.7/site-packages/coveralls/reporter.py", line 103, in get_arcs
    branch_lines = analysis.branch_lines()
AttributeError: 'Analysis' object has no attribute 'branch_lines'

This is with coverage 5.0a5 and coveralls 1.8.0. It looks to me like the coverage library recently changed branch_lines to _branch_lines in the Analysis class (see https://github.com/nedbat/coveragepy/commit/f869f4dfd7ccd2c9d4e6575d00ee3ad1a31757e3#diff-b696f62d55a35f1f75a13c5c7ecf2f68), and coveralls is still trying to access it under the old name. I think. Or maybe the issue is on my end; I don't know.

When trying to submit coverage on CircleCI I get the following error:

Couldn't find a repository matching this job.
'url'

$ pip freeze | grep coveralls
coveralls==1.1

I'm on the latest version of coveralls and according to the docs I don't need to set COVERALLS_REPO_TOKEN for CircleCI, what am I doing wrong?

Installation takes ~10 seconds per build

Due to all coverall-python's dependencies, installation takes around 10 seconds. Probably most of that time is spend on compiling PyYAML, only for parsing a config file most users will not be using. Also installing requests (great lib!) for doing a single post only, seems somewhat overkill. Reducing the external dependencies allows for a faster install, and speeds up all builds.

$ time pip install coveralls
Downloading/unpacking coveralls
  Downloading coveralls-0.3.zip
  Running setup.py egg_info for package coveralls
Downloading/unpacking PyYAML>=3.10 (from coveralls)
  Downloading PyYAML-3.10.tar.gz (241kB): 241kB downloaded
  Running setup.py egg_info for package PyYAML
Downloading/unpacking docopt>=0.6.1 (from coveralls)
  Downloading docopt-0.6.1.tar.gz
  Running setup.py egg_info for package docopt
Downloading/unpacking coverage>=3.6 (from coveralls)
  Downloading coverage-3.7.tar.gz (283kB): 283kB downloaded
  Running setup.py egg_info for package coverage
    warning: no previously-included files matching '*.pyc' found anywhere in distribution
Downloading/unpacking requests>=1.0.0 (from coveralls)
  Downloading requests-2.0.1.tar.gz (412kB): 412kB downloaded
  Running setup.py egg_info for package requests
Downloading/unpacking sh>=1.08 (from coveralls)
  Downloading sh-1.09.tar.gz
  Running setup.py egg_info for package sh
Installing collected packages: coveralls, PyYAML, docopt, coverage, requests, sh
  Running setup.py install for coveralls
    Installing coveralls script to /home/travis/virtualenv/python2.6/bin
  Running setup.py install for PyYAML
    checking if libyaml is compilable
    gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -I/usr/include/python2.6 -c build/temp.linux-x86_64-2.6/check_libyaml.c -o build/temp.linux-x86_64-2.6/check_libyaml.o
    checking if libyaml is linkable
    gcc -pthread build/temp.linux-x86_64-2.6/check_libyaml.o -lyaml -o build/temp.linux-x86_64-2.6/check_libyaml
    building '_yaml' extension
    (...)
  Running setup.py install for docopt
  Running setup.py install for coverage
    building 'coverage.tracer' extension
    gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -I/usr/include/python2.6 -c coverage/tracer.c -o build/temp.linux-x86_64-2.6/coverage/tracer.o
    gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions build/temp.linux-x86_64-2.6/coverage/tracer.o -o build/lib.linux-x86_64-2.6/coverage/tracer.so
    warning: no previously-included files matching '*.pyc' found anywhere in distribution
    Installing coverage2 script to /home/travis/virtualenv/python2.6/bin
    Installing coverage-2.6 script to /home/travis/virtualenv/python2.6/bin
    Installing coverage script to /home/travis/virtualenv/python2.6/bin
  Running setup.py install for requests
  Running setup.py install for sh
Successfully installed coveralls PyYAML docopt coverage requests sh
Cleaning up...
real    0m10.539s
user    0m8.336s
sys 0m0.781s

Using --use-mirrors, the result is only worse:

$ time pip install coveralls --use-mirrors
real    1m44.662s
user    0m10.684s
sys 0m1.183s

Fixes #139

Forced an install of the latest pytest (3.0.6) and found no errors. We should wait until CI works again before merging this, just to be sure.

I'm having troubles both locally and on travis-pro:

Locally, coveralls appears to ignore my .coveralls.yml file

$ coveralls
You have to provide either repo_token in .coveralls.yml, or launch via Travis or CircleCI
$ cat .coveralls.yml
repo_token: abcdefghijklmnop

and on travis-pro with .coveralls.yml set to

service_name: travis-pro
repo_token: abcdefghijklmnop

the travis build logs tell me

$ coveralls
Submitting coverage to coveralls.io...
Coverage submitted!
Couldn't find a repository matching this job.
'url'

I've confirmed that the repo_token is equal to the token on the coveralls page. Am I missing a step? Options to debug this?

I'm packaging your module as an rpm package so I'm using the typical PEP517 based build, install and test cycle used on building packages from non-root account.

• python3 -sBm build -w --no-isolation
• because I'm calling build with --no-isolation I'm using during all processes only locally installed modules
• install .whl file in </install/prefix>
• run pytest with PYTHONPATH pointing to sitearch and sitelib inside </install/prefix>

Here is list of installed modules in build env

Package                       Version
----------------------------- -----------------
alabaster                     0.7.12
asn1crypto                    1.5.1
attrs                         22.2.0
Babel                         2.11.0
bcrypt                        3.2.2
build                         0.9.0
cffi                          1.15.1
charset-normalizer            3.0.1
contourpy                     1.0.6
coverage                      7.0.1
cryptography                  38.0.4
cycler                        0.11.0
distro                        1.8.0
docopt                        0.6.2
docutils                      0.19
exceptiongroup                1.0.0
extras                        1.0.0
fixtures                      4.0.0
fonttools                     4.38.0
gpg                           1.18.0-unknown
idna                          3.4
imagesize                     1.4.1
importlib-metadata            5.1.0
iniconfig                     1.1.1
Jinja2                        3.1.2
kiwisolver                    1.4.4
libcomps                      0.1.19
MarkupSafe                    2.1.1
matplotlib                    3.6.2
numpy                         1.24.1
olefile                       0.46
packaging                     21.3
pbr                           5.9.0
pep517                        0.13.0
Pillow                        9.3.0
pip                           22.3.1
pluggy                        1.0.0
ply                           3.11
pyasn1                        0.4.8
pyasn1-modules                0.2.8
pycparser                     2.21
Pygments                      2.13.0
PyGObject                     3.42.2
pyparsing                     3.0.9
pytest                        7.2.0
python-dateutil               2.8.2
pytz                          2022.4
PyYAML                        6.0
requests                      2.28.1
responses                     0.22.0
rpm                           4.17.0
setuptools                    65.6.3
six                           1.16.0
snowballstemmer               2.2.0
Sphinx                        5.3.0
sphinxcontrib-applehelp       1.0.2.dev20221204
sphinxcontrib-devhelp         1.0.2.dev20221204
sphinxcontrib-htmlhelp        2.0.0
sphinxcontrib-jsmath          1.0.1.dev20221204
sphinxcontrib-qthelp          1.0.3.dev20221204
sphinxcontrib-serializinghtml 1.1.5
testtools                     2.5.0
toml                          0.10.2
tomli                         2.0.1
tpm2-pkcs11-tools             1.33.7
tpm2-pytss                    1.1.0
types-toml                    0.10.8
urllib3                       1.26.12
wheel                         0.38.4
zipp                          3.11.0

On Python 3.6, the tox test fails. On Python 3.5 and 3.7 or higher, it suceeds.

  py36-cov6-default run-test: commands[0] | coverage run --branch --source=coveralls -m pytest tests/
  ============================= test session starts ==============================
  platform linux -- Python 3.6.15, pytest-7.0.1, pluggy-1.0.0
  cachedir: .tox/py36-cov6-default/.pytest_cache
  rootdir: /home/runner/work/coveralls-python/coveralls-python
  collected 73 items
  
  tests/api_test.py .                                                      [  1%]
  tests/cli_test.py ..............                                         [ 20%]
  tests/git_test.py ........                                               [ 31%]
  tests/integration_test.py ...                                            [ 35%]
  tests/api/configuration_test.py s...................                     [ 63%]
  tests/api/encoding_test.py ..                                            [ 65%]
  tests/api/exception_test.py ...                                          [ 69%]
  tests/api/reporter_test.py .......F..                                    [ 83%]
  tests/api/wear_test.py ............                                      [100%]
  
  =================================== FAILURES ===================================
  ___________________ ReporterTest.test_reporter_with_branches ___________________
  
  self = <tests.api.reporter_test.ReporterTest testMethod=test_reporter_with_branches>
  
      def test_reporter_with_branches(self):
          subprocess.call(['coverage', 'run', '--branch', '--omit=**/.tox/*',
                           'runtests.py'], cwd=EXAMPLE_DIR)
          results = Coveralls(repo_token='xxx').get_coverage()
          assert len(results) == 2
      
          # Branches are expressed as four values each in a flat list
          assert not len(results[0]['branches']) % 4
          assert not len(results[1]['branches']) % 4
      
          expected_results = self.make_test_results(with_branches=True)
  >       assert_coverage(results[0], expected_results[0])
  
  /home/runner/work/coveralls-python/coveralls-python/tests/api/reporter_test.py:176: 
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
  
  actual = {'branches': [5, 0, 6, 1, 5, 0, ...], 'coverage': [1, 1, None, None, 1, None, ...], 'name': 'project.py', 'source': 'd...1:\n        print(\'condition tested both ways\')\n    if cond2:\n        print(\'condition not tested both ways\')\n'}
  expected = {'branches': [13, 0, 14, 1, 13, 0, ...], 'coverage': [1, 1, None, None, 1, None, ...], 'name': 'project.py', 'source':...1:\n        print(\'condition tested both ways\')\n    if cond2:\n        print(\'condition not tested both ways\')\n'}
  
      def assert_coverage(actual, expected):
          assert actual['source'].strip() == expected['source'].strip()
          assert actual['name'] == expected['name']
          assert actual['coverage'] == expected['coverage']
  >       assert actual.get('branches') == expected.get('branches')
  E       assert [5, 0, 6, 1, 5, 0, ...] == [13, 0, 14, 1, 13, 0, ...]
  E         At index 0 diff: 5 != 13
  E         Left contains 8 more items, first extra item: 15
  E         Full diff:
  E         - [13, 0, 14, 1, 13, 0, 15, 1, 15, 0, 16, 1, 15, 0, 12, 0]
  E         + [5, 0, 6, 1, 5, 0, 9, 1, 13, 0, 14, 1, 13, 0, 15, 1, 15, 0, 16, 1, 15, 0, 12, 0]
  E         ?  ++++++++++++++++++++++++
  
  /home/runner/work/coveralls-python/coveralls-python/tests/api/reporter_test.py:16: AssertionError
  ----------------------------- Captured stdout call -----------------------------
  world
  condition not tested both ways
  condition tested both ways
  condition not tested both ways
  =========================== short test summary info ============================
  FAILED tests/api/reporter_test.py::ReporterTest::test_reporter_with_branches
  =================== 1 failed, 71 passed, 1 skipped in 4.23s ====================
  Error: ERROR: InvocationError for command /home/runner/work/coveralls-python/coveralls-python/.tox/py36-cov6-default/bin/coverage run --branch --source=coveralls -m pytest tests/ (exited with code 1)

This is from run https://github.com/TheKevJames/coveralls-python/actions/runs/3765789223/jobs/6401619490

See for example here: https://github.com/TheKevJames/coveralls-python/actions/runs/3765678072

This is caused by GitHub Actions having changed ubuntu-latest to now be Ubuntu 22.04, for which it no longer provides Python 3.5 and 3.6.

This can be fixed by specifying the use of ubuntu-20.04 for Python 3.5 and 3.6.

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | coverage | >=4.1,<7.0,!=6.0.*,!=6.1,!=6.1.1 -> >=7,<7.1,!=6.0,!=6.1,!=6.1.1 | | | | |

Release Notes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

• [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

tox4 no longer allows space-separated passenv https://github.com/tox-dev/tox/issues/2615

however tox3 doesn't support VAR, either

so to support both versions of tox, use this funky space + comma separated syntax, which really does work.