Issue Description

Upon compiling the project, I have noticed that main.py does not even make use of pomo_gui.py and these can be considered as separate programs alone.

System Configuration:

• OS: Windows 11 Pro
• CPU: Ryzen 7 5800H with Radeon Graphics
• RAM: 16.00GB
• Program Version: N/A

Suggestions

Merge both programs to create a single program.

Changing the layout of the GUI (Can still be changed uwu)

Color Palette used: #EE4540 (Not yet used, meant for labels) #C72C41 (Used in texts) #801336 (Not yet used, might use for mid-tones to create depth) #510A32 (Used in Entry, Textbox, and Listbox background) #2D142C (Used in the background)

New features!

• To-do list
• Entry to let people add tasks
• Added a to-do list, insert, and delete button

A basic GUI built with Tkinter

functions -direct input through the timer itself -a button that starts the count -easy conversion of hours, minutes, and seconds -pops out a window once timer reaches 0

Issue

• clicking the window while the timer is active crashes it (it's not a bug, it's a feature)

Improvements needed:

• Better design

Changes;

• Line 37: Using a catch-all exception defeats the purpose of using except, it's important to know the error to pinpoint what when wrong, hence replaced with Exception as e to pinpoint the error and TypeError for type-related issues.
• Line 35, 38: I think it's important to let people know that they have entered 0 as a value so I put it there.
• Rename function TimeInput to time_input: PEP 8 - Function names should be lowercase, with words separated by underscores as necessary to improve readability.

main.py imports tkinter and time using * imports. This will pose an issue once we add more and more features (and thus modules) to Pomodrip. If a function from Tkinter and another function from a module have the same name, they will clash and cause errors. Changing to regular imports will improve the readability of code as well.

Suggested actions

• Change from tkinter import * to import tkinter as tk
• Change from timer import * to just import timer
• Update the functions that use tkinter to reflect the changes above like StringVar() to tk.StringVar()

fixed a minor bug

When starting the timer for the first time, the input display is "00," however, once used, the timer input display is "0."

• added new comments but did not change the format of the original (task assigned to @izayaaaaaaa)
• fixed 1 comment as it was in reverse
• "minutes to hours" to "hours to minutes."
• fixed the format of some code

Description

Added a pull request template for use with future PRs.

Fixes none

• [ ] Tick the box if the change requires a documentation update

Type of change

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [x] Documentation update
• [x] Others (please specify): Pull Request Template

How Has This Been Tested?

Is the code working on your side?

• [x] Yes
• [ ] No (why?)

Test Configuration:

• OS: N/A
• Processor: N/A
• IDE: N/A

Checklist:

• [X] My code follows the style guidelines of this project
• [X] I have performed a self-review of my own code
• [X] I have commented my code, particularly in hard-to-understand areas
• [X] I have made corresponding changes to the documentation
• [X] My changes generate no new warnings
• [X] Any dependent changes have been merged and published

Fixes #2

Decommission the original main.py, moving it into old_main.py. Development instead will continue at pomo_gui.py which will become the new main.py.

Still coding some parts but here are the current features this pull has

features

• Tabs
• Work and Rest input

current bugs

Visual bugs

• tabs are shown during counter
• when rest is active, the entry keeps the last entered number in place

After fixing a few bugs, I will soon add a way to pause the counter and save the current count to a progress bar.

The tabs as of now are empty but will be the next update.

As per:

• https://sider.review/gh/repos/401946274/branches/main/commits/a876b5f3424134ee02b2326723705f43e07cc02f#issue-183498871
• https://sider.review/gh/repos/401946274/branches/main/commits/a876b5f3424134ee02b2326723705f43e07cc02f#issue-183498872

Changes

• Convert tabs into spaces
• Fix formatting of function parameters

Original:

second_entry = tk.Entry(root, font = ("Arial", 24)
		, textvariable = second, width = 5
		, fg = "#C72C41", bg = "#510A32"
		, justify="center", bd = "0")

Updated:

second_entry = tk.Entry(root, font=(FONT, FONT_SIZE_ENTRIES),
                        textvariable=second, width=5,
                        fg=ENTRY_FOREGROUND, bg=ENTRY_BACKGROUND,
                        justify="center", bd="0")

• Overhaul the variable names to fit Pythonic conventions (Timing to timing)
• Refactor all repeated variables into their own constants for easier changing (Font, font size, background color, foreground color)

# Constants
TITLE = "PomoDrip"
FONT = "Arial"
BACKGROUND = "#2D142C"
ENTRY_FOREGROUND = "#C72C41"
ENTRY_BACKGROUND = "#510A32"
FONT_SIZE_ENTRIES = 24
FONT_SIZE_TODO = 12

• Group all function definitions together in code
• Put the main code into a main() function
• Add docstrings for all functions
• Add support for command-line arguments
• Todo list must be specifically enabled from the command-line with the argument --todolist

Command-line arguments

python3 main.py --help displays the help text of the program:

usage: pomodrip [--todolist]

PomoDrip is a tkinter-based Pomodoro Timer written in Python.

OPTIONS:
     --todolist   Enable a todo-list (EXPERIMENTAL)


Report bugs to https://github.com/algodrip/pomodrip/issues

To activate the todo list, type python3 main.py --todolist.

This is an experimental type of code, please do not merge it as it may break the main.py. Working on creating a fully customized title and menu bar to enable dark mode features uwu

After running some tests on the pomodrip application, this is what I've found:

Minor bugs

• [ ] When the timer reaches 0, the pop-up window does not show while the app is minimized
• [ ] There is a solution to fix the application from freezing when the timer is active; however, while dragging around the application, the timer would stop even with or without the solution
• [x] When starting the timer for the first time, the input display is "00," however, once used, the timer input display is "0"
• [ ] While dragging the screen, there is a delay between the original point and the area it was dragged to

Major bugs

• [ ] When trying to close the application while the timer is active, instead of closing properly it decides to crash itself to close the window (I mean it does do its job by closing the window but I believe there's a better solution to this to make it run more smoothly) (This bug can be groundbreaking as it might mean that it's gonna be hard to stop the timer halfway through once you initialize the countdown)

  Will come up with solutions once we're in the semi-final stages of development. Correct me if I'm wrong as I remembered when fixing bugs during the early development stages, you create hidden bugs in the future resulting in code dept. So in my suggestion, it's better to fix the groundbreaking bugs first and the minor ones later once we cross that bridge.