Frappe tinymce - Frappe app to replace default text editor with tinymce

** The Problem ** In the quill text editor that is available by default in Frappe, it's quite easy to paste images, one can take a screenshot on Windows with the Win + Shift + S shortcut and then go over to the editor and Ctrl + V and the image is there.

In the tinyMCE editor, when we typically try the same behaviour as above, the image does not auto-paste.

** What I've tried **

• Headed over to the tinyMCE website, tiny.cloud and checked whether it was a limitation on the editor side. Tried pasting an image into their online editor. Works without any problems.

** Solutions **

• To be discussed.

When create a new email, frappe will popup a dialog, if we access form doctype in here will throw undefined exception. Check undefined is necessary. Beside, send email action will call function get_input_value, the result will always empty because it use the function in class ControlCode. So, the extend class must override it.

Describe the bug The key and value of a Text Editor field are not included in the values object in the primary_action function of a dialog.

To Reproduce

frm.add_custom_button("Test dialog", function(){
            let test_dialog = new frappe.ui.Dialog({
                title: 'Enter details',
                fields: [
                    {
                        label: 'Text',
                        fieldname: 'test_txt',
                        fieldtype: 'Text Editor',
                    }
                ],
                primary_action_label: 'Submit',
                primary_action(values){
                    console.log(values)
                    test_dialog.hide()
                }
            })

            test_dialog.show()
        })

In the code above, I create a dialog with a Text Editor field with the name of test_txt. Then I type something, e.g. abcdef in the field and click Submit button.

The result is expected to be {test_txt: 'abcdef'}. But the result is {} instead.

My initial solution for getting the needed result is to use test_dialog.fields_dict.test_txt.value. But it would be better if it can be directly obtained from the values.

Please fix this issue. Thank you very much.

Desktop:

• OS: macOS.
• Browser: Chrome
• Frappe version: 14

Describe the bug This plugin is great, thanks so much for making it available! In my experience, it delivers on it's promise to load the TinyMCE editor instead of Quill in the standard text editor fields. Unfortunately, it simultaneously breaks the in-doc Email functionality in Frappe.

To Reproduce Steps to reproduce the behavior:

1. Install frappe_tinymce
2. Open any document.
3. Scroll down to the bottom and select "New Email"
4. See error in the browser console.

Expected behavior "New Email" should trigger a modal that allows the user to initiate a new email from the platform.

Actual behavior Nothing happens! The action just triggers an error in the console.

Additional context This was tested and triaged in both Firefox and Chrome browsers, on Frappe version 13 and 14 beta.

Here's the browser console error:

Uncaught TypeError: can't access property "open", o is undefined
tinymce.min.js:9:333666

And full browser console error log: erp.avu.nu-1648925803208.log