In this example output, the yellow block is split up, unnecessarily:

(from example at https://stackoverflow.com/questions/41400136/how-to-do-waffle-charts-in-python-square-piechart )

Shouldn't the rolling out of blocks go down one column, then up the next, then down the next, and so on, in order to ensure that coloured regions remain contiguous?

This PR changes the order of the legend to match the order of the plotted grids when plotting with vertical=True

Before this PR:

After this PR:

Signed-off-by: Alex Couture-Beil [email protected]

First of all, incredibly awesome and fun package. Thanks a lot!

I'm getting this warning in all the plots:

UserWarning: This figure includes Axes that are not compatible with tight_layout, so results might be incorrect. warnings.warn("This figure includes Axes that are not compatible ").

It seems a false positive in this context, right?

I'm making 50×20 grids, so each block is 0.1%. I've found that with some data, the top right corner ends up empty. Here's a real-world example:

#!/usr/bin/python3

import matplotlib as m
m.use("Agg")
import matplotlib.pyplot as plt
import matplotlib.dates as dates
from pywaffle import Waffle

m.style.use('seaborn-whitegrid')
m.rcParams['font.size'] = 12

fig = plt.figure( 
FigureClass=Waffle, 
 rows=20,
 columns=50,
 values={'32': 192,'33': 76,'34':59},
 figsize=[16, 9],
)              

fig.savefig('test.png',dpi=300)

            
plt.close()   

This results in:

... with an empty square in the top right -- a total of 999 squares instead of 1000.

I assume this is because all values are getting rounded down.

Each chart I create (python 3.7.4, PyWaffle 0.2.3) is coming out square regardless of what is passed in the columns parameter. Its as if the columns parameter is being overwritten by what is passed to rows

    plt.figure(
        FigureClass=Waffle,
        rows=5,
        columns=10,
        values=[150, 75, 25],
        figsize=(16, 9)
    );
    plt.savefig('example.png')

When using a pandas DataFrame, I keep getting this error, no matter what DataFrame I use:

Traceback (most recent call last):
  File "clean_input_file.py", line 177, in <module>
    main()
  File "clean_input_file.py", line 172, in main
    plot_res(data_FSW)
  File "clean_input_file.py", line 149, in plot_res
    title={'label': 'Vote Percentage in 2016 US Presidential Election', 'loc': 'left'}
  File "C:\Users\Pez Amaury\AppData\Local\Programs\Python\Python36-32\lib\site-packages\matplotlib\pyplot.py", line 548, in figure
    **kwargs)
  File "C:\Users\Pez Amaury\AppData\Local\Programs\Python\Python36-32\lib\site-packages\matplotlib\backend_bases.py", line 160, in new_figure_manager
    fig = fig_cls(*args, **kwargs)
  File "C:\Users\Pez Amaury\AppData\Local\Programs\Python\Python36-32\lib\site-packages\pywaffle\waffle.py", line 158, in __init__
    if (not self.fig_args['values'] or not self.fig_args['rows']) and not self.plots:
  File "C:\Users\Pez Amaury\AppData\Local\Programs\Python\Python36-32\lib\site-packages\pandas\core\generic.py", line 1573, in __nonzero__
    .format(self.__class__.__name__))
ValueError: The truth value of a Series is ambiguous. Use a.empty, a.bool(), a.item(), a.any() or a.all().

I understand this is due to using operators or/and in waffle.py, so changing them to np.logical_and and np.logical_or would probably solve the problem.

Here's the dataFrame I'm using:

Variables ART last 12 months 0.0 Access to condoms last 12 months 0.0 Any STI treatment last 12 months 0.0 Clean needles/syringes at last injection 0.0 Condom use at last time they had sex 0.0 Condom use when had anal sex last time with a male partner 0.0 Condom use when had sex last time with a commercial client 0.0 HBV Prevalence 0.0 HCV Prevalence 0.0 HIV Prevalence 0.0 HIV incidence 0.0 HIV test history 0.0 HIV test in last 12 months 0.0 HIV-1 Prevalence 0.0 HIV-2 Prevalence 0.0 OST/MMT last 6 months 0.0 Other STI Prevalence 0.0 Received HIV test results 0.0 STI test last 12 months 0.0 Syphilis Prevalence 0.0 Name: 2001, dtype: float64

Hi there! Firstly, just wanted to say I absolutely love this package - it works so seamlessly, and you've really thought of everything in terms of how people might want to tweak things to make some beautiful visualisations!

I noticed that Font Awesome released v6 (in Feb 2022) which have quite a few new icons, so I thought I'd bump the version to their latest. Do let me know if it's not just a matter of bumping the version here!

I notice that files from the Font Awesome project are being used. The project's license requires attribution. IANAL, and I am not affiliated with that project, but I think there probably needs to be a license file for these files, and this needs to be in the MANIFEST.in file (see #18) so it is included in sdists.

I made METHOD_MAPPING global so that it is only created one time during loading time. Also math.ceil is used to replace the ceil function you wrote. :) block_iter is a generator now.

Hello,

Thanks for creating this module, it's really useful and pretty straightforward to use.

One thing I've noticed is that the module currently uses FontAwesome v4.7.0, with the latest version of FA being v5.5.0. It'd be nice to be able to use the latest set of icons and updating the equivalence should be relatively straightforward through the cheatsheet they provide, but the download is now (I believe since 5.0) split into three .otf files - "solid", "regular" and "brands". I see there being two ways to deal with this:

1. Pick one of the new three to have as the main reference. The "regular" is I think meant to be the most similar to the old icons, but the "solid" is the most complete.
2. Keep all three and either:
   1. Add an extra parameter to choose which of the three icon sets to use (e.g. icon_set as a string).
   2. Rename the icon lookups to include which set they come from, and ensure the user only uses icons from one set.

I am happy to work on a PR for this based on your preference. I think 2i would work best (and might start looking at implementing it), but will defer to your judgement. There may also be some compatibility issues with name changes, but I think it's worth it for the wider set of icons available.

Thanks,

Adam

Hi, I tried your last example Multiple plot and had the following error

figsize=(9, 5) # figsize is a parameter of plt.figure File "/usr/local/lib/python3.6/dist-packages/matplotlib/pyplot.py", line 533, in figure **kwargs) File "/usr/local/lib/python3.6/dist-packages/matplotlib/backend_bases.py", line 160, in new_figure_manager fig = fig_cls(*args, **kwargs) File "/usr/local/lib/python3.6/dist-packages/pywaffle/waffle.py", line 165, in init self._waffle(loc, **copy.deepcopy(setting)) File "/usr/local/lib/python3.6/dist-packages/pywaffle/waffle.py", line 174, in _waffle if len(self._pa['values']) == 0 or not self._pa['rows']: KeyError: 'rows'

Is there a way to enable fractional blocks, so that there is no rounding? I'm especially running into issues where the rounding causes the total number of blocks to fluctuate, as in the example below. Both datasets total to 87.46 but the top plot has an extra block. It'd be great if the last block could have fractional size, and if the intermediate blocks could have split colors.

Code to reproduce:

plot1 = {'Net income': 18.46, 'Income tax': 1.64, 'MG&A': 7.52, 'R&D': 15.3, 'Cost of sales': 44.54}
plot2 = {'Misc income': 1.2, 'Revenue': 86.26}
fig = plt.figure(
    FigureClass=Waffle,
    plots={
        311: {'values':plot1},
        312: {'values':plot2}
    },
    rows=5,
    figsize=(9, 7),
    legend={'loc': 'upper left', 'bbox_to_anchor': (1.1, 1)},
    block_arranging_style='snake',
)

In Fedora, we have FontAwesome as an included package, and our packaging guidelines require bundled fonts to be ... debundled.

I've patched this in to my package build scripts (see https://mattdm.org/misc/fedora/pywaffle/python-pywaffle.spec), but it would be ideal if the library just noticed and used those. I guess this could be a "build time" thing, but I'm thinking maybe if

/usr/share/fonts/fontawesome5-free-fonts/Font Awesome 5 Free-Regular-400.otf
/usr/share/fonts/fontawesome5-free-fonts/Font Awesome 5 Free-Solid-900.otf
/usr/share/fonts/fontawesome5-brands-fonts/Font Awesome 5 Brands-Regular-400.otf

are installed, those could be automatically used -- with the mappings created at runtime from /usr/share/fontawesome5/metadata/icons.json.

That'd also benefit people who install via pip or whatever.

What do you think?

There seem to be a problem when saving figures as pdf with matplotlib.pyplot.savefig and using the characters argument in Waffle: some characters are replaced by others.

list_character = ["🖳", "🐍"]

from pywaffle import Waffle
from matplotlib import pyplot as plt

n_row = 4
n_column = 5

import numpy as np
list_value = np.ones(len(list_character))

fig = plt.figure(
    FigureClass=Waffle,
    rows=1,
    columns=len(list_character),
    values=list_value,
    characters=list_character,
    font_file="~/.fonts/Symbola.ttf",
    font_size=50
    )

plt.savefig("replaced_character.pdf")
plt.close("all")

yields the attached file (two snakes instead of a computer and a snake). The computer alone is correctly printed. Inverting the order yields two snakes.

replaced_character.pdf

When plotting a larger number of blocks, the width of the white space between them become unstable:

plt.figure(
    FigureClass=Waffle,
    rows=20,
    columns=80,
    values=[300, 700],
    figsize=(18, 10)
);
plt.savefig('example.png')

This is probably outside the original scope of the package and maybe should even be discouraged, but sometimes is useful to give the reader the impression of dealing with a large population. Feel free to close this issue.